Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Dan Sugalski
At 3:09 PM -0400 5/21/02, Mike Lambert wrote: >But I think the strstart is a better idea regardless. It's what perl5 did >anyway, isn't it? That's not necessarily an endorsement of an idea as good... :) -- Dan --"it's

Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Mike Lambert
> Actually, we don't. (Sez the man catching up on altogether too much > mail) Since we're putting the COW stuff at the tail end, substrings > of COW strings are fine. You set the bufstart to where the substring > starts, buflen set so it goes to the end of the original buffer, and > the string len

Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Dan Sugalski
At 11:11 AM -0700 5/21/02, Steve Fink wrote: >On Tue, May 21, 2002 at 01:38:45PM -0400, Dan Sugalski wrote: >> At 5:27 PM + 5/21/02, "Peter Gibbs" (via RT) wrote: >> > > I think I'd like these differently. STRING is a subclass of Buffer, >> >> and the bufstart and buflen fields in Buffers p

Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Steve Fink
On Tue, May 21, 2002 at 01:38:45PM -0400, Dan Sugalski wrote: > At 5:27 PM + 5/21/02, "Peter Gibbs" (via RT) wrote: > > > I think I'd like these differently. STRING is a subclass of Buffer, > >> and the bufstart and buflen fields in Buffers point to the actual > >> start of memory and length o

Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Dan Sugalski
At 5:27 PM + 5/21/02, "Peter Gibbs" (via RT) wrote: > > I think I'd like these differently. STRING is a subclass of Buffer, >> and the bufstart and buflen fields in Buffers point to the actual >> start of memory and length of allocated data. I'd rather keep it that >> way, and have the 're

Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Peter Gibbs
> I think I'd like these differently. STRING is a subclass of Buffer, > and the bufstart and buflen fields in Buffers point to the actual > start of memory and length of allocated data. I'd rather keep it that > way, and have the 'real' string length and string start be extra > fields in the STRIN

Re: [netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Dan Sugalski
At 4:14 PM + 5/21/02, "Peter Gibbs" (via RT) wrote: >* New field 'buffer' in STRING points to the start of the allocated buffer. >I have put this field immediately after the Buffer fields, in case we want >to create a generic subclass of Buffer with the same functionality >* The existing 'bufs

[netlabs #607] [PATCH] COW strings (again)

2002-05-21 Thread Peter Gibbs
# New Ticket Created by "Peter Gibbs" # Please include the string: [netlabs #607] # in the subject line of all future correspondence about this issue. # http://bugs6.perl.org/rt2/Ticket/Display.html?id=607 > Attached is another patch to implement copy-on-write strings. Summary of changes *