Re: [RFC] merge stack_common.c and stacks.c

2008-06-30 Thread Andrew Dougherty
On Sun, 29 Jun 2008, Andrew Whitworth wrote: > There are a few other simplifications that I think can be made also. > For instance, in calculating the size of a new Stack_Chunk_t, we use > the convoluted equation "size = sizeof(Stack_Entry_t) + > offsetof(Stack_Chunk_t, u.data)", which is much mor

Re: [RFC] merge stack_common.c and stacks.c

2008-06-29 Thread Andy Lester
On Jun 29, 2008, at 1:23 PM, Andrew Whitworth wrote: After all the efforts to simplify Parrot's stack situation, it seems to me like src/stack_common.c and src/stacks.c can be merged. Are you saying you want to do it, or asking someone else to? I'd be glad to do that. C-level source, tha

[RFC] merge stack_common.c and stacks.c

2008-06-29 Thread Andrew Whitworth
After all the efforts to simplify Parrot's stack situation, it seems to me like src/stack_common.c and src/stacks.c can be merged. After a quick search, none of the functions from stack_common.c are used anywhere except in stacks.c. Some functions from the former are completely redundant. For insta