> I have checked in some functionality for string bitwise ops.
> - vtable
> - B, B opcodes
> - string_bitwise_{or,and} functions in string.c
> - minimal tests
>
> Missing:
> - B ops
> - support for perl scalar PMCs
>
> I'd be glad if someone wants to continue that stuff.
The patch below implements
> At 1:35 AM +0300 8/8/03, Vladimir Lipskiy wrote:
> > > What in $DEITY's name is *that*? It sure isn't a context diff.
> >> A context diff is what you get from "diff -u" or "diff -c".
YAY! Thanks Chip for you caustic remark -- it made me to
know about how to get a context diff with WinCVS.
Da
> According to Vladimir Lipskiy:
> > The patch below implements the missing XORS ops.
>
> Context diffs preferred, I think.
Sure.
Index: string.c
===
RCS file: /cvs/public/parrot/string.c,v
retrieving revision 1.141
diff -r1.141 stri
> What in $DEITY's name is *that*? It sure isn't a context diff.
> A context diff is what you get from "diff -u" or "diff -c".
What you saw was the context diff I provided myself (~:
I doubt it's possible to provide a context diff WinCVS.
Though, I could be mistaken.
Recently I found some logic redundancy in string_bitwise_or
and this seems like I quite forgot to correct that in my just now
sent patch. Sorry.
Index: string.c
===
RCS file: /cvs/public/parrot/string.c,v
retrieving revision 1.141
di
According to Vladimir Lipskiy:
> STRING *res;
> size_t len;
>
> < len = s1 ? s1->bufused : 0;
> < if (s2 && s2->bufused < len)
> < len = s2->bufused;
> <
> < if (dest && *dest)
> ---
> >if (dest && *dest)
> res = *dest;
> else if (!s1 || !s2)
> r
At 1:35 AM +0300 8/8/03, Vladimir Lipskiy wrote:
> What in $DEITY's name is *that*? It sure isn't a context diff.
A context diff is what you get from "diff -u" or "diff -c".
What you saw was the context diff I provided myself (~:
I doubt it's possible to provide a context diff WinCVS.
Though, I
Vladimir Lipskiy <[EMAIL PROTECTED]> wrote:
> The third attempt, here it is:
Applied finally, thanks for the patch.
Some minor notes: please send patches as attachments (some lines got
wrapped). And as already mentioned please try to figure out, how to get a
unified diff: "cvs diff -u ...".
Ther
I have checked in some functionality for string bitwise ops.
- vtable
- B, B opcodes
- string_bitwise_{or,and} functions in string.c
- minimal tests
Missing:
- B ops
- support for perl scalar PMCs
I'd be glad if someone wants to continue that stuff.
Have fun,
leo
