Re: [perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-24 Thread Geoffrey Broadwell
On Thu, 2008-04-24 at 21:53 -0700, Mark Glines wrote: > On Thu, 24 Apr 2008 20:48:34 -0700 > Geoffrey Broadwell <[EMAIL PROTECTED]> wrote: > > my $platform = $os =~ /mswin32/i && $cc =~ /^gcc/i ? 'win32_gcc' : > > $os =~ /mswin32/i ? 'win32_other' : > >

Re: [perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-24 Thread Mark Glines
On Thu, 24 Apr 2008 20:48:34 -0700 Geoffrey Broadwell <[EMAIL PROTECTED]> wrote: > Also, the implementation of C<_add_to_libs> is a little wordy. How's > this? > > sub _add_to_libs { > my ($self, $args) = @_; > croak "_add_to_libs() takes hashref" unless ref($args) eq 'HASH'; > >

Re: [perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-24 Thread Geoffrey Broadwell
On Thu, 2008-04-24 at 19:55 -0700, James Keenan via RT wrote: > Please see patch attached. It turned out that config/auto/opengl.pm > didn't quite conform to the pattern, so I left it unchanged. Other than having a Darwin case, how is it different than the pattern? Also, the implementation of C<

[perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-24 Thread James Keenan via RT
On Wed Apr 23 18:40:46 2008, [EMAIL PROTECTED] wrote: > There are five configuration step classes where the class's runstep() > method has an internal subroutine called _handle_mswin32(). These > classes are: > > config/auto//crypto.pm > config/auto//gettext.pm > config/auto//gmp.pm > config/

[perl #52842] [CORE] Remove stack.ops and user_stack

2008-04-24 Thread Patrick R. Michaud via RT
r27160 eliminates the STACK_ENTRY_(INT|FLOAT|STRING|POINTER) constants and the cases that were using them in src/stacks.c . Closing ticket. Pm

[perl #53302] [RFE] controlling :method entries in namespace

2008-04-24 Thread via RT
# New Ticket Created by Patrick R. Michaud # Please include the string: [perl #53302] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=53302 > Short version: Methods should not be automatically entered into a namespace, as t

Re: [perl #53264] [PATCH] Re: [svn:parrot] r27144 - in trunk: include/parrot src src/pmc

2008-04-24 Thread chromatic
On Thursday 24 April 2008 12:08:57 Andy Dougherty wrote: > Oops. It won't work because I missed a level of indirection. > > > -return STACK_DATAP(new_chunk); > > That used to return &(new_chunk->u.data) > > > +return new_chunk->u.stdata; > > And this returns new_chunk->u.stdata instead.

Re: [perl #53264] [PATCH] Re: [svn:parrot] r27144 - in trunk: include/parrot src src/pmc

2008-04-24 Thread Andy Dougherty
On Wed, 23 Apr 2008, Andy Dougherty wrote: > 2. There are some casting and type-punning warnings that have, as their > ultimate cause, the STACK_DATAP() macro. Getting rid of the > type-punning warning gives rise to a cast alignment warning. > > Looking up a level, the only uses for that macro

[perl #52842] [CORE] Remove stack.ops and user_stack

2008-04-24 Thread Bob Rogers
From: "Patrick R. Michaud via RT" <[EMAIL PROTECTED]> Date: Wed, 23 Apr 2008 23:10:31 -0700 As of r27155 the user_stack data structure has been removed from the core. Yay Patrick! After removing stack.ops, the constants STACK_ENTRY_INT, STACK_ENTRY_FLOAT, STACK_ENTRY_STRING, and S

Re: [perl #52842] [CORE] Remove stack.ops and user_stack

2008-04-24 Thread Will Coleda
On Thu, Apr 24, 2008 at 2:10 AM, Patrick R. Michaud via RT <[EMAIL PROTECTED]> wrote: > As of r27155 the user_stack data structure has been removed from the core. > > After removing stack.ops, the constants STACK_ENTRY_INT, > STACK_ENTRY_FLOAT, STACK_ENTRY_STRING, and STACK_ENTRY_POINTER > aren'

Re: [perl #52842] [CORE] Remove stack.ops and user_stack

2008-04-24 Thread Andrew Whitworth
PDD09 lists 3 stacks which are cleaned by the collector, the system stack, the pmc register stack, and the general/user stack. Do all of these still exist? If not, this is a small update to make. --Andrew Whitworth On Thu, Apr 24, 2008 at 2:10 AM, Patrick R. Michaud via RT <[EMAIL PROTECTED]> wro

[perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-24 Thread James Keenan via RT
I think this is an idea worth exploring, but we'll have to re-survey the current config step classes carefully before proceeding. There are certain methods (_init and runstep) which are part of the public interface each class must implement. _init(), in turn, must provide a 'description' attribute

Re: mod_parrot uses string_nprintf

2008-04-24 Thread Donald Hunter
On 22/04/2008, Jeff Horwitz <[EMAIL PROTECTED]> wrote: > > On Tue, 22 Apr 2008, Donald Hunter wrote: > > hi donald! > > hm, i thought i committed the fix for this, but apparently not. check out > r334 in the mod_parrot repository. Great, that fixed my build problem, thanks. I needed to change Co