RE: +2 Axe of Refactoring: packfile.c

2002-03-10 Thread Brent Dax
Simon Cozens: # People were complaining about bloat already? Well, I'm not a # great believer in # taking 1800 lines to do what you can do more clearly in 700; # nor taking 43 # functions, many of which are completely unused, to do the # work of 14. This # refactoring does not attempt to disguise

Re: +2 Axe of Refactoring: packfile.c

2002-03-10 Thread Michael G Schwern
(Apologies to Michael Brown) Yesterday on perl6-intern-, packfile.c died. And they got that brit Simon on a charge of homicide Some folks say he didn't do it others say of course he did But they all agree, Mr Simon C. was a problem kinda kid 'Cause you can't chop your Parrot up on Perl 6 Porters

+2 Axe of Refactoring: packfile.c

2002-03-10 Thread Simon Cozens
People were complaining about bloat already? Well, I'm not a great believer in taking 1800 lines to do what you can do more clearly in 700; nor taking 43 functions, many of which are completely unused, to do the work of 14. This refactoring does not attempt to disguise the fact that C is not objec

Re: PMC change: was RE: cvs commit: parrot/lib/Parrot Assembler.pm

2002-03-10 Thread Simon Cozens
Melvin Smith: > Agreed, hence my mail last night asking for objections. I didn't object. :) But I do think that patching the current interpreter is slightly futile, since I've got about three-quarters of the new one done and it's a damned sight simpler. Simon -- [Bastille Linux] Of course, if

Re: [BUG] Integer overflow in JIT mode?

2002-03-10 Thread Melvin Smith
At 05:57 PM 3/10/2002 -0500, Simon Glover wrote: > In Parrot's standard operational mode, the following code[1]: > > set N2, -2147483648.0 > set I2, N2 > print I2 > print "\n" > end > > produces the output: > > -2147483648 > > but in JIT m

[APPLIED] Re: [PATCH] PerlString tests

2002-03-10 Thread Nicholas Clark
On Sun, Mar 10, 2002 at 05:22:18PM -0500, Simon Glover wrote: > > More tests for the PerlString test-suite. On Sun, Mar 10, 2002 at 05:19:51PM -0500, Simon Glover wrote: > > Self-explanatory. > +output_is(

[BUG] Integer overflow in JIT mode?

2002-03-10 Thread Simon Glover
In Parrot's standard operational mode, the following code[1]: set N2, -2147483648.0 set I2, N2 print I2 print "\n" end produces the output: -2147483648 but in JIT mode (on an x86) it produces: -0 This smacks of some kind of overfl

RE: new_tracked_header()

2002-03-10 Thread Brent Dax
Melvin Smith: # I'm confused on the intent of the following: # # Buffer *new_tracked_header(struct Parrot_Interp *interpreter, # size_t size) { #UNUSED (interpreter); #return (Buffer *)mem_sys_allocate(size); # } # # # A Buffer is a fixed size struct with void * for data, # however, this t

new_tracked_header()

2002-03-10 Thread Melvin Smith
I'm confused on the intent of the following: Buffer *new_tracked_header(struct Parrot_Interp *interpreter, size_t size) { UNUSED (interpreter); return (Buffer *)mem_sys_allocate(size); } A Buffer is a fixed size struct with void * for data, however, this takes a size argument. I assume

PMC change: was RE: cvs commit: parrot/lib/Parrot Assembler.pm

2002-03-10 Thread Melvin Smith
At 02:24 PM 3/10/2002 -0800, Brent Dax wrote: ># Single line changes to add a size argument to a the constructors. > >Small diff, big changes. A one-line diff in the right place can >increase or decrease size or speed a thousandfold. This alters the Agreed, however I hope any of us with commit

[PATCH] PerlString tests

2002-03-10 Thread Simon Glover
More tests for the PerlString test-suite. Simon --- t/pmc/perlstring.t.old Sun Mar 10 14:14:16 2002 +++ t/pmc/perlstring.t Sun Mar 10 17:14:29 2002 @@ -1,8 +1,51 @@ #! perl -w -use Parrot::Test tests => 6; +use Parrot::Test tests => 8; use Test::More; # Included for skip().

[PATCH] Test for sleep with negative argument

2002-03-10 Thread Simon Glover
Self-explanatory. Simon --- time.t.old Sun Mar 10 13:47:03 2002 +++ time.t Sun Mar 10 13:48:46 2002 @@ -1,6 +1,6 @@ #! perl -w -use Parrot::Test tests => 3; +use Parrot::Test tests => 4; output_is(<<'CODE', <<'OUTPUT', "time_i"); timeI0 @@ -64,4 +64,10 @@ start done O

RE: cvs commit: parrot/lib/Parrot Assembler.pm

2002-03-10 Thread Brent Dax
Melvin Smith: # At 02:02 PM 3/10/2002 -0800, Brent Dax wrote: # >[EMAIL PROTECTED]: # ># cvsuser 02/03/10 13:15:50 # ># # ># Modified:lib/Parrot Assembler.pm # ># Log: # ># Minor patch to the assembler for the new_p_ic_ic opcode to # ># work same as new_p_ic (looks up a named class

RE: cvs commit: parrot/lib/Parrot Assembler.pm

2002-03-10 Thread Melvin Smith
At 02:02 PM 3/10/2002 -0800, Brent Dax wrote: >[EMAIL PROTECTED]: ># cvsuser 02/03/10 13:15:50 ># ># Modified:lib/Parrot Assembler.pm ># Log: ># Minor patch to the assembler for the new_p_ic_ic opcode to ># work same as new_p_ic (looks up a named class). >Did Dan, Simon, or someone

[APPLIED] Re: [PATCH] More regex tests

2002-03-10 Thread Nicholas Clark
On Sun, Mar 10, 2002 at 01:40:09PM -0500, Simon Glover wrote: > > Enclosed patch fixes up a few more holes in our test coverage. Thanks, applied Nicholas Clark -- Even better than the real thing:http://nms-cgi.sourceforge.net/

RE: cvs commit: parrot/lib/Parrot Assembler.pm

2002-03-10 Thread Brent Dax
[EMAIL PROTECTED]: # cvsuser 02/03/10 13:15:50 # # Modified:lib/Parrot Assembler.pm # Log: # Minor patch to the assembler for the new_p_ic_ic opcode to # work same as new_p_ic (looks up a named class). # # Also added small hack for .sub directive (which simply translates # to a

[PATCH] More regex tests

2002-03-10 Thread Simon Glover
Enclosed patch fixes up a few more holes in our test coverage. Simon --- t/op/rx.t.old Sun Mar 10 13:14:34 2002 +++ t/op/rx.t Sun Mar 10 13:36:01 2002 @@ -1,4 +1,4 @@ -use Parrot::Test tests => 22; +use Parrot::Test tests => 27; use Test::More; sub gentest($$;$$) { @@ -64,

[PATCH] Tiny de-typo in rx.ops documentation

2002-03-10 Thread Simon Glover
Should be self-explanatory. Simon --- rx.ops.old Sun Mar 10 12:54:51 2002 +++ rx.ops Sun Mar 10 12:55:18 2002 @@ -16,7 +16,7 @@ # NOTE: This looks a LOT scarier than it really is # "zzabbBBcdcdcdzz" =~ /ab*[cd]+/i - rx_allocateinfo P0, "zzabbBBcdcd

RE: Parrot runtime footprint -- looking kind of big for embedded use...

2002-03-10 Thread Brent Dax
Simon Cozens: # Burl Nyswonger: # > The ability to build the VM in an extremely stripped-down # configuration # > would be really useful for embedded environments (where you # only have, say # > a 4MB flash that must hold a kernel, all libs, apps, etc...). # # By the time Parrot's ready to be

Re: Parrot runtime footprint -- looking kind of big for embedded use...

2002-03-10 Thread Simon Cozens
Burl Nyswonger: > The ability to build the VM in an extremely stripped-down configuration > would be really useful for embedded environments (where you only have, say > a 4MB flash that must hold a kernel, all libs, apps, etc...). By the time Parrot's ready to be embedded, memory prices will hav