Re: [perl #53352] Build warnings in STRUCT_COPY

2008-04-26 Thread NotFound
Hello > The following lines that use the STRUCT_COPY macro are generating > build warnings. > > src/charset/ascii.c:792: warning: the address of 'base_set' will > always evaluate as 'true' (snip) > For example, the last line here is: > > STRUCT_COPY(return_encoding, &base_encoding); > > but

[perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-26 Thread James Keenan via RT
Please review revised patch attached. Geoff, does this work for you? Jerry, okay on Win32? (All tests passing on Darwin and Linux.) Index: lib/Parrot/Configure/Step/Methods.pm === --- lib/Parrot/Configure/Step/Methods.pm(rev

Re: [perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-26 Thread Geoffrey Broadwell
On Sat, 2008-04-26 at 09:25 -0700, James Keenan via RT wrote: > Please review revised patch attached. Geoff, does this work for you? > Jerry, okay on Win32? Generally, yes. One tiny nit: > +=item * C > + > +Libraries to be added where no OS-specific or OS/C-compiler-specific > libraries > +are

[perl #53270] [TODO] Rename/refactor _handle_mswin32()

2008-04-26 Thread James Keenan via RT
On Sat Apr 26 09:37:06 2008, geoff wrote: > On Sat, 2008-04-26 at 09:25 -0700, James Keenan via RT wrote: > > +are to be added. Wordspace-delimited string. > > Did you mean "Whitespace-delimited"? No, because I don't want people adding tabs here. But would 'single whitespace' be more clear?

Re: [perl #53352] Build warnings in STRUCT_COPY

2008-04-26 Thread chromatic
On Saturday 26 April 2008 09:03:12 NotFound wrote: > I'v taken a look a those warnings some days ago. The macro STRUCT_COPY > is generic and asserts his two parameter as non null, but is used in > several places with arguments that the compiler knows is not, making > the assertion redundant. But d

Re: [perl #53356] Misc. build warnings

2008-04-26 Thread chromatic
On Friday 25 April 2008 10:50:24 Will Coleda wrote: > Miscellaneous build warnings that need to be cleaned up. > > src/key.c:306: warning: switch missing default case Fixed in 27195. > compilers/imcc/imclexer.c:4288: warning: switch missing default case > compilers/imcc/imclexer.c:4447: warning:

[perl #53390] [BUG] t/op/sysinfo.t reports INTVAL size mismatch on linux/amd64

2008-04-26 Thread via RT
# New Ticket Created by Mark Glines # Please include the string: [perl #53390] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=53390 > r27167 added a test (from RT #53362) for the "sysinfo" op. And now that it's being teste

Re: [perl #53390] [BUG] t/op/sysinfo.t reports INTVAL size mismatch on linux/amd64

2008-04-26 Thread Mark Glines
On Sat, 26 Apr 2008 11:40:43 -0700 Mark Glines (via RT) <[EMAIL PROTECTED]> wrote: > # at t/op/sysinfo.t line 53. > # got: '8' > # expected: '4' Found it. The test was checking the op's report of sizeof(INTVAL) against $PConfig{intsize}, but INTVAL isn't necessarily defined to "in

Re: [perl #53356] Misc. build warnings

2008-04-26 Thread Klaas-Jan Stol
On Sat, Apr 26, 2008 at 7:39 PM, chromatic <[EMAIL PROTECTED]> wrote: > On Friday 25 April 2008 10:50:24 Will Coleda wrote: > > > Miscellaneous build warnings that need to be cleaned up. > > > > src/key.c:306: warning: switch missing default case > > Fixed in 27195. > > > > compilers/imcc/imcl

[perl #39760] [CAGE] make warnings (r13197 - x86-msvc-7.1)

2008-04-26 Thread Will Coleda via RT
On Fri Jul 07 09:05:57 2006, particle wrote: > compilers\imcc\imcparser.c > imcparser.c > compilers\imcc\imcparser.c(878) : warning C4273: 'malloc' : > inconsistent dll linkage > compilers\imcc\imcparser.c(885) : warning C4273: 'free' : inconsistent > dll linkage > > compilers\ast\astparser.c > as