[perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2008-08-01 Thread Will Coleda via RT
ismatched strings are going to be an issue whether they're in a > >> CONST_STRING declaration or just an assignment to char *. > >> > >> So, no, it's not worth fixing up c2str.pl, IMO. > > > > So if it's not worth fixing c2str.pl, can this tick

[perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2008-07-25 Thread Christoph Otto via RT
On Thu Jun 05 19:07:49 2008, coke wrote: > We can always improve the diagnostic emitted by the PMC compiler. > Mismatched strings are going to be an issue whether they're in a > CONST_STRING declaration or just an assignment to char *. > > So, no, it's not worth fixing

Re: [perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2008-07-25 Thread Will Coleda
gt;> CONST_STRING declaration or just an assignment to char *. >> >> So, no, it's not worth fixing up c2str.pl, IMO. > > So if it's not worth fixing c2str.pl, can this ticket be rejected? > SFAIK, no patch has yet been applied. We still need to pick one (mine!) and ap

Re: [perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2008-06-05 Thread Will Coleda
On Thu, Jun 5, 2008 at 9:28 PM, chromatic <[EMAIL PROTECTED]> wrote: > On Thursday 05 June 2008 18:19:21 Will Coleda via RT wrote: > >> I have a counter-patch: >> >> Index: tools/build/c2str.pl >> ===== >&

Re: [perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2008-06-05 Thread chromatic
On Thursday 05 June 2008 18:19:21 Will Coleda via RT wrote: > I have a counter-patch: > > Index: tools/build/c2str.pl > = > == > --- tools/build/c2str.pl(revision 28124) > +++ tools/build/c2str.pl

[perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2008-06-05 Thread Will Coleda via RT
On Wed Jan 02 11:19:02 2008, szbalint wrote: > On Thu Oct 25 08:45:09 2007, ptc wrote: > > In tools/build/c2str.pl there is the todo item: > > > > # TODO maybe cope with escaped \" > > > > Do this. > > I've attached a patch that should com

[perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2007-11-05 Thread James Keenan via RT
On Thu Nov 01 23:50:36 2007, magnachef wrote: > I have, IMO, finished this TODO. I am not sure who is responsible for > commiting this to the repository. > > I have included the diff below: > > [EMAIL PROTECTED] build]$ diff -U0 c2str.pl c2str.pl.escaped > --- c2str.p

[perl #46909] [TODO] [Perl] Cope with escaped quotes in tools/build/c2str.pl

2007-10-25 Thread via RT
# New Ticket Created by Paul Cochrane # Please include the string: [perl #46909] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=46909 > In tools/build/c2str.pl there is the todo item: # TODO maybe cope with esca

Re: [perl #31229] [PATCH] Missed pod nit in build_tools/c2str.pl

2004-08-20 Thread Dan Sugalski
At 4:16 PM -0700 8/18/04, Will Coleda (via RT) wrote: # New Ticket Created by Will Coleda # Please include the string: [perl #31229] # in the subject line of all future correspondence about this issue. # http://rt.perl.org:80/rt3/Ticket/Display.html?id=31229 > Index: build_tools/c2str.pl Appl

[perl #31229] [PATCH] Missed pod nit in build_tools/c2str.pl

2004-08-18 Thread via RT
# New Ticket Created by Will Coleda # Please include the string: [perl #31229] # in the subject line of all future correspondence about this issue. # http://rt.perl.org:80/rt3/Ticket/Display.html?id=31229 > Index: build_tools/c2str

A note WRT c2str.pl

2004-04-19 Thread Leopold Toetsch
I've now changed interpreter.c to use CONST_STRING() too. It's basically working but there is a problem: The macros use the current line number for identifying a string. When the line is: f (some, CONST_STRING("foo"), some_more); then c2str.pl and the C compiler

Re: c2str.pl

2004-04-19 Thread Leopold Toetsch
Jarkko Hietaniemi <[EMAIL PROTECTED]> wrote: > FWIW, the usually picky Tru64 compiler is happy with the code generated > with the newest c2str.pl. > P.S. Why is the /*const*/ commented out? I would think it would be a > good idea. Isn't used anymore (it produced warning

Re: c2str.pl

2004-04-19 Thread Jarkko Hietaniemi
FWIW, the usually picky Tru64 compiler is happy with the code generated with the newest c2str.pl. P.S. Why is the /*const*/ commented out? I would think it would be a good idea.

Re: c2str.pl

2004-04-17 Thread Leopold Toetsch
Leopold Toetsch <[EMAIL PROTECTED]> wrote: > - $ perl c2str.pl src/objects.c > src/objects.str > - enable #include "objects.str" near the top of the file > - $ make To make it compile cleanly with gcc 2.95.2 some of the consts need to go - or I'm to dumb to d

c2str.pl

2004-04-16 Thread Leopold Toetsch
Here is the updated version with hashvalue calculation. Please test it on different platforms: - $ perl c2str.pl src/objects.c > src/objects.str - enable #include "objects.str" near the top of the file - $ make see also "Constant strings - again" from yesterday.