Re: patch to is_cclass for offset beyond end of string

2005-05-12 Thread Jens Rieks
On Thursday 12 May 2005 04:58, Patrick R. Michaud wrote: > On Wed, May 11, 2005 at 09:49:47AM +0200, Jens Rieks wrote: > > On Wednesday 11 May 2005 04:30, Patrick R. Michaud wrote: > > > ...well, in looking at it some more it's reasonable until I see > > > that returning -1 is the way the other fin

Re: patch to is_cclass for offset beyond end of string

2005-05-11 Thread Patrick R. Michaud
On Tue, May 10, 2005 at 10:22:35PM +0200, Jens Rieks wrote: > On Tuesday 10 May 2005 20:29, Patrick R. Michaud wrote: > > This is *excellent*. > > > > However, now that I look at things, I'm wondering if a slight > > change to the specification would be in order -- in my original > > post I said th

Re: patch to is_cclass for offset beyond end of string

2005-05-11 Thread Leopold Toetsch
Jens Rieks wrote: IMO, we should deprecate the old find_* ops. It's a lot of (more or less) duplicate code, and not easy to maintain. Yep, as well as the old is_foo opcodes and interfaces. jens leo

Re: patch to is_cclass for offset beyond end of string

2005-05-11 Thread Jens Rieks
On Wednesday 11 May 2005 04:30, Patrick R. Michaud wrote: > ...well, in looking at it some more it's reasonable until I see > that returning -1 is the way the other find_* ops work. So, > part of me thinks we should either be consistent with those, or > make the others consistent with the interpre

Re: patch to is_cclass for offset beyond end of string

2005-05-10 Thread Patrick R. Michaud
On Tue, May 10, 2005 at 05:08:49PM +0200, Jens Rieks wrote: > On Monday 09 May 2005 07:53, Patrick R. Michaud wrote: > > The attached patch file adjusts C to always return false > > for offsets beyond the end of the string, and updates > > t/op/string_cclass.t to test this. > Thanks, applied! > >

Re: patch to is_cclass for offset beyond end of string

2005-05-10 Thread Jens Rieks
On Tuesday 10 May 2005 20:29, Patrick R. Michaud wrote: > On Tue, May 10, 2005 at 05:08:49PM +0200, Jens Rieks wrote: > > On Monday 09 May 2005 07:53, Patrick R. Michaud wrote: > > > The attached patch file adjusts C to always return false > > > for offsets beyond the end of the string, and updates

Re: patch to is_cclass for offset beyond end of string

2005-05-10 Thread Jens Rieks
On Monday 09 May 2005 07:53, Patrick R. Michaud wrote: > The attached patch file adjusts C to always return false > for offsets beyond the end of the string, and updates > t/op/string_cclass.t to test this. Thanks, applied! find_cclass and find_not_cclass are in now. jens

Re: patch to is_cclass for offset beyond end of string

2005-05-09 Thread Leopold Toetsch
Patrick R. Michaud wrote: On Sun, May 08, 2005 at 11:45:08PM +0200, Jens Rieks wrote: Hi, C is now implemented. The second part (find_(not_)cclass) will follow tomorrow. Wow, that's fast The attached patch file adjusts C to always return false for offsets beyond the end of the string, and updates