Re: is_deeply hangs

2005-04-24 Thread Michael G Schwern
On Sun, Jan 23, 2005 at 08:22:37PM +, Fergal Daly wrote: > Attached is a patch that fixes this test case without breaking any others so > I think it's OK. It basically centralises the circular ref checking into > _deep_check and then reroutes eq_array and eq_hash into that. This ensures > that

Re: is_deeply hangs

2005-03-03 Thread Michael G Schwern
On Sun, Jan 23, 2005 at 09:22:19AM -0800, Ovid wrote: > This program hangs when it hits is_deeply. I eventually get an "out of > memory" error. I don't think I saw a followup from you on this. Did you try it with the latest version of Test::More?

Re: is_deeply hangs

2005-01-23 Thread Fergal Daly
Final reply to myself :-). Attached is a patch that fixes this test case without breaking any others so I think it's OK. It basically centralises the circular ref checking into _deep_check and then reroutes eq_array and eq_hash into that. This ensures that all types of refs are checked for cirular

Re: is_deeply hangs

2005-01-23 Thread Fergal Daly
Oops, actually the latest is_deeply doesn't correctly handle _all_ circular structures. If the circle includes a hash or an array it will work but if it only includes scalar references then it will recurse indefinitely. I've filed a bug report on rt. Test case below use strict; use warnings; use

Re: is_deeply hangs

2005-01-23 Thread Stevan Little
Ovid, If you want/need to test for circular data structures, Test::Memory::Cycle does a nice job. It's bascially just a wrapper around Devel::Cycle. And if you need to test weakened ones, I am wrote a patch for both Devel::Cycle and Test::Memory::Cycle to be able to check them as well. We are w

Re: is_deeply hangs

2005-01-23 Thread Fergal Daly
What version of Test::More? Only the most recent versions can handle circular data structures, so I'd guess you have a circular data structure and an older version, Fergal On Sun, Jan 23, 2005 at 09:22:19AM -0800, Ovid wrote: > (Aargh! This time I'll send this from the correct email address.) >