Re: Proposed kwalitee metric: consistent_newlines

2006-05-03 Thread Adam Kennedy
It does work very well though and I prefer it to fighting with the MakeMaker docs to figure out how to get it to install a data file in the right place :-) Perl has language-level support for uuencoding/-decoding data (check `perldoc -f pack`). You can take advantage of that to keep your binary

Re: Proposed kwalitee metric: consistent_newlines

2006-05-03 Thread Adam Kennedy
Paul Johnson wrote: On Wed, May 03, 2006 at 11:36:53AM +0200, A. Pagaltzis wrote: Am I missing something, or won’t all of these will cause problems with Module::Signature? The thing is that it doesn’t matter how perl sees the file; what matters is how Module::Signature sees the file, and to my

Re: Proposed kwalitee metric: consistent_newlines

2006-05-03 Thread David Cantrell
A. Pagaltzis wrote: * David Cantrell <[EMAIL PROTECTED]> [2006-05-03 11:00]: It does work very well though and I prefer it to fighting with the MakeMaker docs to figure out how to get it to install a data file in the right place :-) Perl has language-level support for uuencoding/-decoding data

Re: Proposed kwalitee metric: consistent_newlines

2006-05-03 Thread Paul Johnson
On Wed, May 03, 2006 at 11:36:53AM +0200, A. Pagaltzis wrote: > Am I missing something, or won’t all of these will cause problems > with Module::Signature? The thing is that it doesn’t matter how > perl sees the file; what matters is how Module::Signature sees > the file, and to my knowledge, the

Re: Proposed kwalitee metric: consistent_newlines

2006-05-03 Thread A. Pagaltzis
* David Cantrell <[EMAIL PROTECTED]> [2006-05-03 11:00]: > A. Pagaltzis wrote: > >Why would this have to rely on PPI at all? To check whether > >newlines in the file are consistent, you can just scan the > >source as an opaque of text, no? > > A perl source file might have an embedded heredoc, or

Re: Proposed kwalitee metric: consistent_newlines

2006-05-03 Thread David Cantrell
A. Pagaltzis wrote: * Adam Kennedy <[EMAIL PROTECTED]> [2006-04-30 07:00]: The Perl::Critic thing could be tricky though. One of the very few things PPI does that isn't round-trip safe (actually, the ONLY thing) is localise the newlines for the files it opens. Why would this have to rely on PPI

Re: Proposed kwalitee metric: consistent_newlines

2006-04-30 Thread A. Pagaltzis
* Adam Kennedy <[EMAIL PROTECTED]> [2006-04-30 07:00]: > The Perl::Critic thing could be tricky though. > > One of the very few things PPI does that isn't round-trip safe > (actually, the ONLY thing) is localise the newlines for the > files it opens. Why would this have to rely on PPI at all? To

Re: Proposed kwalitee metric: consistent_newlines

2006-04-30 Thread A. Pagaltzis
* Ovid <[EMAIL PROTECTED]> [2006-04-30 07:20]: > Sounds like a good idea, but what about strings? You'd need to > mask those out prior to the test, wouldn't you? I don’t think so. Even if the only “funny” newline only appears in a string (and even it seems to me more likely that this would happe

Re: Proposed kwalitee metric: consistent_newlines

2006-04-30 Thread Adam Kennedy
Ovid wrote: --- Adam Kennedy <[EMAIL PROTECTED]> wrote: So I'd like to propose the following for inclusion. Metric: consistent_newlines The distribution is awarded a point IF for ALL text files within the distribution EACH file contains EITHER exclusively unix newlines OR exclusively Win32 n

Re: Proposed kwalitee metric: consistent_newlines

2006-04-29 Thread Ovid
--- Adam Kennedy <[EMAIL PROTECTED]> wrote: > So I'd like to propose the following for inclusion. > > Metric: consistent_newlines > > The distribution is awarded a point IF for ALL text files within the > distribution EACH file contains EITHER exclusively unix newlines OR > exclusively Win32 ne

Re: Proposed kwalitee metric: consistent_newlines

2006-04-29 Thread Adam Kennedy
The Perl::Critic thing could be tricky though. One of the very few things PPI does that isn't round-trip safe (actually, the ONLY thing) is localise the newlines for the files it opens. And given that I live on a hybrid Win32/linux setup, PPI is also one of the very few things that is actuall

Re: Proposed kwalitee metric: consistent_newlines

2006-04-29 Thread Jeffrey Thalhammer
> So I'd like to propose the following for inclusion. > > Metric: consistent_newlines > > The distribution is awarded a point IF for ALL text > files within the distribution EACH file contains > EITHER exclusively unix newlines OR exclusively > Win32 newlines. In addition, I'd be happy to cook