Re: Branch Review

2005-09-27 Thread Leopold Toetsch
Chip Salzenberg wrote: Chip writes: * optional parameter interface: ":opt_count" -> ":opt_flag" So ":opt_count" should be replaced with ":opt_flag", which sets its target register to a boolean indicating whether the immediately preceding parameter was passed or not, rather than

Re: Branch Review

2005-09-26 Thread Leopold Toetsch
Chip Salzenberg wrote: On Fri, Sep 09, 2005 at 01:48:20PM +0200, Leopold Toetsch wrote: [ opt_count --> :opt_flag ] If there is an alternating sequence of (:optional, :opt_count)+, the :opt_count works exactly like :opt_flag, i.e. you get 0 or 1 depending on the presence of the preceeding op

Re: Branch Review

2005-09-25 Thread Chip Salzenberg
This is pretty long as is, so I'm going to leave out all the things I agree with. On Fri, Sep 09, 2005 at 01:48:20PM +0200, Leopold Toetsch wrote: > Chip writes: > > * optional parameter interface: ":opt_count" -> ":opt_flag" > > So ":opt_count" should be replaced with ":opt_flag", which set

Re: Branch Review

2005-09-09 Thread Leopold Toetsch
Chip Salzenberg <[EMAIL PROTECTED]> wrote: [ sorry for the delayed answer ] > I've looked over over the diffs between trunk and leo-ctx5, and here > are my notes. >{{ OVERALL }} > A significant improvement. Good work, y'all. Thanks. >{{ USER-VISIBLE }} > * optional parameter interface: ":op