Re: Adding more kwalitee tests

2005-09-06 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, here is another idea for a metric: Modules/pragmas/etc use'd by Heap cnt in code: AutoLoader 1 Heap does use AutoLoader, but it never defined any methods to autoload, so this is totally in vain. (I did write a new version of Heap, offered i

Re: Adding more kwalitee tests

2005-09-06 Thread Dave Rolsky
On Mon, 5 Sep 2005, Thomas Klausner wrote: has_perl_dependency: In the META.yml (assuming it exists) there is a dependency on the version of perl required to install the dist. The goal of this is to make life a little easier on installers and CPAN testers and a few other things. Many many mod

Re: Adding more kwalitee tests

2005-09-06 Thread David Golden
Adam Kennedy wrote: missing_no_index: Only the libraries (and .pod docs) in your dist should be indexed) things in inc/ and t/ and examples/ etc should NOT be indexed. Thus, there should be a no_index entry in the meta.yml for all of these directories (if they have .pm files in them). I like i

Re: Adding more kwalitee tests

2005-09-06 Thread David Golden
Ivan Tubert-Brohman wrote: Sorry for my ignorance, but I had never even heard of this option. I don't find any way of setting it via MakeMaker or Module::Build. Do I have to edit META.yml by hand? Would it get overritten by 'make dist'? The spec is here: http://module-build.sourceforge.net/ME

Re: Adding more kwalitee tests

2005-09-06 Thread Adam Kennedy
Apart from a user wanting to know which version of perl a module works with, it's a general "quality" (not kwalitee;-) principle to first specify, then test that the specification is met. So I would say that specifying which versions of perl your module is meant to work with should be done before

Re: Adding more kwalitee tests

2005-09-05 Thread Andrew Savige
--- Thomas Klausner wrote: > --- Adam Kennedy wrote: >> has_perl_dependency: >> >> In the META.yml (assuming it exists) there is a dependency on the >> version of perl required to install the dist. >> >> The goal of this is to make life a little easier on installers and CPAN >> testers and a fe

Re: Adding more kwalitee tests

2005-09-05 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin, On Monday 05 September 2005 17:53, Adam Kennedy wrote: > Sébastien Aperghis-Tramoni wrote: > >>Adam Kennedy wrote: > >>>has_perl_dependency: > >>> > >>>In the META.yml (assuming it exists) there is a dependency on the > >>>version of perl required to insta

Re: Adding more kwalitee tests

2005-09-05 Thread Tels
-BEGIN PGP SIGNED MESSAGE- Moin Klaus, On Monday 05 September 2005 14:51, Thomas Klausner wrote: > Hi! > > On Mon, Sep 05, 2005 at 03:43:02PM +1000, Adam Kennedy wrote: > > I know the whole kwalitee thing sort of stalled out at 17 tests, but > > what would be involved in adding some more?

Re: Adding more kwalitee tests

2005-09-05 Thread Adam Kennedy
The first demo of this I'm hoping to do is a use of Perl::MinimumVersion to find cases where a module is listed as working with (for example) Perl 5.005, but the module syntax shows that it needs 5.006. (and thus the version dependency is wrong). I later plan to expand this to include cases w

Re: Adding more kwalitee tests

2005-09-05 Thread Adam Kennedy
Well personally I use Module::Install (where no_index is also mostly undocumented too, but exists). It's what all the Cool Kids(tm) use these days. For example here's my Makefile.PL for Class::Autouse. - use inc::Module::Install;

Re: Adding more kwalitee tests

2005-09-05 Thread Adam Kennedy
Sébastien Aperghis-Tramoni wrote: Adam Kennedy wrote: has_perl_dependency: In the META.yml (assuming it exists) there is a dependency on the version of perl required to install the dist. Problem is that the version said to be required is often bogus. For example, the distributions created

Re: Adding more kwalitee tests

2005-09-05 Thread Sébastien Aperghis-Tramoni
> Adam Kennedy wrote: > > > has_perl_dependency: > > > > In the META.yml (assuming it exists) there is a dependency on the > > version of perl required to install the dist. Problem is that the version said to be required is often bogus. For example, the distributions created with h2xs since Perl

Re: Adding more kwalitee tests

2005-09-05 Thread Thomas Klausner
Hi! On Mon, Sep 05, 2005 at 03:43:02PM +1000, Adam Kennedy wrote: > I know the whole kwalitee thing sort of stalled out at 17 tests, but > what would be involved in adding some more? There's obviously been > enough interest from people trying to boost their You might be aware that I did a talk

Re: Adding more kwalitee tests

2005-09-05 Thread Ivan Tubert-Brohman
Adam Kennedy wrote: Only the libraries (and .pod docs) in your dist should be indexed) things in inc/ and t/ and examples/ etc should NOT be indexed. Thus, there should be a no_index entry in the meta.yml for all of these directories (if they have .pm files in them). Sorry for my ignorance, bu