Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-20 Thread chromatic
On Saturday 17 February 2007 08:27, jerry gay wrote: > as noted in my svn log at time of checkin, this is a failing test > which exposes a bug in Parrot::Distribution. '*.t' files are only perl > files if the shebang says they are, but Parrot::Distribution is > classifying all '*.t' files as perl

Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-18 Thread James E Keenan
jerry gay wrote: On 2/17/07, via RT James Keenan <[EMAIL PROTECTED]> wrote: The file which is failing the test is a Parrot source file (which happens to be a Parrot test file) -- not a Perl source file (which happens to be a Perl test file). So the test at line 75 is correctly formatted. part

Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-17 Thread jerry gay
On 2/17/07, Paul Cochrane <[EMAIL PROTECTED]> wrote: > 2. Parrot::Distribution contains a subroutine called is_perl() which > presumably tests whether a file in @perl_language_files actually *is* a > Perl file. > > However, I cannot locate any location where is_perl() is called. It used to be c

Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-17 Thread jerry gay
On 2/17/07, James E Keenan <[EMAIL PROTECTED]> wrote: jerry gay wrote: > On 2/17/07, via RT James Keenan <[EMAIL PROTECTED]> wrote: > >> The file which is failing the test is a Parrot source file (which >> happens to be a Parrot test file) -- not a Perl source file (which >> happens to be a Perl

Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-17 Thread James E Keenan
Two points in follow-up: 1. This bug has been difficult to diagnose because Parrot::Distribution -- which is what it is ultimately testing -- names some variables in ways that, IMHO, are misleading. Take, for example, this subroutine: sub get_perl_language_files { my $self = shift;

Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-17 Thread Paul Cochrane
2. Parrot::Distribution contains a subroutine called is_perl() which presumably tests whether a file in @perl_language_files actually *is* a Perl file. However, I cannot locate any location where is_perl() is called. It used to be called deep in the bowels of Parrot::Distribution before partic

Re: [perl #41529] [BUG]: t/perl/Parrot_Distribution.t test failure

2007-02-17 Thread jerry gay
On 2/17/07, via RT James Keenan <[EMAIL PROTECTED]> wrote: The file which is failing the test is a Parrot source file (which happens to be a Parrot test file) -- not a Perl source file (which happens to be a Perl test file). So the test at line 75 is correctly formatted. particle: You recently