Re: Problems with new object ops

2003-07-18 Thread Dan Sugalski
At 1:34 PM -0400 7/18/03, Simon Glover wrote: Of course this still doesn't work, because we never actually add anything to the class_hash. Patch below fixes this, as well as various bugs in Parrot_single_subclass, and adds a couple of regression tests. Thanks Simon. Applied. --

Re: Problems with new object ops

2003-07-18 Thread Simon Glover
Of course, if you apply the previous patch, you'll also need to apply this one... Simon --- MANIFEST.oldFri Jul 18 13:35:04 2003 +++ MANIFESTFri Jul 18 13:35:41 2003 @@ -1861,6 +1861,7 @@ t/pmc/managedstruct.t [] t/pmc/multiarray.t

Re: Problems with new object ops

2003-07-18 Thread Simon Glover
On Thu, 17 Jul 2003, Dan Sugalski wrote: > At 9:24 AM +0200 7/17/03, Leopold Toetsch wrote: > >Simon Glover <[EMAIL PROTECTED]> wrote: > > > > > For instance, in findclass, you have: > > > >>if (VTABLE_get_pmc_keyed(interpreter, interpreter->class_hash, > >>

Re: Problems with new object ops

2003-07-17 Thread Dan Sugalski
At 9:24 AM +0200 7/17/03, Leopold Toetsch wrote: Simon Glover <[EMAIL PROTECTED]> wrote: Dan, Firstly, when your doing the initialization for a new ParrotClass PMC, you create an Array to hold various other PMCs, but you don't size the array; this means that when you later try to put thin

Re: Problems with new object ops

2003-07-17 Thread Leopold Toetsch
Simon Glover <[EMAIL PROTECTED]> wrote: > Dan, > Firstly, when your doing the initialization for a new ParrotClass PMC, > you create an Array to hold various other PMCs, but you don't size the > array; this means that when you later try to put things in it in > Parrot_new_class, it dies with

Problems with new object ops

2003-07-16 Thread Simon Glover
Dan, I've been playing about with the new object stuff you added today, and I've noticed a couple of problems. Firstly, when your doing the initialization for a new ParrotClass PMC, you create an Array to hold various other PMCs, but you don't size the array; this means that when you later