Patch: Common opcode_table parsing, take 2

2001-09-13 Thread Damien Neil
Here's an updated version of my original patch, to account for recent changes in CVS. As before, this includes opcode-munging to let Parrot run on FreeBSD. - Damien diff -u --new-file -r parrot.orig/Parrot/Opcode.pm parrot/Parrot/Opcode.pm --- parrot.orig/Parrot/Opcod

Re: Patch: Common opcode_table parsing

2001-09-13 Thread Dan Sugalski
At 08:44 AM 9/13/2001 +0100, Simon Cozens wrote: >On Thu, Sep 13, 2001 at 12:47:06AM -0700, Damien Neil wrote: > > I *really* think we need to munge the names, though. "end" is just > > far too common a symbol for us to be able to pollute it. Let's > > learn the lesson from Perl 5: All symbols e

Re: Patch: Common opcode_table parsing

2001-09-13 Thread Damien Neil
On Thu, Sep 13, 2001 at 08:44:44AM +0100, Simon Cozens wrote: > Aiiee. Yes, I appreciate what you're saying, but the other lessons > from Perl 5 is that if you want to do that, you end up with either > lots of unweildy code, or a nasty macro renaming. Which is it > gonna be? I don't really like t

Re: Patch: Common opcode_table parsing

2001-09-13 Thread Simon Cozens
On Thu, Sep 13, 2001 at 12:47:06AM -0700, Damien Neil wrote: > I *really* think we need to munge the names, though. "end" is just > far too common a symbol for us to be able to pollute it. Let's > learn the lesson from Perl 5: All symbols exported by the Parrot > code need a prefix. Aiiee. Yes,

Re: Patch: Common opcode_table parsing

2001-09-13 Thread Damien Neil
On Thu, Sep 13, 2001 at 08:25:46AM +0100, Simon Cozens wrote: > On Thu, Sep 13, 2001 at 12:29:18AM -0700, Damien Neil wrote: > > CVS changes over the past couple of days mean this patch will no > > longer cleanly apply. I'd be happy to update it to patch cleanly > > against the current CVS code,

Re: Patch: Common opcode_table parsing

2001-09-13 Thread Simon Cozens
On Thu, Sep 13, 2001 at 12:29:18AM -0700, Damien Neil wrote: > CVS changes over the past couple of days mean this patch will no > longer cleanly apply. I'd be happy to update it to patch cleanly > against the current CVS code, but I'd like to know first if the > approach it takes is on the right

Re: Patch: Common opcode_table parsing

2001-09-12 Thread Damien Neil
On Tue, Sep 11, 2001 at 12:06:52AM -0700, Damien Neil wrote: > The following patch moves all parsing of opcode_table into a > Parrot::Opcode module. It also removes all parsing of interp_guts.h. > This patch incorporates my earlier patches to prefix all C opcode > functions with "Perl_op_". CVS

Patch: Common opcode_table parsing

2001-09-10 Thread Damien Neil
The following patch moves all parsing of opcode_table into a Parrot::Opcode module. It also removes all parsing of interp_guts.h. This patch incorporates my earlier patches to prefix all C opcode functions with "Perl_op_". As best I can tell, everything works the same with the patch as it did be