Re: P6opaque ends up serialising uninitialised memory

2014-01-28 Thread Nicholas Clark
On Mon, Jan 27, 2014 at 09:43:49PM +, Nicholas Clark wrote: > With this, core setting just produces 1 error from valgrind: > I'm not sure how to find that one. Writing everything plausible to /dev/null helped a lot, as it caused valgrind to produce an earlier backtrace: diff --cc src/mast/c

Re: P6opaque ends up serialising uninitialised memory

2014-01-27 Thread Nicholas Clark
On Mon, Jan 27, 2014 at 09:43:49PM +, Nicholas Clark wrote: > I don't think that there are that many places where this happens (but I > haven't rigged the build to count them yet), so I don't think that it's > worth adding to the C structures to remember how many slots are used, and > updating

P6opaque ends up serialising uninitialised memory

2014-01-27 Thread Nicholas Clark
P6opaque can end up up serialising uninitialised memory. P6opaque's compose() needs to zero the freshly allocated repr_data->unbox_slots. Not all the slots are used, but serialize_repr_data() will serialise all of them, and hence write out garbage to disk. This doesn't cause crashes, because the