Re: Missing write barriers for MVM_string_find_encoding()

2013-12-30 Thread jonathan
Nicholas Clark wrote .. > I believe that MVM_file_set_encoding() needs to root oshandle (patch attached) > as MVM_string_find_encoding() can allocate and hence can cause a GC run. > Patch applied; thanks. > There are two other uses of MVM_string_find_encoding(). One is: > > /* At least find

Missing write barriers for MVM_string_find_encoding()

2013-12-28 Thread Nicholas Clark
I believe that MVM_file_set_encoding() needs to root oshandle (patch attached) as MVM_string_find_encoding() can allocate and hence can cause a GC run. There are two other uses of MVM_string_find_encoding(). One is: /* At least find_encoding may allocate on first call, so root just * in