Re: Kwalitee and Perl::Critic

2005-10-05 Thread Chris Dolan
On Oct 5, 2005, at 6:18 AM, A. Pagaltzis wrote: * what's the ratio of globals to subroutines? (smaller is better) Does that include file-scoped lexicals? ’Cause in that case I disagree – I’m just overhauling a module, in which process I’m also moving it to inside-out object style, and so I’v

Re: Kwalitee and Perl::Critic

2005-10-05 Thread A. Pagaltzis
* Chris Dolan <[EMAIL PROTECTED]> [2005-10-05 12:20]: > Things that PPI/Perl::Critic could judge that might lead to > quantitative, non-controversial metrics: Pretty good suggests, but I think the following may have to be lessened: > * what's the ratio of globals to subroutines? (smaller is bett

Re: Kwalitee and Perl::Critic

2005-10-05 Thread Adam Kennedy
Unless someone wants to start helping implement this right now, I'd ask that you not spend too much time on anything that relates to Kwalitee/PPI integration (which includes Perl::Critic). There's a couple of steps that have to be taken in order to make this happen, and I'm working through the

Re: Kwalitee and Perl::Critic

2005-10-05 Thread Chris Dolan
On Oct 4, 2005, at 1:04 PM, Nik Clayton wrote: I don't have strong opinions about this yet, but has anyone else looked at the Perl::Critic suite of modules on CPAN? It occurs to me that: a) Kwalitee metrics could quite easily be implemented as Perl::Critic plugins. b) The plugins that it

Kwalitee and Perl::Critic

2005-10-04 Thread Nik Clayton
I don't have strong opinions about this yet, but has anyone else looked at the Perl::Critic suite of modules on CPAN? It occurs to me that: a) Kwalitee metrics could quite easily be implemented as Perl::Critic plugins. b) The plugins that it ships with (based on Perl Best Practices) may for