Re: Another correction to string patch

2001-12-31 Thread Dan Sugalski
At 10:32 PM 12/31/2001 +0200, Peter Gibbs wrote: >- Original Message - >From: "Dan Sugalski" <[EMAIL PROTECTED]> > > Yup. Destroyed strings just get their buffer pointers set to NULL. GC'll > > collect things up. Also means COW string buffers can share pointers to the > > same buffer. > >

Re: Another correction to string patch

2001-12-31 Thread Peter Gibbs
- Original Message - From: "Dan Sugalski" <[EMAIL PROTECTED]> > Yup. Destroyed strings just get their buffer pointers set to NULL. GC'll > collect things up. Also means COW string buffers can share pointers to the > same buffer. > Dan/David With regard to COW strings - would the buffer-r

Re: Another correction to string patch

2001-12-31 Thread Dan Sugalski
At 10:15 AM 12/31/2001 -1000, [EMAIL PROTECTED] wrote: > >You have also forgotten to free the second allocation. I see that you call > >My understanding is that string destroy will go away or become a noop with GC >(Dan is this correct?). So I intentionally did not mess with it. Yup. Destroyed s

Re: Another correction to string patch

2001-12-31 Thread jacobsl001
>You have also forgotten to free the second allocation. I see that you call My understanding is that string destroy will go away or become a noop with GC (Dan is this correct?). So I intentionally did not mess with it. David

Another correction to string patch

2001-12-31 Thread Peter Gibbs
David You have also forgotten to free the second allocation. I see that you call free_string(), which is in resources.c, but don't use the matching new_string_header() function in that file - are these not intended to be a matched pair for future GC purposes? I am assuming for now that both free(