Re: [svn:parrot] r20101 - in trunk: . tools/build

2007-07-23 Thread Andy Lester
On Jul 23, 2007, at 5:57 PM, Kevin Tew wrote: My thinking was that, should someone, someday change PANIC into a recoverable error, this will prevent leakage. Ok its a stretch. :) if it's unreachable, we need to get rid of it. PANIC is a dead-end. xoa -- Andy Lester => [EMAIL PROTECTED] =

Re: [svn:parrot] r20101 - in trunk: . tools/build

2007-07-23 Thread Andy Lester
On Jul 23, 2007, at 7:21 PM, chromatic wrote: I'm okay with that, but we should also decorate PANIC with PARROT_DOES_NOT_RETURN, which I believe *should* help compilers. I'm all over it, long ago. PANIC just wraps do_panic which is so decorated. -- Andy Lester => [EMAIL PROTECTED] => ww

Re: [svn:parrot] r20101 - in trunk: . tools/build

2007-07-23 Thread chromatic
On Monday 23 July 2007 17:57:29 Kevin Tew wrote: > Nope it isn't. > I debated the fix. > > Of course the return NULL isn't reachable either so we should remove it > too. But that will cause compiler warnings for not having a return value. > > My thinking was that, should someone, someday change PA

Re: [svn:parrot] r20101 - in trunk: . tools/build

2007-07-23 Thread Kevin Tew
Nope it isn't. I debated the fix. Of course the return NULL isn't reachable either so we should remove it too. But that will cause compiler warnings for not having a return value. My thinking was that, should someone, someday change PANIC into a recoverable error, this will prevent leakage. Ok

Re: [svn:parrot] r20101 - in trunk: . tools/build

2007-07-22 Thread chromatic
On Sunday 22 July 2007 08:39:17 [EMAIL PROTECTED] wrote: > Modified: >trunk/ (props changed) >trunk/tools/build/nativecall.pl > > Log: > [Coverity] parrot-0.4.13 CID:28 RESOURCE_LEAK - added > string_cstring_free(c) to free resouce > > > Modified: trunk/tools/build/nativecall.pl > ==