Re: [perl #34984] [PATCH] Fix segfault with const

2005-04-16 Thread Leopold Toetsch
Nick Glencross <[EMAIL PROTECTED]> wrote: > Leopold Toetsch via RT wrote: >> >>>I think, we could be a bit more graceful here for I/N mismatch and set >>>for the above case the constant val->set to 'N'. >>> >>> > Let me redo that... I've just sent the wrong attachment which had a > typo in it ..

Re: [perl #34984] [PATCH] Fix segfault with const

2005-04-16 Thread Nick Glencross
Nicholas Clark wrote: On Fri, Apr 15, 2005 at 07:26:56PM +0100, Nick Glencross wrote: +// Forbid assigning a string to anything other than a string const +// for now In future, please don't use C99 comments. (apart from that, I don't have the knowledge to comment on this patch) A

Re: [perl #34984] [PATCH] Fix segfault with const

2005-04-15 Thread Nicholas Clark
On Fri, Apr 15, 2005 at 07:26:56PM +0100, Nick Glencross wrote: > +// Forbid assigning a string to anything other than a string const > +// for now In future, please don't use C99 comments. (apart from that, I don't have the knowledge to comment on this patch) Nicholas Clark

Re: [perl #34984] [PATCH] Fix segfault with const

2005-04-15 Thread Nick Glencross
Leopold Toetsch via RT wrote: I think, we could be a bit more graceful here for I/N mismatch and set for the above case the constant val->set to 'N'. Let me redo that... I've just sent the wrong attachment which had a typo in it ... [This should really address rare but possible Unicode str

Re: [perl #34984] [PATCH] Fix segfault with const

2005-04-15 Thread Nick Glencross
Leopold Toetsch via RT wrote: Nick Glencross <[EMAIL PROTECTED]> wrote: This patch fixes a problem which can occur in this example: .sub test .const float a = 12 print a print_newline .end Ah yep. +if (t != 'P' && t != val->set) +IMCC_fataly(inter

Re: [perl #34984] [PATCH] Fix segfault with const

2005-04-15 Thread Leopold Toetsch
Nick Glencross <[EMAIL PROTECTED]> wrote: > This patch fixes a problem which can occur in this example: > .sub test > .const float a = 12 > print a > print_newline > .end Ah yep. > > +if (t != 'P' && t != val->set) > +IMCC_fataly(interp, E_TypeError, > +

[perl #34984] [PATCH] Fix segfault with const

2005-04-14 Thread via RT
# New Ticket Created by Nick Glencross # Please include the string: [perl #34984] # in the subject line of all future correspondence about this issue. # https://rt.perl.org/rt3/Ticket/Display.html?id=34984 > [I submitted this patch from a web mailer last night, but it seems to have disappear