Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Leopold Toetsch
Jeff Clites <[EMAIL PROTECTED]> wrote: > ab\x{212b}de //clength is 12 > --^ > ... end up with is 5 (2 + 1 + 2) Ok, ok. You are right. As the string goes into constants and isn't changed, we'll do it right, which is, as metioned, d + 1 + length_todo > [Note: _string_upscale is curren

Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Jeff Clites
On Apr 13, 2004, at 8:35 AM, Leopold Toetsch wrote: Jeff Clites <[EMAIL PROTECTED]> wrote: One other thing occurred to me, to save a few bytes: When upscaling, rather than passing clength, we can pass (result->strlen + number of bytes left in cstring). If I read that correctly, s->strlen (or clen

Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Leopold Toetsch
Jeff Clites <[EMAIL PROTECTED]> wrote: > One other thing occurred to me, to save a few bytes: When upscaling, > rather than passing clength, we can pass (result->strlen + number of > bytes left in cstring). If I read that correctly, s->strlen (or clength) is the desired length. - on creation a on

Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Jeff Clites
On Apr 13, 2004, at 7:18 AM, Leopold Toetsch wrote: Jeff Clites <[EMAIL PROTECTED]> wrote: 1) My version handles the case of code points > 0x as well. It's simple now to change that code to include this. I've not done it yet to keep this patch smaller, which includes #28473 too. My version i

Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Leopold Toetsch
Jeff Clites <[EMAIL PROTECTED]> wrote: > 1) My version handles the case of code points > 0x as well. It's simple now to change that code to include this. I've not done it yet to keep this patch smaller, which includes #28473 too. My version is just smaller, cleaner, and faster ;) So config s

Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Leopold Toetsch
Jeff Clites <[EMAIL PROTECTED]> wrote: > On Apr 12, 2004, at 9:54 AM, Leopold Toetsch (via RT) wrote: > It looks very similar to what I had come up with. The only important > differences are: > 1) My version handles the case of code points > 0x as well. (The > string_append_chr function enca

Re: [perl #28494] [PATCH] unescape strings

2004-04-13 Thread Jeff Clites
On Apr 12, 2004, at 9:54 AM, Leopold Toetsch (via RT) wrote: # New Ticket Created by Leopold Toetsch # Please include the string: [perl #28494] # in the subject line of all future correspondence about this issue. # http://rt.perl.org:80/rt3/Ticket/Display.html?id=28494 > Attached patch: * adds a

Re: [perl #28494] [PATCH] unescape strings

2004-04-12 Thread Jeff Clites
That's really funny--I wrote almost exactly the same code w.r.t. string_unescape_cstring last night, and I also always use U+212b for testing any time I need to come up with a readable character outside of the Latin range. Strange coincidences. I'll take a look and see if there is anything sign

[perl #28494] [PATCH] unescape strings

2004-04-12 Thread via RT
# New Ticket Created by Leopold Toetsch # Please include the string: [perl #28494] # in the subject line of all future correspondence about this issue. # http://rt.perl.org:80/rt3/Ticket/Display.html?id=28494 > Attached patch: * adds a new test file for Unicode-related string tests * reimplem