Re: [PATCH Test::Harness::Straps] Add Diagnostic Output to Straps Results

2005-01-26 Thread chromatic
On Wed, 2005-01-26 at 19:36 -0800, Ovid wrote: > Perhaps we have something else different on our systems, but when I'm > processing "extra" lines, $result{number} is false. Yeah, I see what I was thinking. Here's a patch that makes the Test::Harness tests all pass by default by adding a flag t

Re: [PATCH Test::Harness::Straps] Add Diagnostic Output to Straps Results

2005-01-26 Thread Ovid
--- chromatic <[EMAIL PROTECTED]> wrote: > On Wed, 2005-01-26 at 18:51 -0800, Ovid wrote: > Odd. I think the problem was in looking for undefined values; at > least, > I remember ending up with that while writing the patch and running > the > Test::Harness tests. Perhaps we have something else di

Re: [PATCH Test::Harness::Straps] Add Diagnostic Output to Straps Results

2005-01-26 Thread chromatic
On Wed, 2005-01-26 at 18:51 -0800, Ovid wrote: > This line: > > > +elsif ($result{number} and my $extra = $self->_is_extra_line( > > $line )) > > Always fails to collect the data I need because $result{number} is > false when the extra data is being accumulated. Thus, I changed it to: > >

Re: [PATCH Test::Harness::Straps] Add Diagnostic Output to Straps Results

2005-01-26 Thread Ovid
--- Ovid <[EMAIL PROTECTED]> wrote: > > +elsif ($result{number} and my $extra = $self->_is_extra_line( > > $line )) > > Always fails to collect the data I need because $result{number} is > false when the extra data is being accumulated. Thus, I changed it > to: > > elsif (!$result{number}

Re: [PATCH Test::Harness::Straps] Add Diagnostic Output to Straps Results

2005-01-26 Thread Ovid
--- chromatic <[EMAIL PROTECTED]> wrote: > (and displaying better diagnostics on success or failure), here's a > small patch to Test::Harness::Straps to collect the diagnostic > information currently dumped to STDERR and to store it in the test > data structure for Straps users to collect: OK, I h

[PATCH Test::Harness::Straps] Add Diagnostic Output to Straps Results

2005-01-26 Thread chromatic
Hi all, As threatened in comments on Ovid's journal about colorizing test output (and displaying better diagnostics on success or failure), here's a small patch to Test::Harness::Straps to collect the diagnostic information currently dumped to STDERR and to store it in the test data structure for