Re: [PATCH] format warning in key.c

2002-01-21 Thread Bryan C. Warnock
On Monday 21 January 2002 19:06, Dan Sugalski wrote: > Commits in areas you (the generic you, here) > have some responsibility for (Brent with the RE code, Jeff Goff for > PMC stuff, Melvin for IO, for example) can also go in if you're > comfortable with them. That should probably be amended wit

Re: [PATCH] format warning in key.c [APPLIED]

2002-01-21 Thread Dan Sugalski
At 11:10 PM + 1/21/02, Nicholas Clark wrote: >We do mandate an ANSI conformant C compiler, don't we? > >Appended patch cures these warnings: Oh, and applied. Thanks. -- Dan --"it's like this"--- Dan

Re: [PATCH] format warning in key.c

2002-01-21 Thread Dan Sugalski
At 3:56 PM -0800 1/21/02, Steve Fink wrote: >All of your last several patches look good to me. Didn't Dan give you >commit rights yet? I'm pretty sure he intended to. Dan was also going >to have a discussion of commit policy -- when should we just commit, >and when should we discuss first -- as so

Re: [PATCH] format warning in key.c

2002-01-21 Thread Dan Sugalski
At 11:10 PM + 1/21/02, Nicholas Clark wrote: >We do mandate an ANSI conformant C compiler, don't we? Yep. If we haven't given you commit rights, go over to dev.perl.org and get an account. Then mail me the account name and we'll fix that. -- Dan ---

Re: [PATCH] format warning in key.c

2002-01-21 Thread Steve Fink
All of your last several patches look good to me. Didn't Dan give you commit rights yet? I'm pretty sure he intended to. Dan was also going to have a discussion of commit policy -- when should we just commit, and when should we discuss first -- as soon as he gets more settled, but my vote would be

[PATCH] format warning in key.c

2002-01-21 Thread Nicholas Clark
We do mandate an ANSI conformant C compiler, don't we? Appended patch cures these warnings: key.c: In function `debug_key': key.c:29: warning: int format, INTVAL arg (arg 3) key.c:33: warning: int format, INTVAL arg (arg 3) key.c:33: warning: int format, INTVAL arg (arg 4) key.c:36: warning: int