Re: [perl #40371] [PATCH] as2c.pl C-file coda fix

2006-09-21 Thread Paul Cochrane
On 9/20/06, Jerry Gay via RT <[EMAIL PROTECTED]> wrote: thanks, applied as r14673, with a minor fix: -$print_coda(); +&print_coda(); Doh! Should have got that one right... Thanks for spotting it. :-) Paul

Re: [PATCH] as2c.pl C-file coda fix

2006-09-20 Thread jerry gay
On 9/20/06, chromatic <[EMAIL PROTECTED]> wrote: On Wednesday 20 September 2006 09:53, Jerry Gay via RT wrote: > thanks, applied as r14673, with a minor fix: > > -$print_coda(); > +&print_coda(); I wouldn't mind seeing the '&' go away entirely. It's syntactic noise in this case. you're right,

Re: [PATCH] as2c.pl C-file coda fix

2006-09-20 Thread chromatic
On Wednesday 20 September 2006 09:53, Jerry Gay via RT wrote: > thanks, applied as r14673, with a minor fix: > > -$print_coda(); > +&print_coda(); I wouldn't mind seeing the '&' go away entirely. It's syntactic noise in this case. -- c

[perl #40371] [PATCH] as2c.pl C-file coda fix

2006-09-20 Thread Jerry Gay via RT
thanks, applied as r14673, with a minor fix: -$print_coda(); +&print_coda(); i'm not sure tools/dev/as2c.pl is used, as the only makefile that calls it isn't generated (config/gen/cpu/i386/Makefile), it's not platform-independent, and the files it generates are committed to the repository. but, t

[perl #40371] [PATCH] as2c.pl C-file coda fix

2006-09-20 Thread Paul Cochrane
# New Ticket Created by "Paul Cochrane" # Please include the string: [perl #40371] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=40371 > Hi, Attached is a patch for tools/dev/as2c.pl which adds a new subroutine print_coda