Re: [PATCH] Win32 env.pmc fixes

2003-08-15 Thread Benjamin Goldberg
In the second chunk of the patch [classes/env.pmc], what is free_it set to if the else branch is taken? IOW, I think you should have free_it initialized to 0 when you declare it. In the last part of the patch [config/gen/platform/win32.c], why do you set *free_it to 0 even when you return NULL?

Re: [PATCH] Win32 env.pmc fixes

2003-08-15 Thread Leopold Toetsch
Mattia Barbon <[EMAIL PROTECTED]> wrote: > Hello, > the correct fix is probably having different code paths for Win32 (because > on Windows NT/2000/XP/.Net and funnier names of the future environment > is/will be Unicode, not char*). For now this makes env.t pass on Win32. Thanks, applied. leo

[PATCH] Win32 env.pmc fixes

2003-08-14 Thread Mattia Barbon
Hello, the correct fix is probably having different code paths for Win32 (because on Windows NT/2000/XP/.Net and funnier names of the future environment is/will be Unicode, not char*). For now this makes env.t pass on Win32. Regards Mattia parrot.cvs.diff Description: Binary data