Re: [PATCH] Small register stack fix

2004-01-13 Thread Leopold Toetsch
Luke Palmer <[EMAIL PROTECTED]> wrote: > +PObj_COW_CLEAR((PObj*)buf); Applied, thanks. leo

Re: [PATCH] Small register stack fix

2004-01-12 Thread Luke Palmer
Dan Sugalski writes: > At 10:09 PM +0100 1/12/04, Leopold Toetsch wrote: > >Luke Palmer <[EMAIL PROTECTED]> wrote: > >> This fixes a rather obvious and silly oversight in my patch. > > > >> +PObj_COW_CLEAR((PObj*)buf); > > > >I don't think that works or better let's say: it's ok 50 percent - fo

Re: [PATCH] Small register stack fix

2004-01-12 Thread Leopold Toetsch
Dan Sugalski <[EMAIL PROTECTED]> wrote: > At 10:09 PM +0100 1/12/04, Leopold Toetsch wrote: > I think I'd as soon leave COW-marked buffers as COW forever, or until > they're garbage collected. I'm thinking of that: 1) "main" creates and calls "sub1" which returns - sub1 doesn't mess with the B

Re: [PATCH] Small register stack fix

2004-01-12 Thread Dan Sugalski
At 10:09 PM +0100 1/12/04, Leopold Toetsch wrote: Luke Palmer <[EMAIL PROTECTED]> wrote: This fixes a rather obvious and silly oversight in my patch. +PObj_COW_CLEAR((PObj*)buf); I don't think that works or better let's say: it's ok 50 percent - for the new "buf" chunk, but the old one, whic

Re: [PATCH] Small register stack fix

2004-01-12 Thread Leopold Toetsch
Luke Palmer <[EMAIL PROTECTED]> wrote: > This fixes a rather obvious and silly oversight in my patch. > +PObj_COW_CLEAR((PObj*)buf); I don't think that works or better let's say: it's ok 50 percent - for the new "buf" chunk, but the old one, which maybe hasn't any refering COWed copy anymore

[PATCH] Small register stack fix

2004-01-12 Thread Luke Palmer
This fixes a rather obvious and silly oversight in my patch. Luke Index: src/register.c === RCS file: /cvs/public/parrot/src/register.c,v retrieving revision 1.35 diff -u -r1.35 register.c --- src/register.c 12 Jan 2004 09:50:2