[perl6/specs] bbebb3: remove rule

2013-12-28 Thread GitHub
Branch: refs/heads/master Home: https://github.com/perl6/specs Commit: bbebb3763a3c733ce741bd9da5f3da0792420ed2 https://github.com/perl6/specs/commit/bbebb3763a3c733ce741bd9da5f3da0792420ed2 Author: Larry Wall Date: 2013-12-27 (Fri, 27 Dec 2013) Changed paths: M S05-reg

Missing write barriers for MVM_string_find_encoding()

2013-12-28 Thread Nicholas Clark
I believe that MVM_file_set_encoding() needs to root oshandle (patch attached) as MVM_string_find_encoding() can allocate and hence can cause a GC run. There are two other uses of MVM_string_find_encoding(). One is: /* At least find_encoding may allocate on first call, so root just * in

Missing write barrier in MVM_sc_get_sc()

2013-12-28 Thread Nicholas Clark
I believe that a write barrier is missing in MVM_sc_get_sc(). Patch attached. This was really really messy to figure out. The bug manifests as a SEGV in process_worklist because a pointer to an object is 0x6. Clearly not a pointer. The value 0x6 has come from the scs array of a MVMCompUnit. In tur

Missing root in MVM_hll_set_config()

2013-12-28 Thread Nicholas Clark
In MVM_hll_set_config(), the call to MVM_string_utf8_decode() inside check_config_key() causes allocation, which means that it can cause GC runs. Which can mean that the object pointed to by config_hash can move. 1) Is the attached patch the correct way to do this? 2) How many more of these lurk -