Re: MARC::Record tests and MicroLIF.pm

2005-01-10 Thread Bryan Baldus
The changes to MARC::File::USMARC for DOS EOF character have been committed to SourceForge cvs along with the 3 test files. Bryan Baldus [EMAIL PROTECTED] [EMAIL PROTECTED] http://home.inwave.com/eija

Re: MARC::Record tests and MicroLIF.pm

2005-01-10 Thread Ed Summers
On Thu, Jan 06, 2005 at 10:03:13PM -0600, Bryan Baldus wrote: > Is there any problem with committing the revised version of > MARC::File::USMARC, and adding+committing the three files above to > cvs in the t/ directory? Nice work :) as long as the tests pass I think comitting sounds like a good

Re: MARC::Record tests and MicroLIF.pm

2005-01-06 Thread Bryan Baldus
MARC::File::MicroLIF::decode() has been updated to change all \0a and \0d to the \n of the platform prior to decoding. t/81.decode.t has been updated to look at lineendings-0a.lif, lineendings-0d.lif, and lineendings-0d0a.lif, instead of sample1.lif. I also revised MARC::Doc::Tutorial.pod to re

Re: MARC::Record tests

2005-01-06 Thread Ed Summers
On Thu, Jan 06, 2005 at 10:52:14AM -0600, [EMAIL PROTECTED] wrote: > _get_chunk() is coded to handle "any combination of \r and \n of any > length". Is it not functioning that way? Thanks for the clarification Mike. I didn't look close enough at _get_chunk() to see it is handling the three differ

RE: MARC::Record tests

2005-01-06 Thread Bryan Baldus
On Thursday, January 06, 2005 10:52 AM, Mike O'Regan wrote: >_get_chunk() is coded to handle "any combination of \r and \n of any >length". Is it not functioning that way? _get_chunk() seems to work fine. The problem is with decode(), which depends upon the line endings having been converted to \

Re: MARC::Record tests

2005-01-06 Thread moregan
perl4lib@perl.org cc: 01/06/2005 09:48 Subject: Re: MARC::Record tests

Re: MARC::Record tests

2005-01-06 Thread Ed Summers
On Thu, Jan 06, 2005 at 10:03:46AM -0600, Bryan Baldus wrote: > Perhaps the: > # for ease, make the newlines match this platform > $lifrec =~ s/[\x0a\x0d]+/\n/g if defined $lifrec; > > in _next() should be moved (or added as duplicate code) to decode() just > between the lines: > my $marc = MA

RE: MARC::Record tests

2005-01-06 Thread Bryan Baldus
>There is code in MARC::File::MicroLIF::_get_chunk that handles DOS >(\r\n) and Unix (\n) line endings, but not Mac (\r). This is true, and it seems to work. Unfortunately, it is not reached by the test, since the test calls decode() directly, instead of going through _next() or _get_chunk. Perha

Re: MARC::Record tests

2005-01-06 Thread Ed Summers
I'm thinking that the MicroLIF failure is due to line endings being different on Mac versions < OS X. There is code in MARC::File::MicroLIF::_get_chunk that handles DOS (\r\n) and Unix (\n) line endings, but not Mac (\r). Does anyone know if \r is a legit line ending in MicroLIF? //Ed

Re: MARC::Record tests

2005-01-05 Thread Bryan Baldus
Some of the MARC::Record tests have been updated in the past weeks, to use File::Spec for file paths. This should allow them to run without much user modification on multiple platforms (MacPerl on MacOS 9, for example). After some trial and error, the tests seem to be working (though more

RE: MARC::Record tests

2004-12-22 Thread Bryan Baldus
On Tue, Dec 21, 2004 at 5:35 PM, Andy Lester ([EMAIL PROTECTED]) wrote: >On Tue, Dec 21, 2004 at 05:27:06PM -0600, Bryan Baldus ([EMAIL PROTECTED]) wrote: >> Speaking of testing, as I mentioned in my e-mail this morning, I modified >> the lint.t test script by using File::Spec to specify the path

Re: MARC::Record tests

2004-12-21 Thread Andy Lester
On Tue, Dec 21, 2004 at 05:27:06PM -0600, Bryan Baldus ([EMAIL PROTECTED]) wrote: > On Tue, Dec 21, 2004 at 9:47 AM Andy Lester ([EMAIL PROTECTED]) wrote: > >I've also released MARC::Record 1.39_02 to CPAN, as a prep for 1.40. If > >folks can test it for me, that'd be swell. > > Speaking of test

MARC::Record tests

2004-12-21 Thread Bryan Baldus
On Tue, Dec 21, 2004 at 9:47 AM Andy Lester ([EMAIL PROTECTED]) wrote: >I've also released MARC::Record 1.39_02 to CPAN, as a prep for 1.40. If >folks can test it for me, that'd be swell. Speaking of testing, as I mentioned in my e-mail this morning, I modified the lint.t test script by using Fil