Re: [perf-discuss] Code Review for new FileBench feature requested

2008-01-29 Thread johansen
> Hmmm, I guess I could allow individual parameters to be accessed with > $., so a couple lines like: > > usage " set \$iosize.min=defaults to $iosize.min" > usage " set \$iosize.gamma= defaults to $iosize.gamma" > > which would print out as: > set $iosize.min= defaults to 1

Re: [perf-discuss] Code Review for new FileBench feature requested

2008-01-29 Thread Andrew Wilson
[EMAIL PROTECTED] wrote: > Hi Drew, > I took a look at your webrev and in general I think this looks good. > > - In the two .f files you added, would it make sense to instruct the > user that $iosize is being randomly set, and they shouldn't adjust the > value? What happens in those two cases

Re: [perf-discuss] Code Review for new FileBench feature requested

2008-01-29 Thread johansen
Hi Drew, I took a look at your webrev and in general I think this looks good. I only have a couple of nits: - Does it make sense to coalese the gamma code and PRNG code into a single module? - I've never done anything with Lex/Yacc, so I didn't review that code - In the two .f files you added