Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-22 Thread Andrew Beekhof
And you'll also want this patch for the crmd diff -r 4619c842d58c crmd/callbacks.c --- a/crmd/callbacks.c Fri May 22 16:52:14 2009 +0200 +++ b/crmd/callbacks.c Fri May 22 21:34:12 2009 +0200 @@ -179,7 +179,6 @@ crmd_ha_msg_callback(HA_Message *hamsg, } else { crmd_ha_msg_fil

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-20 Thread Nikola Ciprich
On Wed, May 20, 2009 at 02:02:52PM +0200, Andrew Beekhof wrote: > Ah, well that was pretty obvious. > /me humbly apologizes for such a stupid error. Hi and thanks! no problem > (It wasn't caught by my own valgrind testing because this function is > specific to heartbeat based clusters) don't worr

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-20 Thread Andrew Beekhof
Ah, well that was pretty obvious. /me humbly apologizes for such a stupid error. (It wasn't caught by my own valgrind testing because this function is specific to heartbeat based clusters) Try this: diff -r ea5d0b58c0be cib/callbacks.c --- a/cib/callbacks.c Wed May 20 11:56:39 2009 +0200 +++

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-19 Thread Andrew Beekhof
I'll take a look at the valgrind data. Thanks! On Tue, May 19, 2009 at 6:39 PM, Nikola Ciprich wrote: > Hello, > sorry to bother again. I've discovered why valgrind didn't > find anything. It is important to stop the process in order to > have valgrind finish the analysis. And it seems that ther

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-19 Thread Nikola Ciprich
Hello, sorry to bother again. I've discovered why valgrind didn't find anything. It is important to stop the process in order to have valgrind finish the analysis. And it seems that there really are leaks not only in cib, but also in attrd and crmd. I just had a slight look into the code reporte

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-18 Thread Andrew Beekhof
On Sat, May 16, 2009 at 10:33 PM, Nikola Ciprich wrote: > Hi guys, > I was able to enable valgrind on our production cluster today, > but unfortunately only on the secondary node, I'll be allowed to enable > it on primary node hopefully during next weekend. > Unfortunately it seems that valgrind p

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-16 Thread Nikola Ciprich
Hi guys, I was able to enable valgrind on our production cluster today, but unfortunately only on the secondary node, I'll be allowed to enable it on primary node hopefully during next weekend. Unfortunately it seems that valgrind probably won't be of much help here. I've got some output from it,

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-14 Thread Nikola Ciprich
Hi guys, sooo I've got valgrind grinding:) I had some trouble getting the latest stuff working, so I used heartbeat-2.99.2 with Dejan's (fixed) patch and --enable-valgrind --with-valgrind-log="--log-file=/tmp/crm-%p.valgrind" and recompiled pacemaker-1.0.3 (withount openais as Andrew suggested).

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-14 Thread Andrew Beekhof
On Thu, May 14, 2009 at 3:58 PM, Nikola Ciprich wrote: > Hi, > Dejan, thanks a lot, I compiled Your version, but crmd with shipped pacemaker > keeps segfaulting > with it, and unable to rebuild pacemaker with this heartbeat to get the > -debug package. > compilation fails with: > > plugin.c: In

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-14 Thread Nikola Ciprich
Hi, Dejan, thanks a lot, I compiled Your version, but crmd with shipped pacemaker keeps segfaulting with it, and unable to rebuild pacemaker with this heartbeat to get the -debug package. compilation fails with: plugin.c: In function 'check_message_sanity': plugin.c:1190: warning: format '%d' ex

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-13 Thread Andrew Beekhof
On Wed, May 13, 2009 at 7:41 PM, Dejan Muhamedagic wrote: > Hi, > > On Wed, May 13, 2009 at 05:36:40PM +0200, Nikola Ciprich wrote: >> > holy ! >> yes! exactly! :) >> >> > sure >> > in theory you can just add "crm valgrind" instead of "crm yes" in ha.cf >> >> hmm, i tried that now, but all I got i

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-13 Thread Dejan Muhamedagic
Hi, On Wed, May 13, 2009 at 05:36:40PM +0200, Nikola Ciprich wrote: > > holy ! > yes! exactly! :) > > > sure > > in theory you can just add "crm valgrind" instead of "crm yes" in ha.cf > > hmm, i tried that now, but all I got is: > May 13 16:46:16 faxb heartbeat: [1655]: ERROR: Heartbeat was not

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-13 Thread Nikola Ciprich
> holy ! yes! exactly! :) > sure > in theory you can just add "crm valgrind" instead of "crm yes" in ha.cf hmm, i tried that now, but all I got is: May 13 16:46:16 faxb heartbeat: [1655]: ERROR: Heartbeat was not compiled with --enable-libc-malloc, "crm valgrind" is therefor not supported. So I

Re: [Pacemaker] cib still leaks in pacemaker-1.0.3

2009-05-13 Thread Andrew Beekhof
On May 13, 2009, at 8:28 AM, Nikola Ciprich wrote: Hello, I've reported this some time ago, few days ago I've updated my system to pacemaker-1.0.3 + related packages. But unfortunately cib process seems to be still leaking,ie it's RSS memory usage is constantly growing. This means we have t