Re: [Pacemaker] New patch for System Health feature

2009-05-18 Thread Lars Marowsky-Bree
On 2009-05-18T15:19:50, Andrew Beekhof wrote: > That was my original intention, but the change ended up quite small > and isolated. > It seemed overkill to start a dev branch for this. As soon as this goes out, we'll have to support this forever. We've made too many such design mistakes in the p

Re: [Pacemaker] New patch for System Health feature

2009-05-18 Thread Lars Marowsky-Bree
On 2009-05-15T19:29:30, Mark Hamzy wrote: > > Here is attempt #3: > > (See attached file: pacemaker.mark.patch) Hi Mark, thanks for your contribution! Can you provide a description and example of how this final version would be used? Maybe a wiki page or something? > Questions/comments? >F

Re: [Pacemaker] New patch for System Health feature

2009-05-18 Thread Andrew Beekhof
On Mon, May 18, 2009 at 3:03 PM, Lars Marowsky-Bree wrote: > On 2009-05-18T14:15:36, Andrew Beekhof wrote: > >> I've applied a modified version of your patch as >> http://hg.clusterlabs.org/pacemaker/stable-1.0/rev/deb967617b9e > > Without sounding like a bore, I disagree with merging this into >

Re: [Pacemaker] New patch for System Health feature

2009-05-18 Thread Lars Marowsky-Bree
On 2009-05-18T14:15:36, Andrew Beekhof wrote: > I've applied a modified version of your patch as > http://hg.clusterlabs.org/pacemaker/stable-1.0/rev/deb967617b9e Without sounding like a bore, I disagree with merging this into stable-1.0 until we have experience in the field how this works out i

Re: [Pacemaker] New patch for System Health feature

2009-05-18 Thread Andrew Beekhof
I've applied a modified version of your patch as http://hg.clusterlabs.org/pacemaker/stable-1.0/rev/deb967617b9e Thanks for doing the initial legwork on this! On Sat, May 16, 2009 at 2:29 AM, Mark Hamzy wrote: > Here is attempt #3: > > (See attached file: pacemaker.mark.patch) > > I chose not to

Re: [Pacemaker] New patch for System Health feature

2009-05-16 Thread Andrew Beekhof
On Thu, May 14, 2009 at 8:07 PM, Mark Hamzy wrote: > and...@beekhof.net wrote on 05/13/2009 21:08:36 PM: > >> This is missing the modification to char2score that i mentioned (which >> would also simplify calculate_system_health()). >> ... > >> Oh, and initialize_health_value() should probably just

Re: [Pacemaker] New patch for System Health feature

2009-05-14 Thread Mark Hamzy
and...@beekhof.net wrote on 05/13/2009 21:08:36 PM: > This is missing the modification to char2score that i mentioned (which > would also simplify calculate_system_health()). > ... > Oh, and initialize_health_value() should probably just set a something > in data_set (which would be passed to cha

Re: [Pacemaker] New patch for System Health feature

2009-05-13 Thread Andrew Beekhof
On Wed, May 13, 2009 at 5:07 PM, Mark Hamzy wrote: > Okay, here is attempt #2: > > (See attached file: pacemaker.mark.patch) > > Questions/comments? This is missing the modification to char2score that i mentioned (which would also simplify calculate_system_health()). You'd only want to call init