[PATCH 13/13] realtek: use correct compatible for rtl930x SoCs

2021-12-08 Thread Sander Vanheule
The base DTSI for RTL930x-based devices contained the compatible for RTL838x-based devices. Although this will be overridden by devices including this file, correct it to indicate what the fallback should be. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 2

Re: [PATCH 08/13] realtek: add board file for MACH_REALTEK_RTL

2021-12-08 Thread Sander Vanheule
On Wed, 2021-12-08 at 22:43 +0100, Sander Vanheule wrote: > To maintain compatibility with existing drivers, which require the > soc_info struct to be available, add a downstream board file for the > MACH_REALTEK_RTL platform. > > MIPS_GENERIC based platforms will iterate throu

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-09 Thread Sander Vanheule
Hi Birger, On Thu, 2021-12-09 at 08:19 +0100, Birger Koblitz wrote: > Hi Sander and Hiroshi, > > great work! A very big step to clean up this platform. Because this changes > the fundamentals of the target I have some suggestions and questions. Thanks! I was expecting some comments from you :-)

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-09 Thread Sander Vanheule
Hi Birger, On Thu, 2021-12-09 at 13:26 +0100, Birger Koblitz wrote: > Hi, > > thanks for the quick reply. Thank you for the input! > On 09.12.21 10:38, Sander Vanheule wrote: > > Hi Birger, > > > > > > > > I would suggest to use sub-targets for the

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-11 Thread Sander Vanheule
Hi Birger, On Fri, 2021-12-10 at 13:30 +0100, Birger Koblitz wrote: > Hi, > > On 09.12.21 22:26, Sander Vanheule wrote: > > This patch series is intended to reduce the maintenance burden, without > > introducing > > breaking changes to devices already in OpenWr

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-12 Thread Sander Vanheule
Hi Sebastian, On Sun, 2021-12-12 at 00:40 +0100, Sebastian Gottschall wrote: > > > I've provided a patch below that enables VPE support for RTL839x. Since > > RTL930x uses > > the > > same CPU architecture, I expect it to also bring up both threads there. > > Like you note > > RTL930x requires

Re: [PATCH 00/13] Switch realtek target to upstream platform

2021-12-12 Thread Sander Vanheule
Hi Sebastian, On Sun, 2021-12-12 at 12:38 +0100, Sebastian Gottschall wrote: > > > I have not experienced a single lock-up when booting with this patch, but I > > also > > didn't > > stress-test the machine or even used the switch part. Do you guys have more > > details on > > why > > it locks

[PATCH v2 00/14] Switch realtek target to upstream platform

2021-12-12 Thread Sander Vanheule
- Fix small formatting issue in realtek-board.c - Add Bjørn's Tested-by to all relevant patches for RTL8380 - Add patch to enable SMP Sander Vanheule (14): realtek: add missing gpio0 pinctrl properties realtek: add sys-led disable pinctrl for rtl930x realtek: remove hardcoded sy

[PATCH v2 01/14] realtek: add missing gpio0 pinctrl properties

2021-12-12 Thread Sander Vanheule
Not all devices using the gpio0/sys-led pin as a GPIO, configure the pinmux. Add the necessary pinctrl properties to these devices to ensure the pin is set up for use as GPIO. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork

[PATCH v2 02/14] realtek: add sys-led disable pinctrl for rtl930x

2021-12-12 Thread Sander Vanheule
Like for RTL838x devices, add a pinctrl-single node to manage the sys-led/gpio0 mux, and allow using the pin as GPIO. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 15 +++ 1 file

[PATCH v2 03/14] realtek: remove hardcoded sys-led configurations

2021-12-12 Thread Sander Vanheule
: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- .../files-5.10/arch/mips/rtl838x/setup.c | 40 --- 1 file changed, 40 deletions(-) diff --git a/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c b/target/linux/realtek/files-5.10/arch/mips

[PATCH v2 05/14] realtek: include io.h in mach-rtl83xx.h

2021-12-12 Thread Sander Vanheule
-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- .../files-5.10/arch/mips/include/asm/mach-rtl838x/mach-rtl83xx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/realtek/files-5.10/arch/mips/include/asm/mach-rtl838x/mach-rtl83xx.h b/target

[PATCH v2 04/14] realtek: use fixed-clock as CPU clock

2021-12-12 Thread Sander Vanheule
Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- target/linux/realtek/dts-5.10/rtl838x.dtsi | 9 - target/linux/realtek/dts-5.10/rtl930x.dtsi | 9 - 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/target/linux/realtek/dts-5.10/rtl838x.dtsi b/target

[PATCH v2 06/14] realtek: update mach-rtl83xx.h includes

2021-12-12 Thread Sander Vanheule
Include the mach-rtl83xx.h header from the root MIPS asm include directory. This will allow custom build options to be dropped once ioremap.h is no longer required. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- target

[PATCH v2 07/14] realtek: backport upstream platform

2021-12-12 Thread Sander Vanheule
Backport the patch that introduced the MACH_REALTEK_RTL platform in 5.12, which is based on MIPS_GENERIC. This will allow some custom platform code to be dropped from the realtek target. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by

[PATCH v2 08/14] realtek: add board file for MACH_REALTEK_RTL

2021-12-12 Thread Sander Vanheule
: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- v2: - Fix function definition formatting --- .../arch/mips/generic/board-realtek.c | 145 ++ ...-in-board-realtek-for-generic-kernel.patch | 9 ++ 2 files changed, 154 insertions(+) create mode 100644

[PATCH v2 09/14] realtek: use correct compatible for rtl930x SoCs

2021-12-12 Thread Sander Vanheule
The base DTSI for RTL930x-based devices contained the compatible for RTL838x-based devices. Although this will be overridden by devices including this file, correct it to indicate what the fallback should be. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 2

[PATCH v2 11/14] realtek: switch target to upstream platform

2021-12-12 Thread Sander Vanheule
, the kernel load and entry addresses need to be updated to match the expected values. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- target/linux/realtek/config-5.10| 36 - target/linux

[PATCH v2 12/14] realtek: drop downstream platform

2021-12-12 Thread Sander Vanheule
The original platform is no longer used by any drivers, but was replaced by MACH_REALTEK_RTL. Drop the old platform patch and unused files. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- .../mips/include/asm/mach

[PATCH v2 13/14] realtek: modernise devicetree console setup

2021-12-12 Thread Sander Vanheule
Instead of providing a console= bootarg, provide the stdout-path property. Complement this with adding the earlycon bootarg, so early console output is available. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- target

[PATCH v2 14/14] realtek: initialise mulithreading on supported SoCs

2021-12-12 Thread Sander Vanheule
variable and make it similar to how other platforms perform this initialisation. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule --- ...S-generic-enable-SMP-on-SMVP-systems.patch | 23 +++ 1 file changed, 23 insertions(+) create mode

[PATCH v2 10/14] realtek: update driver platform dependencies

2021-12-12 Thread Sander Vanheule
Make all drivers depend on the upstream platform, instead of the downstream platform. This can be achieved by dropping the dependendy patches, and requires some updates to the downstream drivers. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule

Re: [RFC PATCH 0/5] add support mikrotik routerboard hex poe

2022-01-04 Thread Sander Vanheule
Hi, On Sun, 2021-12-26 at 20:41 +0200, Oskari Lemmela wrote: > RFC patchset because of following open questions: > > --- [...] > POE driver is implemented as a kernel module. Every port is separate > hwmon device with same label as the DSA port. [...] > > Should this be implemented in Realtek

Re: [PATCH] ramips: support TP-Link EAP615-Wall

2022-01-29 Thread Sander Vanheule
0 > openwrt-ramips-mt7621-tplink_eap615-wall-v1-initramfs-kernel.bin >   # bootm > * Copy openwrt-ramips-mt7621-tplink_eap615-wall-v1-squashfs-sysupgrade.bin >   to /tmp and use sysupgrade to install it > > Thanks to Sander Vanheule for his work on the EAP235-Wall, which made

Re: [PATCH] ramips: support TP-Link EAP615-Wall

2022-02-05 Thread Sander Vanheule
On Fri, 2022-02-04 at 20:05 +0200, Stijn Tintel wrote: > On 29/01/2022 15:03, Sander Vanheule wrote: > > Hi Stijn, > > > > Thanks for the patch, been looking forward to this! > > > > On Fri, 2022-01-28 at 00:00 +0200, Stijn Tintel wrote: > > > Add supp

Re: [PATCH] ramips: support TP-Link EAP615-Wall

2022-02-05 Thread Sander Vanheule
On Sat, 2022-02-05 at 13:36 +0200, Stijn Tintel wrote: > On 4/02/2022 20:05, Stijn Tintel wrote: > > > > +  DEVICE_MODEL := EAP615-Wall > > > > +  DEVICE_VARIANT := v1 > > > > +  DEVICE_PACKAGES := kmod-mt7915e > > > > +  TPLINK_BOARD_ID := EAP615-WALL-V1 > > > > +  KERNEL := kernel-bin | lzma | fi

Re: [PATCH] ramips: support TP-Link EAP615-Wall

2022-02-06 Thread Sander Vanheule
On Fri, 2022-02-04 at 20:05 +0200, Stijn Tintel wrote: > > > diff --git a/target/linux/ramips/image/mt7621.mk > > > b/target/linux/ramips/image/mt7621.mk > > > index a461c57f15..617c8adc37 100644 > > > --- a/target/linux/ramips/image/mt7621.mk > > > +++ b/target/linux/ramips/image/mt7621.mk > > > @

Re: [PATCH v3 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-13 Thread Sander Vanheule
Hi Arınç, On Sun, 2022-02-13 at 11:15 +0300, Arınç ÜNAL wrote: > Add the missing pinctrl properties on the ethernet node. > GMAC1 will start working with this change. > > Link: > https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd...@arinc9.com/ > > Overwrite pinctrl-0 property wit

Re: [PATCH v3 1/3] ramips: mt7621-dts: fix switch@1f warnings

2022-02-13 Thread Sander Vanheule
Hi Arınç, On Sun, 2022-02-13 at 11:15 +0300, Arınç ÜNAL wrote: > Remove reg property from ports node to fix this warning: > > Warning (unit_address_vs_reg): /ethernet@1e10/mdio-bus/switch@1f/ports: > node has a > reg or ranges property, but no unit name > > Another warning surfaces afterwar

Re: [PATCH v3 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-13 Thread Sander Vanheule
On Sun, 2022-02-13 at 16:06 +0300, Arınç ÜNAL wrote: > Hey Sander, > > On 13/02/2022 15:31, Sander Vanheule wrote: > > Hi Arınç, > > > > On Sun, 2022-02-13 at 11:15 +0300, Arınç ÜNAL wrote: > > > Add the missing pinctrl properties on the ethernet node. >

[PATCH v1 0/3] realtek: backport SoC interrupt fixes

2022-02-13 Thread Sander Vanheule
Some fixes for the SoC's interrupt controller were merged upstream for 5.17, and incorporated in 5.16.5 and 5.15.19. These fixes are required to be able to implement the correct interrupt hierarchy in the DT specification of the SoCs, and to get functioning interrupts on RTL930x. Sander Van

[PATCH v1 1/3] realtek: drop routing for unused interrupts

2022-02-13 Thread Sander Vanheule
Drop routing entries for hardware that is not present (GPIO EFGH, RTC) or currently not used (bridge timeouts, timers on RLT838x, USB on RTL930x). Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl838x.dtsi | 7 --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 1 - 2 files

[PATCH v1 2/3] realtek: backport SoC IRQ off-by-one fix

2022-02-13 Thread Sander Vanheule
CPU interrupt routing. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl838x.dtsi| 14 ++--- target/linux/realtek/dts-5.10/rtl930x.dtsi| 24 ...ealtek-rtl-fix-off-by-one-in-routing.patch | 60 +++ 3 files changed, 79 insertions(+), 19 deletions

[PATCH v1 3/3] realtek: backport SoC interrupt vIRQ mapping fix

2022-02-13 Thread Sander Vanheule
-control-data-to-virq.patch @@ -0,0 +1,35 @@ +From 291e79c7e2eb6fdc016453597b78482e06199d0f Mon Sep 17 00:00:00 2001 +From: Sander Vanheule +Date: Sun, 9 Jan 2022 15:54:32 +0100 +Subject: irqchip/realtek-rtl: Map control data to virq + +From: Sander Vanheule + +commit

Re: [PATCH v3 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-14 Thread Sander Vanheule
On Sun, 2022-02-13 at 19:23 +0300, Arınç ÜNAL wrote: > On 13/02/2022 17:14, Sander Vanheule wrote: > > [snip] > > > > > Are you sure this is the only way to make this work? Overwriting a > > > > default in this > > > > many > > > &

Re: [PATCH] realtek: fix locking bug in rtl838x_hw_receive()

2022-02-18 Thread Sander Vanheule
Hi Birger, On Fri, 2022-02-18 at 12:01 +0100, Birger Koblitz wrote: > A Locking bug in the packet receive path was introduced with PR > #4973. The following patch prevents the driver from locking > after a few minutes with an endless flow of > > [ 1434.185085] rtl838x-eth 1b00a300.ethernet eth0:

[PATCH] realtek: fix node addresses for RTL839x

2022-02-20 Thread Sander Vanheule
L8231 node") Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl839x.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/linux/realtek/dts-5.10/rtl839x.dtsi b/target/linux/realtek/dts-5.10/rtl839x.dtsi index 3325dd9969cd..cfed68eb9534 1006

[PATCH] realtek: consolidate bootargs again

2022-02-20 Thread Sander Vanheule
. Fixes: a75b9e3ecb61 ("realtek: Adding RTL930X sub-target") Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl8393_zyxel_gs1900-48.dts | 4 target/linux/realtek/dts-5.10/rtl839x.dtsi | 2 +- target/linux/realtek/dts-5.10/rtl9302_zyxel_xgs1

[PATCH] realtek: ZyXEL GS1900-48: drop status from gpio1

2022-02-20 Thread Sander Vanheule
The default value for a DT node's status property is already "okay", so there's no need to specify it again. Drop the status property to clean up the DTS. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl8393_zyxel_gs1900-48.dts | 2 -- 1 file changed,

[PATCH] realtek: use higher priority for timer interrupts

2022-02-20 Thread Sander Vanheule
highest priority output and corresponds to the (otherwise unused) MIPS CPU timer interrupt. Fixes: a75b9e3ecb61 ("realtek: Adding RTL930X sub-target") Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] realtek: move RTL8231 definitions to board files

2022-02-20 Thread Sander Vanheule
x27;t have a useless gpio1 node label defined. Tested on a Netgear GS110TPPv1. Signed-off-by: Sander Vanheule --- .../dts-5.10/rtl8380_netgear_gigabit.dtsi | 11 ++- .../realtek/dts-5.10/rtl8380_zyxel_gs1900.dtsi | 17 ++--- .../dts-5.10/rtl8382_d-link_dgs-1210-10p.dts

[PATCH] realtek: ZyXEL GS1900-48: fix system LED polarity

2022-02-20 Thread Sander Vanheule
When driven by a GPIO pin, the system LED needs to be configured as active high. Otherwise the LED switches off after booting and initialisation. Fixes: 47f5a0a3eed5 ("realtek: Add support for ZyXEL GS1900-48 Switch") Signed-off-by: Sander Vanheule --- target/linux/realte

[PATCH 2/3] realtek: use DT provided address for timers

2022-02-20 Thread Sander Vanheule
he DT specification, and store it in a private struct for future reference. Matching the second interrupt specifier, the address range for the second timer is added to the DT specification. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi| 2 +- .../arch/mips/kernel

[PATCH 0/3] realtek: Clean up RTL930x event timer

2022-02-20 Thread Sander Vanheule
The new timer provided to support RTL930x SoCs has evaded proper review before getting merged, so some clean-ups are now required. These patches should fix the most glaring issues with the code. These changes were tested on a ZyXEL XGS1250-12. Sander Vanheule (3): realtek: clean up RTL930x

[PATCH 3/3] realtek: remove debugging code from timer

2022-02-20 Thread Sander Vanheule
Remove some (dead) debugging code from the Realtek timer to clean up the sources of this driver. Signed-off-by: Sander Vanheule --- .../files-5.10/arch/mips/kernel/cevt-rtl9300.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/target/linux/realtek/files

[PATCH 1/3] realtek: clean up RTL930x timer DT node

2022-02-20 Thread Sander Vanheule
dden by the fact that the driver associated with this node bypasses the usual DT machinery and does it's own thing. Correct the address to have a sane value, even though it isn't actually used. Fixes: a75b9e3ecb61 ("realtek: Adding RTL930X sub-target") Signed-off-by: Sander

[PATCH] realtek: ZyXEL GS1900-48: drop gpio-restart

2022-02-20 Thread Sander Vanheule
tarts, which is already the de facto behaviour. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl8393_zyxel_gs1900-48.dts | 5 - 1 file changed, 5 deletions(-) diff --git a/target/linux/realtek/dts-5.10/rtl8393_zyxel_gs1900-48.dts b/target/linux/realtek/dts

Re: [PATCH] realtek: ZyXEL GS1900-48: drop gpio-restart

2022-02-21 Thread Sander Vanheule
annot be used anymore. Even if it would work with the current driver, once the RTL8231 is controlled through an MDIO bus (from a kernel perspective), things might change. > > Cheers, >    Birger > > > On 20/02/2022 19:50, Sander Vanheule wrote: > > GPIO 5 on the RTL

Re: [PATCH] realtek: ZyXEL GS1900-48: drop gpio-restart

2022-02-21 Thread Sander Vanheule
On Mon, 2022-02-21 at 12:09 +, Daniel Golle wrote: > On Mon, Feb 21, 2022 at 10:04:13AM +0100, Sander Vanheule wrote: > > On Sun, 2022-02-20 at 21:13 +0100, Birger Koblitz wrote: > > > Hi, > > > > > > during development I came across situations where the R

Re: [PATCH] realtek: ZyXEL GS1900-48: drop gpio-restart

2022-02-22 Thread Sander Vanheule
On Mon, 2022-02-21 at 21:23 +0100, Birger Koblitz wrote: > Hi, > > > > I just checked with my multimeter, and while the GPIO5 on the RTL8231 does > > go high/low > > when I set the output high/low from Linux, my device certainly doesn't > > reset. The > > other > > GPIO lines on the chip do work

Re: [PATCH] realtek: ZyXEL GS1900-48: drop gpio-restart

2022-02-24 Thread Sander Vanheule
[...] > == Reset = > Type: GPIO > GPIO: EXT_5 > [...] > Using the rtk gpio commands in u-boot this can be confirmed. Can you list the commands that you used to test this? My bootloader only supports "rtk network ..." and "cst pinSet ...". > On 22/02/2022 23

Re: [PATCH v2 2/2] ramips: support TP-Link EAP615-Wall

2022-02-26 Thread Sander Vanheule
fs-kernel.bin >   # bootm > * Copy openwrt-ramips-mt7621-tplink_eap615-wall-v1-squashfs-sysupgrade.bin >   to /tmp and use sysupgrade to install it > > Thanks to Sander Vanheule for his work on the EAP235-Wall, which made > adding support for the EAP615-Wall very easy. > > Sign

Re: [PATCH 1/2] realtek: Use firewall4

2022-02-28 Thread Sander Vanheule
Hi Hauke, On Mon, 2022-02-28 at 22:37 +0100, Hauke Mehrtens wrote: > The realtek target is not a router, but basic device, see DEVICE_TYPE. > The basic device type does not come with firewall by default, see > include/target.mk for details. The realtek target extended > DEFAULT_PACKAGES manually w

Re: [PATCH v4 1/2] realtek: enable pca953x driver for rtl838x subtarget

2022-03-13 Thread Sander Vanheule
_PCA953X_IRQ to use interrupt via RTL83xx GPIO. > > Signed-off-by: INAGAKI Hiroshi Acked-by: Sander Vanheule ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH v4 2/2] realtek: add support for Panasonic Switch-M8eG PN28080K

2022-03-13 Thread Sander Vanheule
ddr" variable and set "bootcmd" to the original value > >    on U-Boot: > > setenv loadaddr > setenv bootcmd 'bootm 0x8100' > >    on OpenWrt: > > fw_setenv loadaddr > fw_setenv bootcmd 'bootm 0x8100' &g

Re: [PATCH 1/2] realtek: Use firewall4

2022-03-13 Thread Sander Vanheule
On Tue, 2022-03-01 at 09:09 +0100, Petr Štetiar wrote: > Sander Vanheule [2022-02-28 23:00:34]: > > Hi, > > > Commit 9e7149f729e9 ("realtek: revert to "standard" management > > configuration") changed > > the > > default port

Re: [PATCH] realtek: ZyXEL GS1900-48: drop gpio-restart

2022-03-13 Thread Sander Vanheule
text, maybe there was also something about an issue > with lock > contention. > > Cheers, >    Birger > > > On 24/02/2022 21:19, Sander Vanheule wrote: > > On Tue, 2022-02-22 at 23:39 +0100, Birger Koblitz wrote: > > > Hi, > > > > > > the

Re: realtek: remove firewall and other core components? [Was: Re: [PATCH 1/2] realtek: Use firewall4]

2022-03-23 Thread Sander Vanheule
Hi everyone, On Thu, 2022-03-03 at 15:58 +0100, Petr Štetiar wrote: > Daniel Golle [2022-03-01 21:11:49]: > > Hi, > > > I fully agree, none of those packages make much sense on this class of > > devices and all of them should be dropped from default installations. > > I think, that if you pers

[PATCH 0/2] Support for TP-Link EAP265 HD

2022-04-14 Thread Sander Vanheule
Since the EAP265 HD is identical to the EAP245 v3 hardware wise, both devices can be supported by the same firmware image. In fact, this is what TP-Link does. Without some custom scripting, OpenWrt cannot currently distinguish between the two device variants. Take the same approach as done for e.g

[PATCH 2/2] ath79: add support for TP-Link EAP265 HD

2022-04-14 Thread Sander Vanheule
The EAP265 HD is a rebadged EAP245v3, so images are compatible with both devices. Link: https://fccid.io/TE7EAP265HD/Letter/6-Request-for-FCC-Change-ID-4823578.pdf Signed-off-by: Sander Vanheule --- target/linux/ath79/dts/qca9563_tplink_eap245-v3.dts | 2 +- target/linux/ath79/image/generic-tp

[PATCH 1/2 firmware-utils] tplink-safeloader: add TP-Link EAP265 HD support

2022-04-14 Thread Sander Vanheule
[Support list] SupportList: EAP245(TP-Link|UN|AC1750-D):3.0 EAP265 HD(TP-Link|UN|AC1750-D):1.0 Link: https://fccid.io/TE7EAP265HD/Letter/6-Request-for-FCC-Change-ID-4823578.pdf Signed-off-by: Sander Vanheule --- src/tplink-safeloader.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH] realtek: replace RTL93xx GPIO patches

2022-04-15 Thread Sander Vanheule
until these devices also support SMP. Signed-off-by: Sander Vanheule --- ...-otto-Support-reversed-port-layouts.patch} | 86 +++--- ...ltek-otto-Support-per-cpu-interrupts.patch | 153 ++ ...pio-realtek-otto-Add-RTL930x-support.patch | 29 ...pio-realtek-otto-Add-RT

Re: [PATCH firmware-utils] tplink-safeloader: TP-Link Deco M4R-V3 and Deco M5 support

2022-04-24 Thread Sander Vanheule
Hi Ole Kristian, On Tue, 2022-04-19 at 15:46 +0200, Ole Kristian Lona wrote: > > Support for creating images for TP-Link Deco M4R version 3, and for M5. Please provide separate patches for: * image generation code changes * Deco M4R v3 * Deco M5  > > Partition table and supportlists were e

Re: [PATCH] tplink-safeloader: add TP-Link Deco M4R v1 and v2 support

2022-04-24 Thread Sander Vanheule
Hi, On Fri, 2022-04-22 at 01:09 +0300, Foica David wrote: > Support creating images for TP-Link Deco M4R v1 and v2. > > Original partition layout from OEM image: >  partition fs-uboot base 0x0 size 0x8 >  partition os-image base 0x8 size 0x20 >  partition file-system base 0x28

Re: [PATCH] [firmware-utils PATCH v2] tplink-safeloader: add TP-Link Deco M4R v1 and v2 support

2022-04-24 Thread Sander Vanheule
On Sun, 2022-04-24 at 19:09 +0300, Foica David wrote: > Support creating images for TP-Link Deco M4R v1 and v2. > > Original partition layout from OEM image: >  partition fs-uboot base 0x0 size 0x8 >  partition os-image base 0x8 size 0x20 >  partition file-system base 0x28 size

Re: [PATCH] realtek: Trap all frames with switch as destination to CPU-port

2022-04-25 Thread Sander Vanheule
Hi Birger, On Sun, 2022-04-24 at 20:37 +0200, Birger Koblitz wrote: > This fixes a bug where frames sent to the switch itself were > flooded to all ports unless the MAC address of the CPU-port > was learned otherwise. > > Tested-by: Wenli Looi > Tested-by: Bjørn Mork > Signed-off-by: Birger Kob

Re: [PATCH v2] realtek: do not reset SerDes on link change

2022-04-27 Thread Sander Vanheule
Hi Birger, On Sun, 2022-04-24 at 22:01 +0200, Birger Koblitz wrote: > Do not reset the RTL930x SerDes on link changes, instead set up > the SDS with internal PHYs for the SFP+ ports only. > This fixes the 8 1GBit ports on the Zyxel XGS1250 which > do not work without this patch. > > Tested-by: St

Re: [PATCH] Patch to handle partitions with alternate names.

2022-05-01 Thread Sander Vanheule
Hi Ole Kristian, This patch has some formal issues. The patch title should start with "tplink-safeloader:"; see `git log src/tplink-safeloader.c` for examples. Furthermore, there are trailing white spaces, you've used DOS line endings (CRLF), and there's a number of other formatting issues. You

Re: [PATCH] Patch to handle partitions with alternate names.

2022-05-02 Thread Sander Vanheule
Hi Ole Kristian, On Sun, 2022-05-01 at 23:12 +0200, Ole Kristian Lona wrote: > Thanks. > > > > Hi Ole Kristian, > > > > This patch has some formal issues. The patch title should start with > > "tplink-safeloader:"; > > Sorry, bad mistake, hopefully won't ever happen again! > > > see `git log

Re: [PATCH v2] realtek: do not reset SerDes on link change

2022-05-08 Thread Sander Vanheule
Hi, Sorry I didn't get back to this any sooner. On Wed, 2022-04-27 at 20:16 +0200, Birger Koblitz wrote: > Hi, > > there are presently no working 1GBit SFP modules in master for RTL9300 > (this patch only affects RTL93xx SoCs). On the Ubiquiti USW switch > only the 10GBit modules are set up by u

Re: [PATCH] realtek: Trap all frames with switch as destination to CPU-port

2022-05-08 Thread Sander Vanheule
Hi, On Mon, 2022-04-25 at 20:40 +0200, Sander Vanheule wrote: > Hi Birger, > > On Sun, 2022-04-24 at 20:37 +0200, Birger Koblitz wrote: > > This fixes a bug where frames sent to the switch itself were > > flooded to all ports unless the MAC address of the CPU-port >

Re: [PATCH V3] tplink-safeloader: Patch to handle partitions with alternate names

2022-05-10 Thread Sander Vanheule
Hi Ole Kristian, Could you CC Rafał and me (and other reviewers) on revised patches? At least we should get the patch without DMARC wrapping in that case. On Thu, 2022-05-05 at 17:41 +0200, Ole Kristian Lona wrote: >     Some devices, specifically Deco M4R-v3 / M5 have partition names that >    

Re: [PATCH] firmware-utils: tplink-safeloader: add support for Archer A6 v2 (EU)

2022-05-11 Thread Sander Vanheule
On Sun, 2022-05-08 at 13:31 +0200, Stijn Segers wrote: > The Archer A6 v2 (EU) matches the C6 v2 (EU) and uses the same firmware ID. > See also > https://forum.openwrt.org/t/tp-link-archer-a6-v2-0-cannot-install/119403/34. > > Tested-by: Kamil Jońca > Signed-off-by: Stijn Segers Merged. Thank

Re: [PATCH v2] realtek: do not reset SerDes on link change

2022-05-11 Thread Sander Vanheule
Hi Birger, On Sun, 2022-05-08 at 16:53 +0200, Birger Koblitz wrote: > Hi, > > On 08.05.22 13:11, Sander Vanheule wrote: > > Hi, > > > > Sorry I didn't get back to this any sooner. > > > > On Wed, 2022-04-27 at 20:16 +0200, Birger Koblitz wrote: &

Re: SV: [PATCH V3] tplink-safeloader: Patch to handle partitions with alternate names

2022-05-12 Thread Sander Vanheule
Hi Ole Kristian, On Thu, 2022-05-12 at 14:47 +0200, Ole Kristian Lona wrote: > > >     info->soft_ver.text, len, info->part_trail); > > >     } > > >   > > > @@ -3055,11 +3082,11 @@ static struct image_partition_entry > > > make_soft_version( > > >     }; > > >   > > >

Re: [PATCH v4] tplink-safeloader: Patch to handle partitions with alternate names.

2022-05-20 Thread Sander Vanheule
; in the device definition of tplink-safeloader. > > Signed-off-by: Ole Kristian Lona With one minor comment below: Reviewed-by: Sander Vanheule > --- > > @@ -2993,9 +3022,9 @@ static struct image_partition_entry > make_partition_table(const struct > flash_part > *(

Re: [PATCH v4] tplink-safeloader: Patch to handle partitions with alternate names.

2022-05-23 Thread Sander Vanheule
On Mon, 2022-05-16 at 15:50 +0200, Ole Kristian Lona wrote: > Some devices, specifically Deco M4R-v3 / M5 have partition names that > deviate from the scheme other devices use. They have an added "@0" > and "@1" for some partition names. > > The devices have fallback partitions which will be used

Re: [PATCH v3] ath79: D-Link DAP-2680: select QCA9984 firmware

2022-05-27 Thread Sander Vanheule
Hi Stijn, Allesandro, On Sat, 2022-05-21 at 22:59 +0200, Stijn Segers wrote: > The DAP-2680 has a QCA9984 radio [1], but the commit adding support > mistakenly adds the QCA99x0 firmware package. See forum topic [2]. > > [1] https://wikidevi.wi-cat.ru/D-Link_DAP-2680_rev_A1 > [2] https://forum.ope

[PATCH] realtek: don't unmask non-maskable GPIO IRQs

2022-05-29 Thread Sander Vanheule
g the loop in a cpumask_empty() check, to ensure it will not run on uniprocessor builds if the CPU mask is empty. Fixes: af6cd37f42f3 ("realtek: replace RTL93xx GPIO patches") Reported-by: Robert Marko Reported-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule --- .../316-otto-gpio-uniproc

Re: [PATCH] realtek: don't unmask non-maskable GPIO IRQs

2022-05-29 Thread Sander Vanheule
On Sun, 2022-05-29 at 23:22 +0200, Robert Marko wrote: > On Sun, 29 May 2022 at 19:49, Sander Vanheule wrote: > > > > On uniprocessor builds, for_each_cpu(cpu, mask) will assume 'mask' > > always contains exactly one CPU, and ignore the actual mask contents. > &

Re: [PATCH] tplink-safeloader: Add support for Mercusys MR70X

2022-06-03 Thread Sander Vanheule
Hi, On Fri, 2022-06-03 at 19:46 +, Yoonji Park wrote: > Add support for Mercusys MR70X image creation. A device that's not from TP-Link? Interesting... > > Software version: > soft_ver:1.0.3 Build 20201222 Rel. 50381 > > Partition table: > 0004 fs-uboot > 0004 0040 os-

Re: [PATCH V2] tplink-safeloader: Add support for Mercusys MR70X

2022-06-04 Thread Sander Vanheule
Hi Yoonji, On Sat, 2022-06-04 at 10:50 +, Yoonji Park wrote: > Add support for Mercusys MR70X image creation. > > Software version: > soft_ver:1.0.3 Build 20201222 Rel. 50381 > > Partition table: > 0004 fs-uboot > 0004 0040 os-image > 0044 00b6 file-system > 00fa

[PATCH] ath79: ag71xx-mdio: remove phy-mask property

2022-06-05 Thread Sander Vanheule
;s drop it. Cc: David Bauer Cc: John Crispin Signed-off-by: Sander Vanheule --- .../files/drivers/net/ethernet/atheros/ag71xx/ag71xx_mdio.c | 4 1 file changed, 4 deletions(-) diff --git a/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_mdio.c b/target/linux/a

Re: [PATCH V2] tplink-safeloader: Add support for Mercusys MR70X

2022-06-07 Thread Sander Vanheule
Hi Ole Kristian, On Tue, 2022-06-07 at 08:56 +0200, Ole Kristian Lona wrote: > Hello, Sander! > > I haven't had time to check the rest of the stuff I was working on for Deco > M4R v3 and M5, but > when I see this patch, and think of the work we did in the last round, I > can't help thinking may

[PATCH v1 1/5] realtek: add missing gpio0 pinctrl properties

2022-06-07 Thread Sander Vanheule
Not all devices using the gpio0/sys-led pin as a GPIO, configure the pinmux. Add the necessary pinctrl properties to these devices to ensure the pin is set up for use as GPIO. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork

[PATCH v1 3/5] realtek: add sys-led disable pinctrl for rtl931x

2022-06-07 Thread Sander Vanheule
Like for RTL838x devices, add a pinctrl-single node to manage the sys-led/gpio0 mux, and allow using the pin as GPIO. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl931x.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/linux/realtek/dts-5.10

[PATCH v1 0/5] realtek: remove sys-led from setup.c

2022-06-07 Thread Sander Vanheule
the required info to the devicetree files, and finally removes the setup code. Sander Vanheule (5): realtek: add missing gpio0 pinctrl properties realtek: add sys-led disable pinctrl for rtl930x realtek: add sys-led disable pinctrl for rtl931x realtek: add system LED for ZyXEL XGS1250-12

[PATCH v1 2/5] realtek: add sys-led disable pinctrl for rtl930x

2022-06-07 Thread Sander Vanheule
Like for RTL838x devices, add a pinctrl-single node to manage the sys-led/gpio0 mux, and allow using the pin as GPIO. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 15 +++ 1 file

[PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

2022-06-07 Thread Sander Vanheule
: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork --- .../files-5.10/arch/mips/rtl838x/setup.c | 40 --- 1 file changed, 40 deletions(-) diff --git a/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c b/target/linux/realtek/files-5.10/arch/mips

[PATCH v1 4/5] realtek: add system LED for ZyXEL XGS1250-12

2022-06-07 Thread Sander Vanheule
The devicetree for the ZyXEL XGS1250-12 was missing the description of the front panel LED labeled "PWR SYS". Let's add it so it can be controlled by the user. Signed-off-by: Sander Vanheule --- .../dts-5.10/rtl9302_zyxel_xgs1250-12.dts | 21 +++ 1 f

[PATCH v1] realtek: use fixed-clock as CPU clock

2022-06-07 Thread Sander Vanheule
/generic/init.c. Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl838x.dtsi| 9 +- target/linux/realtek/dts-5.10/rtl930x.dtsi| 9 +- target/linux/realtek/dts-5.10/rtl931x.dtsi| 5 ++- .../files-5.10/arch/mips/rtl838x/setup.c | 32

Re: [PATCH v1 3/5] realtek: add sys-led disable pinctrl for rtl931x

2022-06-07 Thread Sander Vanheule
On Tue, 2022-06-07 at 10:15 +0200, Birger Koblitz wrote: > Hi, > > has anyone tested that??? I don't have any 931x hardware, but it is based on what you put into setup.c. > This does not make sense at all, there is no LED disable > in the LED_GLB_CTRL register. Instead one needs to use > RTL931

Re: [PATCH v1 5/5] realtek: remove hardcoded sys-led configurations

2022-06-07 Thread Sander Vanheule
On Tue, 2022-06-07 at 10:24 +0200, Birger Koblitz wrote: > Hi, > > at least for the RTL931x, removing the rtl931x_setup() is not a good idea as > the WDT reset does > not work for that architecture. > The only way to get a working reset is via registering a reset handler: > > static void __init

Re: [PATCH v1 3/5] realtek: add sys-led disable pinctrl for rtl931x

2022-06-07 Thread Sander Vanheule
Hi Birger, On Tue, 2022-06-07 at 11:26 +0200, Birger Koblitz wrote: > Hi, > > On 07.06.22 11:04, Sander Vanheule wrote: > > On Tue, 2022-06-07 at 10:15 +0200, Birger Koblitz wrote: > > > Hi, > > > > > > has anyone tested that??? > > > > I

[PATCH v2 1/5] realtek: add missing gpio0 pinctrl properties

2022-06-07 Thread Sander Vanheule
Not all devices using the gpio0/sys-led pin as a GPIO, configure the pinmux. Add the necessary pinctrl properties to these devices to ensure the pin is set up for use as GPIO. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule Tested-by: Bjørn Mork

[PATCH v2 2/5] realtek: add sys-led disable pinctrl for rtl930x

2022-06-07 Thread Sander Vanheule
Like for RTL838x devices, add a pinctrl-single node to manage the sys-led/gpio0 mux, and allow using the pin as GPIO. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 15 +++ 1 file

[PATCH v2 3/5] realtek: add mux pinctrl for rtl931x

2022-06-07 Thread Sander Vanheule
Add a pinctrl-single node to manage the sys-led mux and JTAG mux. This allows using the associated pins as GPIOs: - sys-led: GPIO0 - JTAG: GPIO6, GPIO7, others unknown (TDO, TDI, TMS, TCK /TRST) Suggested-by: Birger Koblitz Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10

[PATCH v2 0/5] realtek: remove sys-led from setup.c

2022-06-07 Thread Sander Vanheule
-led peripheral to control something else than an LED. Changes in v2: - Use correct pinmux register for RTL931x - Update description on patch removing setup code Sander Vanheule (5): realtek: add missing gpio0 pinctrl properties realtek: add sys-led disable pinctrl for rtl930x realtek: add

[PATCH v2 3/5] realtek: add sys-led disable pinctrl for rtl931x

2022-06-07 Thread Sander Vanheule
Add a pinctrl-single node to manage the sys-led mux and JTAG mux. This allows using the associated pins as GPIOs: - sys-led: GPIO0 - JTAG: GPIO6, GPIO7, others unknown (TDO, TDI, TMS, TCK /TRST) Suggested-by: Birger Koblitz Signed-off-by: Sander Vanheule --- target/linux/realtek/dts-5.10

[PATCH v2 4/5] realtek: add system LED for ZyXEL XGS1250-12

2022-06-07 Thread Sander Vanheule
The devicetree for the ZyXEL XGS1250-12 was missing the description of the front panel LED labeled "PWR SYS". Let's add it so it can be controlled by the user. Signed-off-by: Sander Vanheule --- .../dts-5.10/rtl9302_zyxel_xgs1250-12.dts | 21 +++ 1 f

<    1   2   3   4   5   >