[PATCH v2 1/3] ramips/mt7621: drop the weak reordering patch

2021-03-30 Thread Rui Salvaterra
.y&id=42344113ba7a1ed7b5654cd5270af0d5698d8521 Suggested-by: Ilya Lipnitskiy Tested-by: Donald Hoskins Signed-off-by: Rui Salvaterra --- .../ramips/patches-5.10/202-weak_reordering.patch | 10 -- .../linux/ramips/patches-5.10/321-mt7621-timer.patch | 4 ++-- 2 files changed, 2 insertions(+), 12

[PATCH v2 3/3] ramips/mt7621: enable support for cpuidle

2021-03-30 Thread Rui Salvaterra
. Signed-off-by: Rui Salvaterra --- target/linux/ramips/mt7621/config-5.10 | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/linux/ramips/mt7621/config-5.10 b/target/linux/ramips/mt7621/config-5.10 index fae046236e..e56f642ab7 100644 --- a/target/linux/ramips

[PATCH 2/2] zram-swap: bail out early if the kernel doesn't support swap

2021-03-31 Thread Rui Salvaterra
Since KERNEL_SWAP is only enabled by default for !SMALL_FLASH targets, we need to check if the current kernel supports swap before trying to configure zram-swap, as opkg can't check for kernel dependencies. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/files/zram.init | 5 +++

[PATCH 0/2] zram-swap improvements

2021-03-31 Thread Rui Salvaterra
A makefile cleanup and an init sanity check, both trivial. Rui Salvaterra (2): zram-swap: clean up the makefile zram-swap: bail out early if the kernel doesn't support swap package/system/zram-swap/Makefile| 12 +--- package/system/zram-swap/files/zram.init | 5 +++

[PATCH 1/2] zram-swap: clean up the makefile

2021-03-31 Thread Rui Salvaterra
Break dependencies into separate lines, to improve the readability. Trim trailing whitespace. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/Makefile | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/package/system/zram-swap/Makefile b/package/system

Re: [PATCH 1/2] zram-swap: clean up the makefile

2021-04-01 Thread Rui Salvaterra
Hi, Stijn, On Wed, 31 Mar 2021 at 22:06, Stijn Tintel wrote: > [snip] > Please put them in alphabetical order. I kept the same order (left to right, top to bottom), but my OCD agrees with you. Will fix. :) Thanks, Rui ___ openwrt-devel mailing list o

[PATCH v2 1/2] zram-swap: clean up the makefile

2021-04-01 Thread Rui Salvaterra
Break dependencies into separate lines, to improve the readability. Trim trailing whitespace. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/Makefile | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/package/system/zram-swap/Makefile b/package/system

[PATCH v2 2/2] zram-swap: bail out early if the kernel doesn't support swap

2021-04-01 Thread Rui Salvaterra
Since KERNEL_SWAP is only enabled by default for !SMALL_FLASH targets, we need to check if the current kernel supports swap before trying to configure zram-swap, as opkg can't check for kernel dependencies. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/files/zram.init | 5 +++

[PATCH v2 0/2] zram-swap improvements

2021-04-01 Thread Rui Salvaterra
A makefile cleanup and an init sanity check, both trivial. v2: Sort the makefile dependencies. Rui Salvaterra (2): zram-swap: clean up the makefile zram-swap: bail out early if the kernel doesn't support swap package/system/zram-swap/Makefile| 12 +--- package/system

[PATCH] mediatek/mt7629: specify CPU_SUBTYPE as neon-vfpv4

2021-04-02 Thread Rui Salvaterra
In Cortex-A7, VFPv4 and NEON aren't optional. All other A7 targets specify neon-vfpv4 as the CPU_SUBTYPE, so there's no reason for MT7629 to be different. Fix thusly. Signed-off-by: Rui Salvaterra --- target/linux/mediatek/mt7629/target.mk | 1 + 1 file changed, 1 insertion(+) di

Re: [PATCH] mediatek/mt7629: specify CPU_SUBTYPE as neon-vfpv4

2021-04-03 Thread Rui Salvaterra
Hi, On Sat, 3 Apr 2021 at 01:28, Chuanhong Guo wrote: > > It is, and mt7629 does have a Cortex A7 without FPU according to the > datasheet and SDK code. Indeed, I should have consulted a more authoritative source, the ARM documentation does say floating point is separately licensable, sadly. Sor

[PATCH] netfilter: remove no-op kconfig symbols

2021-04-08 Thread Rui Salvaterra
These have long been obsolete. For reference, here's the Linux version where each symbol has been dropped: CONFIG_IP6_NF_QUEUE - 3.5 CONFIG_IP6_NF_TARGET_LOG - 3.4 CONFIG_IP_NF_MATCH_DSCP - 2.6.19 CONFIG_NF_CONNTRACK_IPV4 - 4.19 CONFIG_NF_CONNTRACK_IPV6 - 4.19 Signed-off-by: Rui Salva

[PATCH] kernel: drop the conntrack rtcache patch

2021-04-08 Thread Rui Salvaterra
It's in backports-5.4, but it wasn't ever merged. Upstream followed another approach, with flow offloading, which has much better performance. Drop this obsolete patch and refresh the kernel patches. Signed-off-by: Rui Salvaterra --- .../020-backport_netfilter_rtcache.patch

Re: [PATCH] netfilter: remove no-op kconfig symbols

2021-04-09 Thread Rui Salvaterra
Please ignore this one, I'm going to send a more complete version soon. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH v2] netfilter: remove no-op kconfig symbols

2021-04-09 Thread Rui Salvaterra
- OOT, superseded upstream by flow offloading Signed-off-by: Rui Salvaterra --- v2: also removed CONFIG_NF_CONNTRACK_RTCACHE and two references to CONFIG_NF_CONNTRACK_IPV4 in the WireGuard patches (the QEMU kconfigs). include/netfilter.mk| 6 -- ...re

Re: [PATCH v2] netfilter: remove no-op kconfig symbols

2021-04-18 Thread Rui Salvaterra
Hi, Hauke, On Sat, 17 Apr 2021 at 17:14, Hauke Mehrtens wrote: > > > -$(eval $(if $(NF_KMOD),$(call > > nf_add,NF_CONNTRACK,CONFIG_NF_CONNTRACK_RTCACHE, > > $(P_XT)nf_conntrack_rtcache),)) > > This is still uses with a path on top of kernel 5.4 in OpenWrt. Not for long: https://patchwork.ozla

[OpenWrt-Devel] [PATCH] fw3: robustify flow table detection.

2020-01-16 Thread Rui Salvaterra
The flowtable detection fails if the respective target module is built-in, since it's looking for the module itself. Create a generic helper and instead check for existence of the FLOWTABLE target in /proc/net/ip_tables_targets. Signed-off-by: Rui Salvaterra --- defaults.c

[OpenWrt-Devel] [PATCH v2] fw3: robustify flow table detection.

2020-01-18 Thread Rui Salvaterra
nd instead check for existence of the FLOWOFFLOAD target in /proc/net/ip_tables_targets. Signed-off-by: Rui Salvaterra --- defaults.c | 25 +++-- utils.c| 27 +++ utils.h| 6 ++ 3 files changed, 40 insertions(+), 18 deletions(-) diff --git a/de

[PATCH] mac80211/rtl: backport a rtl8192cu AP mode fix

2021-04-21 Thread Rui Salvaterra
Running USB devices in AP mode is never a good idea. That said, fix the TIM issue in rtl8192cu [1], allowing these devices to "work" in AP mode. [1] https://patchwork.kernel.org/project/linux-wireless/patch/20210419065956.6085-1-pks...@realtek.com/ Signed-off-by: Rui Salvaterra -

Re: [PATCH v2] netfilter: remove no-op kconfig symbols

2021-04-23 Thread Rui Salvaterra
Hi, Jason, On Fri, 23 Apr 2021 at 03:15, Jason A. Donenfeld wrote: > > https://git.zx2c4.com/wireguard-linux/commit/?h=backport-5.4.y&id=ac8265d3b26e7c2674e066af6451c5a61d3f2e7a > > This will be included in the patchset next time I push a refresh of those. Ok, I'll drop the patch changes and sen

[PATCH v3] netfilter: remove no-op kconfig symbols

2021-04-28 Thread Rui Salvaterra
ut-of-tree, superseded by flow offloading Signed-off-by: Rui Salvaterra --- v3: keep CONFIG_NF_CONNTRACK_IPV4 in the WireGuard patches, as this will be handled by Jason in an upcoming refresh [1]. v2: also removed CONFIG_NF_CONNTRACK_RTCACHE and two references to CONFIG_NF_CONNTRACK_IPV4 i

[PATCH] tools/isl: bump to 0.24

2021-05-27 Thread Rui Salvaterra
Tested with Graphite and -floop-nest-optimize, without issues. Signed-off-by: Rui Salvaterra --- tools/isl/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/isl/Makefile b/tools/isl/Makefile index c1000e1e31..be372fe2a8 100644 --- a/tools/isl/Makefile +++ b

Re: [PATCH 21.02 03/11] ramips: mt7621: Add support for ZyXEL NR7101

2021-06-08 Thread Rui Salvaterra
Hi, guys, On Tue, 8 Jun 2021 at 21:33, Hauke Mehrtens wrote: > > On 6/8/21 1:10 PM, Bjørn Mork wrote: > > Tested-by: Bjørn Mork > > > > > > Unrelated, but confused the hell out of me: > > > > I tested this by sysupgrading from a master based installation using a > > 5.10 kernel. And ended up wi

[PATCH] zram-swap: robustify mkswap/swapon/swapoff invocation

2021-06-21 Thread Rui Salvaterra
Instead of assuming /sbin contains the correct BusyBox symlinks, directly invoke the busybox executable. The required utilities are guaranteed to be present, since the zram-swap package selects them. Additionally, don't assume busybox resides in /bin, rely on PATH to find it. Signed-off-by

[PATCH v2] zram-swap: robustify mkswap/swapon/swapoff invocation

2021-06-22 Thread Rui Salvaterra
pdate the copyright year, use SPDX and switch to AUTORELEASE. Signed-off-by: Rui Salvaterra --- v2: update the copyright year, use SPDX and switch to AUTORELEASE. package/system/zram-swap/Makefile| 9 ++ package/system/zram-swap/files/zram.init | 39 ++-- 2

[PATCH 2/3] zram-swap: set the zram swap priority to 100 by default

2021-06-24 Thread Rui Salvaterra
New swap devices are added in decreasing priority order, starting at -1. Make sure the zram swap device has the highest priority, by default. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/files/zram.init | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

[PATCH 0/3] zram-swap cleanups and fixes.

2021-06-24 Thread Rui Salvaterra
The first and third patches are cleanups. The second fixes a priority problem with multiple swap devices, when added with no priorities specified. Rui Salvaterra (3): zram-swap: robustify mkswap/swapon/swapoff invocation zram-swap: set the zram swap priority to 100 by default zram-swap

[PATCH 1/3] zram-swap: robustify mkswap/swapon/swapoff invocation

2021-06-24 Thread Rui Salvaterra
pdate the copyright year, use SPDX and switch to AUTORELEASE. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/Makefile| 9 ++ package/system/zram-swap/files/zram.init | 40 ++-- 2 files changed, 13 insertions(+), 36 deletions(-) diff --git a/package/s

[PATCH 3/3] zram-swap: clean up the log messages

2021-06-24 Thread Rui Salvaterra
Remove redundant tags and name things more consistently. Signed-off-by: Rui Salvaterra --- package/system/zram-swap/files/zram.init | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/package/system/zram-swap/files/zram.init b/package/system/zram-swap/files

[PATCH] dnsmasq: add a new "bind" configuration option

2021-07-08 Thread Rui Salvaterra
Finally, the nonwildcard option is kept for backwards compatibility. [1] https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html Signed-off-by: Rui Salvaterra --- package/network/services/dnsmasq/files/dhcp.conf| 2 +- package/network/services/dnsmasq/files/dnsmasq.init | 8 +++-

[PATCH 0/2] kernel/generic: two trivial fixes

2021-07-18 Thread Rui Salvaterra
Add a missing symbol and resort the 5.10 kconfig. Rui Salvaterra (2): kernel/generic: add a missing symbol to the 5.10 kconfig kernel/generic: sort the 5.10 kconfig symbols target/linux/generic/config-5.10 | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.32.0

[PATCH 2/2] kernel/generic: sort the 5.10 kconfig symbols

2021-07-18 Thread Rui Salvaterra
Sort the kernel configuration using scripts/kconfig.pl. Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10 index 746f401ec9..54e6d817da

[PATCH 1/2] kernel/generic: add a missing symbol to the 5.10 kconfig

2021-07-18 Thread Rui Salvaterra
Add CONFIG_HAVE_ARM_ARCH_TIMER (disabled). A make kernel_oldconfig on cortexa9 will otherwise prompt for its selection. The 5.4 configuration already contains the same symbol. Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH] elfutils: fix building with GCC 11

2021-07-18 Thread Rui Salvaterra
Add a patch to fix building with GCC 11, which triggers new warnings by enabling -Warray-parameter by default. Signed-off-by: Rui Salvaterra --- .../patches/111-fix-gcc11-build.patch | 22 +++ 1 file changed, 22 insertions(+) create mode 100644 package/libs/elfutils

[PATCH] toolchain/binutils: add binutils 2.37

2021-07-19 Thread Rui Salvaterra
Tested on ath79/generic, without issues. Signed-off-by: Rui Salvaterra --- toolchain/binutils/Config.in | 4 ++ toolchain/binutils/Config.version | 4 ++ toolchain/binutils/Makefile | 4 ++ .../2.37/300-001_ld_makefile_patch.patch | 22

[PATCH] linux/rockchip: remove the USB 3.0 controller node patch

2021-07-20 Thread Rui Salvaterra
f-by: Rui Salvaterra --- ...address-support-to-of_get_mac_addres.patch | 13 ++-- ...et-add-mac-address-increment-support.patch | 9 +-- ...usb3-controller-node-for-RK3328-SoCs.patch | 62 --- 3 files changed, 6 insertions(+), 78 deletions(-) delete mode 100644 target/linux/rock

Re: [PATCH] linux/rockchip: remove the USB 3.0 controller node patch

2021-07-20 Thread Rui Salvaterra
This isn't the correct fix, I'll send a proper one shortly. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH] linux/rockchip: update the USB 3.0 controller node patch

2021-07-20 Thread Rui Salvaterra
This has been added in Linux 5.10.51 [1], but it's broken/incomplete. Update our patch and refresh the remaining patches. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.10.51&id=421aff50af5e4cdc56b3ac8d6b670e09697bc8ac Signed-off-by: Rui S

Re: [PATCH] toolchain/binutils: add binutils 2.37

2021-07-23 Thread Rui Salvaterra
Hi, Just a heads-up, if you want to play with it, binutils 2.37 breaks our 5.10 kernel build at the SORTTAB step, on mvebu/cortexa9 (at least), with the following error: no __ex_table in file: vmlinux Failed to sort kernel tables However, ramips/mt7621 (5.10) builds and runs without issues. Che

[PATCH] kernel/generic: fix the 5.10 arm gc-sections patch

2021-07-23 Thread Rui Salvaterra
RD(x) KEEP(x)" change is bogus. It would only apply to !CONFIG_MMU devices (which we don't support in OpenWrt), and it would even break the build if referenced. Drop it. While at it, rename the patch in order to make it obvious that it's arm-specific. Signed-off-by: Rui Salvater

[PATCH] kernel/generic: add CONFIG_KCSAN to the 5.10 kconfig

2021-07-27 Thread Rui Salvaterra
Add the missing CONFIG_KCSAN (disabled). Found while making kernel_oldconfig on an x86-64 subtarget. Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/generic/config-5.10 b/target/linux/generic/config-5.10 index

[PATCH] ath79: fix the AR7{1,2}00 USB PHY patches

2021-07-29 Thread Rui Salvaterra
PHY_SIMPLE is a bogus kconfig symbol, what we really need to select is GENERIC_PHY. Signed-off-by: Rui Salvaterra --- .../ath79/patches-5.10/0004-phy-add-ath79-usb-phys.patch | 4 ++-- .../linux/ath79/patches-5.4/0004-phy-add-ath79-usb-phys.patch | 4 ++-- 2 files changed, 4 insertions

Re: [PATCH] kernel: set CONFIG_RCU_FANOUT=64 for 64bit targets

2021-08-01 Thread Rui Salvaterra
Hi, Stijn, On Sat, 31 Jul 2021 at 11:01, Stijn Tintel wrote: > > Alternatively we could disable CONFIG_RCU_EXPERT entirely. Not sure why > it was enabled in the first place. If anyone knows, please do share. Yes, please! Personal note, CONFIG_RCU_EXPERT is one of those things I don't even touch.

Re: [PATCH 0/6] use binutils 2.36.1 and gcc 10 by default

2021-08-15 Thread Rui Salvaterra
HI, guys, On Sun, 15 Aug 2021 at 13:00, Stijn Tintel wrote: > > On 15/08/2021 14:53, Hauke Mehrtens wrote: > > > > Did you check if the size of some of our images changed? > I did not. I can do that, but it'll take some time. I started regularly > wiping build_dir/ staging_dir/ and tmp/ due to va

[PATCH] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
https://www.kernel.org/doc/Documentation/RCU/Design/Data-Structures/Data-Structures.html [2] https://lwn.net/Articles/777214/ Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 7 +-- target/linux/generic/config-5.4 | 6 +- 2 files changed, 2 insertions(+), 11 deletions(-)

Re: [PATCH 0/6] qoriq: new target

2021-08-22 Thread Rui Salvaterra
Hi, Stijn, FWIW, the whole series is… Reviewed-by: Rui Salvaterra … even though I don't have the hardware for testing it. But being a new target, the whole thing is self-contained. :) Cheers, Rui ___ openwrt-devel mailing list openwrt-

Re: [PATCH 6/6] qoriq: add support for WatchGuard Firebox M300

2021-08-22 Thread Rui Salvaterra
Hi, Alberto, On Sun, 22 Aug 2021 at 01:07, Alberto Bursi wrote: > > Do you think adding the Watchguard M200 would be mostly a copy-paste > job? from what I have seen online it should be more or less the same > board but with a lower end CPU. > I might get one in the near future to do this myself

Re: [PATCH] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
Hi, Hauke, On Sun, 22 Aug 2021 at 10:20, Hauke Mehrtens wrote: > > There are also some targets which explicitly unset CONFIG_RCU_EXPERT: [snipped] > This should be removed from the target config file. Sure thing, I'll clean up the targets and fold the changes into this patch. > CONFIG_RCU_STA

Re: [PATCH] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
Hi, Hauke, On Sun, 22 Aug 2021 at 13:45, Hauke Mehrtens wrote: > > Both options are hidden anyway, so we can manually change them: > > config RCU_STALL_COMMON > def_bool ( TREE_RCU || PREEMPT_RCU ) > help > > config RCU_NEED_SEGCBLIST > def_bool ( TREE_RCU || PREEMPT_RCU |

[PATCH 1/2] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
mbols. Additionally, remove the CONFIG_RCU_EXPERT symbol from the target kconfigs which contain it. [1] https://www.kernel.org/doc/Documentation/RCU/Design/Data-Structures/Data-Structures.html [2] https://lwn.net/Articles/777214/ Signed-off-by: Rui Salvaterra --- target/linux/gemini/config-5.10

[PATCH 2/2] kernel: move two symbols to the generic kconfigs

2021-08-22 Thread Rui Salvaterra
CONFIG_RCU_{NEED_SEGCBLIST,STALL_COMMON} are set basically everywhere. Move them to the generic kconfigs. And resort the generic kconfigs while at it. Signed-off-by: Rui Salvaterra --- target/linux/arc770/config-5.4 | 2 -- target/linux/archs38/config-5.4 | 2

Re: [PATCH 2/2] kernel: move two symbols to the generic kconfigs

2021-08-22 Thread Rui Salvaterra
Hi, Hauke, On Sun, 22 Aug 2021 at 14:32, Hauke Mehrtens wrote: > > > -# CONFIG_VIDEO_IRS1125 is not set > > Why is this only removed? I'd love to have an answer to that question. I think the resorting got messed up (after reinserting the symbol and resorting, everything is fine, so I probably sc

[PATCH v2 2/2] kernel: move two symbols to the generic kconfigs

2021-08-22 Thread Rui Salvaterra
CONFIG_RCU_{NEED_SEGCBLIST,STALL_COMMON} are set basically everywhere. Move them to the generic kconfigs. And resort the generic kconfigs while at it. Signed-off-by: Rui Salvaterra --- v2: add back CONFIG_VIDEO_IRS1125, which fell off for some unfathomable reason. target/linux/arc770/config

[PATCH v2 1/2] kernel: disable CONFIG_RCU_EXPERT and friends

2021-08-22 Thread Rui Salvaterra
mbols. Additionally, remove the CONFIG_RCU_EXPERT symbol from the target kconfigs which contain it. [1] https://www.kernel.org/doc/Documentation/RCU/Design/Data-Structures/Data-Structures.html [2] https://lwn.net/Articles/777214/ Signed-off-by: Rui Salvaterra --- v2: no changes since v1, just resending th

Re: OpenWrt 21.02 status

2021-08-30 Thread Rui Salvaterra
+1 for release. It's just been too long since the last one. The idea of time-based releases is getting lost and this is a process issue we definitely should address. On Sun, 29 Aug 2021 at 11:44, Hannu Nyman wrote: > > Hauke Mehrtens wrote at Sun Aug 29 02:53:47 PDT 2021: > > > Should we just re

Re: [PATCH] kernel: Set CONFIG_RCU_CPU_STALL_TIMEOUT=21

2021-08-30 Thread Rui Salvaterra
eric configuration to 21 > seconds and removes the target specific configuration options. > > Signed-off-by: Hauke Mehrtens [patch snipped] This looks fine. Acked-by: Rui Salvaterra ___ openwrt-devel mailing list openwrt-de

[PATCH] kernel: add missing CONFIG_SECURITY_NETWORK_XFRM ksym

2021-09-01 Thread Rui Salvaterra
Paul noticed a build failure [1] due to this missing symbol. Add it as disabled to both generic kconfigs. [1] https://github.com/aparcar/openwrt/runs/3480872706?check_suite_focus=true#step:11:63 Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 1 + target/linux/generic

Re: [PATCH] octeontx: add linux 5.10 testing kernel support

2021-09-03 Thread Rui Salvaterra
Hi, Daniel, On Fri, 3 Sept 2021 at 10:18, Daniel Danzberger wrote: > [snipped for context] > +CONFIG_RCU_NEED_SEGCBLIST=y > +CONFIG_RCU_STALL_COMMON=y Please refresh your kernel configuration. At least these two symbols are part of the generic kconfigs. Thanks, Rui __

Re: [PATCH] octeontx: add linux 5.10 testing kernel support

2021-09-03 Thread Rui Salvaterra
Hi again, Daniel, On Fri, 3 Sept 2021 at 12:46, Daniel Danzberger wrote: > [snipped] > +CONFIG_EXT4_FS=y > +CONFIG_EXT4_FS_POSIX_ACL=y > +CONFIG_F2FS_FS=y > +CONFIG_FANOTIFY=y > +CONFIG_FAT_FS=y Do all of these filesystems have to be built-in? We have config options for them. [snipped] > +CO

Re: Broken ARP broadcast on master (commit 0f688797)

2021-09-06 Thread Rui Salvaterra
Hi, Felix, On Mon, 6 Sept 2021 at 13:19, Felix Fietkau wrote: > > Please try the latest version, it should resolve the issue I know I'm not the original complainer, but I tested a while ago and indeed this revert fixes the broadcast issue for me. :) Cheers, Rui

[PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
It's been brewing on my cortexa9 subtarget (Turris Omnia) for months. Perfectly stable. Signed-off-by: Rui Salvaterra --- target/linux/mvebu/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/mvebu/Makefile b/target/linux/mvebu/Makefile index 3737a

Re: [PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
Hi, Daniel, On Tue, 7 Sept 2021 at 22:09, Daniel Golle wrote: > > I'd remove the KERNEL_TESTING_PATCHVER line then until we add 5.14 or > whatever it's going to be. Sure, I didn't know what the usual procedure was, so I just mimicked aparcar. ;) V2 coming up. Thanks, Rui __

[PATCH v2] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
It's been brewing on my cortexa9 subtarget (Turris Omnia) for months. Perfectly stable. Signed-off-by: Rui Salvaterra --- v2: remove KERNEL_TESTING_PATCHVER altogether, as per dangole's suggestion. target/linux/mvebu/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH] mvebu/kernel: promote 5.10 to stable

2021-09-07 Thread Rui Salvaterra
Hi, Paul, On Tue, 7 Sept 2021 at 22:37, Paul Spooren wrote: > > This seems to be an ongoing thing, some add it and some remove it, I'm > happy to make this consistent: > > * Remove KERNEL_TESTING_PATCHVER when promoting > > or > > * Set KERNEL_{,TESTING}_PATCHVER to the same value until a new tes

[PATCH] ramips: switch to kernel 5.10

2021-09-09 Thread Rui Salvaterra
Tested on mt7621 (Redmi AC2100) and running stable for several months. Signed-off-by: Rui Salvaterra --- target/linux/ramips/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/linux/ramips/Makefile b/target/linux/ramips/Makefile index d3f2d4b8fc..c9fc1aa58a

Re: mvebu: switch to kernel 5.10 - MACCHIATObin Single Shot

2021-09-09 Thread Rui Salvaterra
Hi, Alexandra, On Thu, 9 Sept 2021 at 09:52, Alexandra Alth wrote: > > Hello Guys, > > Thanks a lot Rui Salvaterra for the mvebu switch to kernel 5.10. > > The SFP+ support for 10GE transceivers was broken in the Repository since at > least 9 months when build with kern

Re: Build issues gcc10

2021-09-12 Thread Rui Salvaterra
Hi, Adrian, On Sun, 12 Sept 2021 at 15:15, Adrian Schmutzler wrote: > > I'm having build issues with master and (default) gcc10 on ipq targets. I don't know about ipq, but I jumped straight to GCC 11.2. Does it make sense to bother with 10? That said… > xgcc: fatal error: cannot execute 'cc1plu

Re: Build issues gcc10

2021-09-13 Thread Rui Salvaterra
Hi, Adrian, On Mon, 13 Sept 2021 at 23:10, Adrian Schmutzler wrote: > > Just had one try before I went to bed, but it appears the problem is that > cc1plus generated by the toolchain has no execute bit set: How in blazes…? > /data/openwrt/build_dir/toolchain-arm_cortex-a15+neon-vfpv4_gcc-10.3.

[PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-19 Thread Rui Salvaterra
: 22 */ /* last cacheline: 24 bytes */ Signed-off-by: Rosen Penev [Fix typos in the patch description] Signed-off-by: Rui Salvaterra --- The ag71xx_ring changes are already part of the upstream driver. However, since we're not using it at all yet, let's apply this to our driver fo

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-25 Thread Rui Salvaterra
Hi, Adrian, On Fri, 24 Sept 2021 at 22:28, Adrian Schmutzler wrote: > > Commit title prefix should be "ath79: ag71xx:" or just "ath79:". To be honest, it makes more sense to me to have " ath79/ag71xx:", as it conveys the same information requiring one character less (and this format has often b

[PATCH v2] ath79: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rui Salvaterra
: 22 */ /* last cacheline: 24 bytes */ Signed-off-by: Rosen Penev [Reword and fix typos in the patch description] Signed-off-by: Rui Salvaterra --- v2: Change subject prefix to "ath79:". .../net/ethernet/atheros/ag71xx/ag71xx.h | 32 ++- 1 file changed, 17

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rui Salvaterra
Hi, David, On Sun, 26 Sept 2021 at 12:37, David Bauer wrote: > > Does this mean parts of this patch are already applied upstream? Yes, the ag71xx_ring section. > Also are there already performance numbers available? Rosen has performance numbers comparing ar71xx to ath79 DSA including this pat

Re: Release goals for 22.XX

2021-10-06 Thread Rui Salvaterra
Hi, Rich, On Wed, 6 Oct 2021 at 17:54, Rich Brown wrote: > > Paul, Rafał, > > I think our emails passed in the ether... > (http://lists.openwrt.org/pipermail/openwrt-devel/2021-October/036637.html) > > As I said in that message, I am very aware of the time constraints of the > volunteers for Op

Re: Release goals for 22.XX

2021-10-08 Thread Rui Salvaterra
Hi, Paul, On Fri, 8 Oct 2021 at 10:14, Paul Spooren wrote: > > > > - ath25 > > > Could this be dropped? Nothing in this target has more than 32 MiB of RAM (most devices have 16 MiB) [1]. Just put it out of its misery. :) [1] https://openwrt.org/?do=showtag&tag=ath25 Cheers, Rui __

Re: Release goals for 22.XX

2021-10-08 Thread Rui Salvaterra
Hi, Paul, On Fri, 8 Oct 2021 at 11:09, Rui Salvaterra wrote: > > Nothing in this target has more than 32 MiB of RAM (most devices have > 16 MiB) [1]. Just put it out of its misery. :) Scratch that. After chatting with dangole, there may be some life in it, after all. I have an ath

Re: Release goals for 22.XX

2021-10-10 Thread Rui Salvaterra
Hi, Sergey, On Sun, 10 Oct 2021 at 01:43, Sergey Ryazanov wrote: > > I am in the process of migrating ath25 to the 5.10 kernel. Initial > build was trivial. But I need to restore the Marvel swconfig driver > that was lost during the initial 5.10 kernel introduction, and > carefully run-time test

Marvell EBU 32-bit performance benchmarks (VFPv3-D16 vs NEON builds, Turris Omnia).

2021-10-21 Thread Rui Salvaterra
Hi, guys, So, last meeting I proposed splitting the 32-bit mvebu target in vfpv3-d16 and neon subtargets. It seems this subject comes up every couple of years, or so. This time I hope to show solid evidence on why it would be an exercise in futility, closing the matter once and for all. In order t

[PATCH] tools/isl: update the download URL

2021-10-21 Thread Rui Salvaterra
isl.gforge.inria.fr has been dead since early this month [1]. Switch to libisl.sourceforge.io for the time being. [1] https://groups.google.com/g/isl-development/c/JGaMo2VUu_8 Signed-off-by: Rui Salvaterra --- Note: this needs to be backported to every supported OpenWrt version. tools/isl

[PATCH] dnsmasq: fix the dynamic dns object names patch

2021-11-12 Thread Rui Salvaterra
We can't use booleans, since we're not including stdbool.h. Use integers instead. Fixes: 0b79e7c01e ("dnsmasq: generate the dns object name dynamically") Signed-off-by: Rui Salvaterra --- .../services/dnsmasq/patches/200-ubus_dns.patch| 14 +++--- 1 file changed

Re: zram-swap: default to lzo instead of lzo-rle compression

2021-11-29 Thread Rui Salvaterra
Hi, Sven, On Sun, 28 Nov 2021 at 01:40, Sven Roederer wrote: > > Rui, not sure if to call it a bug. At the end there is a hardcoded default > algo in the module, that is used initially when creating the device. The check > for the valid algo is done later at device-activation. > I spend some time

Re: [PATCH] kernel: make zram honor available compressors when selecting the initial algo

2021-12-01 Thread Rui Salvaterra
Hi, Sven, [patch snipped] Why not just include the lzo-lre module in the lzo module package? We already agreed they're basically inseparable. In fact, I remember I had sent a patch [1] a while ago, in order to do just that. Thanks, Rui [1] https://patchwork.ozlabs.org/project/openwrt/patch/202

Re: zram-swap: default to lzo instead of lzo-rle compression

2021-12-01 Thread Rui Salvaterra
Hi, Felix, On Wed, 1 Dec 2021 at 12:45, Felix Fietkau wrote: > > Maybe upstream would accept a simple makefile change that merges both > into a single module without changing any of the source files. That's the most logical course of action, yes. Otherwise, this patch [1] I sent last year seems

Re: [PATCH] kernel: make zram honor available compressors when selecting the initial algo

2021-12-02 Thread Rui Salvaterra
Hi, Sven, On Thu, 2 Dec 2021 at 01:49, Sven Roederer wrote: > > I'm trying to make a as small as possible kernel (to safe RAM / flash). As I'm > already using the lzo-module I like to avoid to include both and keep the > choice to select any combination of them. I wholeheartedly agree with the o

[PATCH] kernel/generic: select the fq_codel qdisc by default

2021-12-19 Thread Rui Salvaterra
The kernel configuration allows us to select a default qdisc. Let's do this and get rid of the hacky patch we've been carrying. Signed-off-by: Rui Salvaterra --- target/linux/generic/config-5.10 | 5 +- .../661-use_fq_codel_by_default.patch | 100 ---

[PATCH] kmod-sched-core: remove fq_codel from the package

2021-12-20 Thread Rui Salvaterra
Since fq_codel is the default (and built-in), it's unnecessary to make it part of kmod-sched-core. Remove it. Signed-off-by: Rui Salvaterra --- package/kernel/linux/modules/netsupport.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/kernel/linux/mo

Re: [PATCH v2 7/8] qoriq: new target

2021-12-21 Thread Rui Salvaterra
Hi, Stijn, Nice to see this! :) A few nits/comments/questions below… On Mon, 20 Dec 2021 at 19:01, Stijn Tintel wrote: > > Add a new target named "qoriq", that will support boards using PowerPC > processors from NXP's QorIQ brand. > > This doesn't actually add support for any board yet, so that

Re: [PATCH v2 1/8] build: add e5500 CPU_TYPE

2021-12-21 Thread Rui Salvaterra
U_TYPE ?= powerpc64 > +CPU_CFLAGS_e5500:=-mcpu=e5500 > CPU_CFLAGS_powerpc64:=-mcpu=powerpc64 > endif > ifeq ($(ARCH),sparc) > -- > 2.32.0 > Reviewed-by: Rui Salvaterra Cheers, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH v2 3/8] toolchain/gcc: use ELFv2 ABI on ppc64 with musl

2021-12-21 Thread Rui Salvaterra
--with-gmp=$(TOPDIR)/staging_dir/host \ > --with-mpfr=$(TOPDIR)/staging_dir/host \ > --with-mpc=$(TOPDIR)/staging_dir/host \ > -- > 2.32.0 > Yes, please. I could be wrong, but I think all ppc64 targets in the kernel are migrating to the ELFv2 ABI. Reviewed-by

[PATCH] kernel/5.10: allocate last level PTEs in high memory

2022-01-03 Thread Rui Salvaterra
Signed-off-by: Rui Salvaterra --- 5.4 deemed unworthy, since it's going the way of the dodo. :) target/linux/bcm53xx/config-5.10 | 2 +- target/linux/ipq40xx/config-5.10 | 2 +- target/linux/ipq806x/config-5.10 | 2 +- target/linux/mediatek/mt7623/config-5.1

[PATCH] procd: mount /dev with noexec

2022-01-05 Thread Rui Salvaterra
ority of our targets doesn't have a GPU, anyway. :) [1] https://lore.kernel.org/all/YcMfDOyrg647RCmd@debian-BULLSEYE-live-builder-AMD64/ [2] https://lore.kernel.org/all/CAPXgP12e5LpN6XVxaXOHhH=u8XXN==2retajdcock4tp4qd...@mail.gmail.com/ Signed-off-by: Rui Salvaterra --- initd/early.c |

[PATCH] kernel/5.10: disable CONFIG_DEVTMPFS{,_MOUNT}

2022-01-05 Thread Rui Salvaterra
We rely on procd to create/populate /dev for us. These can be safely disabled. Signed-off-by: Rui Salvaterra --- target/linux/archs38/config-5.10 | 1 - target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux/layerscape/armv8_64b/config-5.10 | 2 -- target/linux/mediatek

[PATCH] kernel/5.10: remove CONFIG_DEVTMPFS{,_MOUNT} from kconfigs

2022-01-05 Thread Rui Salvaterra
They are required for container support, but are handled in Config-kernel.in. Signed-off-by: Rui Salvaterra --- target/linux/archs38/config-5.10 | 1 - target/linux/generic/config-5.10 | 2 -- target/linux/layerscape/armv7/config-5.10 | 2 -- target/linux

Re: [firewall3 PATCH] firewall3: support async table init in 5.15+ kernel

2022-01-07 Thread Rui Salvaterra
continue; > + > + fw3_ipt_close(handle); > + } > + > for (table = FW3_TABLE_FILTER; table <= FW3_TABLE_RAW; > table++) > { >

Re: [PATCH] options.c: add DSCP code LE Least Effort

2022-01-08 Thread Rui Salvaterra
Hi, Kevin, On Sat, 8 Jan 2022 at 15:38, Kevin Darbyshire-Bryant via openwrt-devel wrote: > > Signed-off-by: Kevin Darbyshire-Bryant > --- > options.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/options.c b/options.c > index 6131786..2f419a3 100644 > --- a/options.c > +++ b/options.

Re: [PATCH v2] options.c: add DSCP code LE Least Effort

2022-01-08 Thread Rui Salvaterra
00 }, > + { "LE", 0x01 }, > { "AF11", 0x0a }, > { "AF12", 0x0c }, > { "AF13", 0x0e }, > -- > 2.32.0 (Apple Git-132) > Seems sensible to me. Nice description, and bonus points for the RFC reference. :) Reviewed-by: Rui Salvaterra Thanks, Rui ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH] firewall3: don't cater to old iptables

2022-01-09 Thread Rui Salvaterra
It's been eight years, we can safely assume iptables is recent enough. Signed-off-by: Rui Salvaterra --- This has obviously been build/run-tested without any issues whatsoever. Even though firewall3 isn't a priority, this is a nice cleanup in itself. iptables.c

Re: [PATCH] procd: mount /dev with noexec

2022-01-09 Thread Rui Salvaterra
On Wed, 5 Jan 2022 at 15:24, Rui Salvaterra wrote: > > /dev is writeable. Allowing execution inside it makes it a possible attack Bah. I just noticed a typo in the commit message. I also have a /dev/pts mount cleanup queued, so I'll resend as a series of

[PATCH 0/2] procd: a couple of mount fixes

2022-01-09 Thread Rui Salvaterra
Fix a potential security issue in the way /dev is mounted. Clean up the /dev/pts mounts while at it. Rui Salvaterra (2): procd: mount /dev with noexec procd: clean up /dev/pts mounts initd/early.c | 4 ++-- plug/coldplug.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions

[PATCH 1/2] procd: mount /dev with noexec

2022-01-09 Thread Rui Salvaterra
ority of our targets doesn't have a GPU, anyway. :) [1] https://lore.kernel.org/all/YcMfDOyrg647RCmd@debian-BULLSEYE-live-builder-AMD64/ [2] https://lore.kernel.org/all/CAPXgP12e5LpN6XVxaXOHhH=u8XXN==2retajdcock4tp4qd...@mail.gmail.com/ Signed-off-by: Rui Salvaterra --- initd/early.c | 2 +-

[PATCH 2/2] procd: clean up /dev/pts mounts

2022-01-09 Thread Rui Salvaterra
The default mode is already 600, no need to specify it. Access times are also irrelevant. Signed-off-by: Rui Salvaterra --- initd/early.c | 2 +- plug/coldplug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/initd/early.c b/initd/early.c index 87fee65..4b7e61c 100644

<    1   2   3   4   >