Re: x86/64 SDK segfaults on some hosts [Was: Re: [PATCH 1/2] fakeroot: make fakeroot script relocatable]

2020-11-09 Thread Jo-Philipp Wich
Hi, > it seems like mixing dynamic loader from the host and libraries from SDK > doesn't work reliably in all cases and may result in crash. Yes, that is why we wrap the SDK executables to forcibly invoke them through the bundled loader. Attempting to use SDK executables or librries with the hos

Re: [PATCH] rpcd: Add support for plugin command input via argv[3] ($3)

2020-11-11 Thread Jo-Philipp Wich
Hi, the request payload can theoretically become very big, something in the few hundred kilobyte to one megabyte ballpark. I am not sure if it is a good idea to pass that via the argv vector. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.open

Re: Upcoming 19.07.4 and 18.07.9 stable releases

2020-11-14 Thread Jo-Philipp Wich
Hi, > Are there any real blockers left? LuCI support for bridge-vlan config is unmerged/unpolished yet. I'd rather not ship 20.x without functioning switch config support in the ui. ~ Jo signature.asc Description: OpenPGP digital signature ___ open

Re: [PATCH v4] build: create $(PKG_SYMVERS_DIR) if non-existent

2020-11-19 Thread Jo-Philipp Wich
Hi Sebastian, thanks for following up with a v4. I merged this change in https://git.openwrt.org/2127accd441b1c979c8f3f56f3ad5264542e185a now. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinf

Download server downtime

2020-11-24 Thread Jo-Philipp Wich
int to our mirrors [1] which you can use to download OpenWrt binaries in case the main download server is unavailable. Please excuse the inconvenience and troubles caused. Kind regards, Jo-Philipp Wich 1: https://openwrt.org/downloads#mirrors ___ ope

Re: [PATCH] openvpn: update to 2.5.0

2020-11-30 Thread Jo-Philipp Wich
Hi, [...] > @@ -137,6 +143,7 @@ allow_recursive_routing > auth_nocache > auth_user_pass_optional > bind > +block-ipv6 I suppose this needs to be `block_ipv6` ? > ccd_exclusive > client > client_to_client > @@ -185,10 +192,13 @@ tls_server > up_delay > up_restart > username_as_common_nam

Re: [PATCH] netifd: add segment routing support

2020-12-02 Thread Jo-Philipp Wich
Hi, the chosen option name does not really fit other existing bool options which do not use an enable(d) or disable(d) prefix/suffix. I'd call the new option simply `seg6` or even better `ip6segmentrouting` to fall in line with other IPv6 specific options [1] ~ Jo 1: https://lxr.openwrt.org/sou

Re: [PATCH] ltq-dsl-base: only lock the dsl pipe once for all stats

2020-12-04 Thread Jo-Philipp Wich
Hi, is there any reason not to use the flock style below? It should be more reliable wrt. unlocking if the script is prematurely terminated. -- 8< -- { flock -x 1000 command command command ... } 1000>/var/lock/dsl_pipe -- >8 -- See also the fourth example at

Re: Lightweight policy-based routing

2020-12-04 Thread Jo-Philipp Wich
Hi Philip, ip rules are possible in uci, but not sure if all the bits you require are covered: https://openwrt.org/docs/guide-user/network/ucicheatsheet#ip_rules_for_both_rule_and_rule6 `config route` sections allow specifying `option table` as well to stage the routes in the non-main rttable.

Merged: ipsets: allow blank/commented lines withloadfile

2020-12-06 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Merged: firewall3: fix duplicate defaults section detection

2020-12-06 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics

2020-12-11 Thread Jo-Philipp Wich
Hi, > This is significantly faster. great work! I like it :) Minor nitpick below. > [...] > -var callLuciDSLStatus = rpc.declare({ > - object: 'luci-rpc', > - method: 'getDSLStatus', > +var call_dsl_metrics = rpc.declare({ > + object: 'dsl', > + method: 'metrics', > exp

Re: [PATCH] uhttpd: don't redirect to HTTPS by default

2020-12-14 Thread Jo-Philipp Wich
Hi, > So we can ship px5g-wolfssl by default in the release image, but still > make the HTTPS for LuCI optional. This small change with addition of > `CONFIG_PACKAGE_px5g-wolfssl=y` into the buildbot's seed config for the > next release should provide optional HTTPS in the next release. please no

Merged: libnetfilter-conntrack: update to 1.0.8

2020-12-14 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH 1/2 iwinfo] iwinfo: add support for GCMP cipher

2021-01-05 Thread Jo-Philipp Wich
Hi, before merging this, please extend the cmake rules in iwinfo.git to add a SOVERSION property to the resulting libiwinfo library, this way we can adopt ABI versio ntracking when we bump it the next time in OpenWrt. ~ Jo signature.asc Description: OpenPGP digital signature __

Re: [IWINFO PATCH v4 1/4] iwinfo: export ht and vht operation in scan results

2021-01-05 Thread Jo-Philipp Wich
Hi, comments inline below. > [...]@@ -2306,6 +2306,16 @@ static void nl80211_get_scanlist_ie(struct nlattr > **bss, > iwinfo_parse_rsn(&e->crypto, ie + 6, ie[1] - 4, >IWINFO_CIPHER_TKIP, > IWINFO_KMGMT_PSK); >

Re: [IWINFO PATCH v4 2/4] iwinfo: export center_chan info for local wifi

2021-01-05 Thread Jo-Philipp Wich
Hi, comments below. > [...] > diff --git a/include/iwinfo.h b/include/iwinfo.h > index 676db91..680f384 100644 > --- a/include/iwinfo.h > +++ b/include/iwinfo.h > @@ -282,6 +282,8 @@ struct iwinfo_ops { > int (*survey)(const char *, char *, int *); > int (*lookup_phy)(const char *, ch

Re: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

2021-01-05 Thread Jo-Philipp Wich
Hi, comments below. > [...] > @@ -441,6 +441,20 @@ rpc_iwinfo_scan(struct ubus_context *ctx, struct > ubus_object *obj, > blobmsg_add_u32(&buf, "quality", e->quality); > blobmsg_add_u32(&buf, "quality_max", e->quality_max); > Only add the "ht_operat

Re: [RPCD PATCH v4 4/4] iwinfo: export center channel for info ubus call

2021-01-05 Thread Jo-Philipp Wich
Hi, comment below. > [...] > diff --git a/iwinfo.c b/iwinfo.c > index 45ca784..94fa822 100644 > --- a/iwinfo.c > +++ b/iwinfo.c > @@ -364,6 +364,8 @@ rpc_iwinfo_info(struct ubus_context *ctx, struct > ubus_object *obj, > > rpc_iwinfo_call_int("mode", iw->mode, IWINFO_OPMODE_NAMES); >

Re: R: [RPCD PATCH v4 3/4] iwinfo: add ht and vht operation info to wifi scan

2021-01-06 Thread Jo-Philipp Wich
Hi, > I didn't add the check here as we can assume that ht_operation are always > present. > Should I add this anyway? why can we assume it? They way I see it, HT info is only populated if IE type 61 was present, valid and parsed from BSS info, otherwise the structure mightr be present but zero

Re: [PATCH 1/3] rules: add commitcount function

2021-01-07 Thread Jo-Philipp Wich
Hi, I think this change will introduce massive overhead during the DUMP phase of the buildroot when scanning package metadata. You should wrap the logic into an `ifneq ($(DUMP),1)` or similar and simply return a static placeholder value if DUMP==1 ~ Jo signature.asc Description: OpenPGP digit

Re: [PATCH] wireguard-tools: allow generating private_key

2021-01-08 Thread Jo-Philipp Wich
Hi, I'm afraid this approach is not really acceptable. Automatically calling `uci commit` outside of the early-boot / uci-defaults context is not safe. There could be arbitrary user defined, intentionally uncommitted changes stashed when the ifup sequence is running which you would inadvertently

Re: Add package version dependency for point releases

2021-01-11 Thread Jo-Philipp Wich
Hi, why not simply wrap the workaround in a uname or /proc/version check? ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-deve

Re: Dnsmasq 2.83 causes log spam

2021-01-22 Thread Jo-Philipp Wich
Hi Hannu, unfortunately we lack a reliable reproducer so far. A packet capture would be most helpful, another option would be a bisect of the intermediate dnsmasq Git revisions. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-d

Re: Job board support on openwrt.org?

2021-01-23 Thread Jo-Philipp Wich
Hi, I don't think this is a good idea due to legal obligations, administrative hassle, quality of work issues and so on. NACK from me. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openw

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Jo-Philipp Wich
Hi, > The goal of reducing unnecessary build churn makes perfect sense to me, > but I think we need to reconsider the trade-off we're making here, and > the failure modes of each option. the motivation wasn't about build-churn at all but to ensure that library packages can be cleanly upgraded and

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Jo-Philipp Wich
Hi, > The last stable update didn't change SONAME, but it included changes to > the same data structure that triggered the bug that I ran into. It could > very likely have introduced very similar subtle breakage. this is a clear upstream bug then. Might make sense to look into how other distribut

Re: Question about LuCI state (incl DSA) & request for testing

2021-02-12 Thread Jo-Philipp Wich
Hi, > I'd like to ask: what's the current state of LuCI? > One thing that probably requires some extra focus is DSA. Are there > any remaining issues regarding it? some parts of the DSA/device config code are intentionally disabled since netifd didn't handle these things at the time it was writte

Re: [PATCH 1/2] uhttpd: Reload config after uhttpd-mod-ubus was added

2021-03-20 Thread Jo-Philipp Wich
Hi Hauke, thanks for looking into it! I have a couple of remarks... > [...] > [ "$(uci -q get uhttpd.main.ubus_socket)" = "/var/run/ubus.sock" ] && { > uci set uhttpd.main.ubus_socket='/var/run/ubus/ubus.sock' > uci commit uhttpd > + reload_config That might reload other, unrel

Merged: zone: avoid duplicates in devices list

2021-03-23 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Merged: rules: fix device and chain usage forDSCP/MARK targets

2021-03-23 Thread Jo-Philipp Wich
Merged into project/firewall3.git, branch master at http://git.openwrt.org/?p=project/firewall3.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] uhttpd / startup-error without a message

2015-05-11 Thread Jo-Philipp Wich
Hi, this is already fixed in trunk. The uhttpd stderr is relayed to syslog there. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] uhttpd / startup-error without a message

2015-05-11 Thread Jo-Philipp Wich
Hi. > thank you - i see: > this is not very intuitive. can this be send to console > when user is interactive? (like: loggger -s message) Not easily as it is procd logging the services stderr. One can implement a "test" or "debug" start action though which would calculate the commandline and star

Re: [OpenWrt-Devel] uhttpd / startup-error without a message / procd interactive logging

2015-05-11 Thread Jo-Philipp Wich
> it think thats too special - there should be a generic way to > get direct feedback on the commandline when something fails without > doing magic. what if we e.g. 'export INTERACTIVE=1' via /etc/profile > so procd / a called script is aware of this? Whats too special with "/etc/init.d/$SERVICE d

Re: [OpenWrt-Devel] working with quilt from './staging_dir/host/bin/quilt'

2015-05-21 Thread Jo-Philipp Wich
Hi. Did you try something like export PATH="$PATH:/home/bastian/openwrt/staging_dir/host/bin" ? If that works you could add it to your .bashrc ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailm

Re: [OpenWrt-Devel] working with quilt from './staging_dir/host/bin/quilt'

2015-05-21 Thread Jo-Philipp Wich
Hi. > meanwhile yes, but it does not work like i exspected. > should'nt quilt open, when a patch cannot be applied cleanly? Uhm no. At least I never encountered such behavior. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https:/

Re: [OpenWrt-Devel] working with quilt from './staging_dir/host/bin/quilt'

2015-05-21 Thread Jo-Philipp Wich
> my idea was to use this: > make target/linux/{clean,prepare} V=s QUILT=1 If the patches all apply despite fuzz: make target/linux/refresh If they do not apply: make target/linux/{clean,prepare} V=s QUILT=1 cd build_dir/target-*/linux-*/linux-* quilt push -a (will halt before the failing patc

Re: [OpenWrt-Devel] Link detection - TP-Link Archer C7 v2

2015-05-27 Thread Jo-Philipp Wich
Hi Richard, the link status is not propagated to the netdev because there's an external switch chip between the CPU and the RJ45 plug on the outside. There currently is no mechanism to propagate switch port states to Linux netdev link states as such an mechanism has various implications. For exa

Re: [OpenWrt-Devel] [PATCH v2] [kernel] upstream fix: mount overlayfs r/o if workdir cannot be created

2015-05-27 Thread Jo-Philipp Wich
Hi, patch is fine with me however there's a typo in the error message: "failed to work directory" This should get corrected (and upstream notified about it as well). ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.o

Re: [OpenWrt-Devel] [PATCH v2] [kernel] upstream fix: mount overlayfs r/o if workdir cannot be created

2015-05-27 Thread Jo-Philipp Wich
Hi. > e.g. 'failed to create work directory'? Yeah, I assume that was the intended meaning of the message. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v3] [kernel] upstream fix: mount overlayfs r/o if workdir cannot be created

2015-05-27 Thread Jo-Philipp Wich
ar71xx with kernel 3.18.11 and r45772 > this paritially fixes #19564 > > Signed-off-by: Bastian Bittorf Acked-by: Jo-Philipp Wich > --- > ...-overlayfs-fallback-to-readonly-when-full.patch | 109 > > 1 file changed, 109 insertions(+) > create mode 1006

Re: [OpenWrt-Devel] [PATCH] Add sch_fq and sch_pie to the kmod-sched package.

2015-06-03 Thread Jo-Philipp Wich
Hi, > The .ipk goes from 46018 to 52793 bytes. Can't seem to get the image > size to change, probably some issue with my build setup... The image is padded to whole eraseblocks, so if the squashfs size does not change then the added code fits into the remaining space of an eraseblock. ~ Jow s

Re: [OpenWrt-Devel] netifd: handling of interfaces with proto "none"

2015-06-08 Thread Jo-Philipp Wich
Hi Lars, I struggled with this issue as well and after a brief chat with nbd the conclusion was to force the tap device to be "external", this will cause netifd to leave its routes and address config alone, even when ifup is called on the network. In short you need to prepare the vpn interface

Re: [OpenWrt-Devel] x86_64 packages missing

2015-06-10 Thread Jo-Philipp Wich
Hi, the 64 target is now a subtarget of x86, so you can find those packages here: https://downloads.openwrt.org/snapshots/trunk/x86/64/packages/ Basically replace "x86_64" with "x86/64" in your opkg.conf HTH, Jow ___ openwrt-devel mailing list openwr

Re: [OpenWrt-Devel] Method to load firmware blob for a particular router model

2015-06-14 Thread Jo-Philipp Wich
Hi, > So how do I write a firmware blob into /lib/firmware into the build > process without the hassle of creating a metapackage? $ mkdir -p files/lib/firmware $ wget -O files/lib/firmware/blah.bin http://example.org/blah.bin $ make Or do you mean how to integrate it into the repository? In that

Re: [OpenWrt-Devel] [PATCH] libusb-compat: fix build with musl

2015-06-17 Thread Jo-Philipp Wich
Hi Álvaro, hmm, I have no issues building it under musl here. The buildbots seems to report no errors either. Can you provide a diffconfig.sh output? Btw, you do not need to replace all types, u_int{8,16,32,64}_t is exposed by musl if you include *and* if _GNU_SOURCE is defined. ~ Jow signa

Re: [OpenWrt-Devel] [PATCH] libusb-compat: fix build with musl

2015-06-18 Thread Jo-Philipp Wich
Hi Álvaro, I see. The proper place to fix it is flashrom, it needs to include before including libusb headers and its Makefile needs to define -D_GNU_SOURCE or -std=gnu99 Regards, Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org http

Re: [OpenWrt-Devel] [PATCH procd] service: use PTY (instead of a pipe) for reading service output

2015-06-19 Thread Jo-Philipp Wich
Hi. > Do you have any other idea? Yes, we create a shared library which calls setbuf(stderr/out, NULL) in an __attribute__((constructor)) function, then specify this library in LD_PRELOAD when exec'ing stdio-relay enabled processes from procd. This is equivalent to the implementation used by the

Re: [OpenWrt-Devel] [PATCH procd] service: start apps with LD_PRELOAD & lib disabling buffering

2015-06-20 Thread Jo-Philipp Wich
Hi John, > i dont like this idea at all. calling ld-preload on every started app > just seems wrong I was the one suggesting the idea since we needed a solution which does not require modification of downstream programs. We could restrict the preloading to programs which requested stdio relaying

Re: [OpenWrt-Devel] [PATCH] [package] strace: update to 4.10

2015-06-25 Thread Jo-Philipp Wich
Applied in r46124 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2] [package] grub2: disable stack-protector

2015-06-25 Thread Jo-Philipp Wich
Applied in r46126 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] [package] grub2: fix musl build

2015-06-25 Thread Jo-Philipp Wich
Hi Dirk, I committed a different approach that basically turns the __GLIBC__ guards into !__UCLIBC__ ones. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] iwinfo lua scanlist issue

2015-06-29 Thread Jo-Philipp Wich
Hi Peter, I suspect the culprit is nl80211_wait() which calls nl_recvmsgs() internally. To overcome this problem we need to restructure the nl80211 code to use nonblocking sockets and then extend the nl80211_wait() implementation to have a timeout. ~ Jow _

Re: [OpenWrt-Devel] iwinfo lua scanlist issue

2015-06-29 Thread Jo-Philipp Wich
Not really as the core issue is always within the same C code, however you access it. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] 14.07 SDK - iostream.h not found

2015-07-03 Thread Jo-Philipp Wich
Hi, this has been fixed with r46162. The SDK releases for 15.05-rc1 and 15.05-rc2 are affected as well. To solve the problem locally you can apply the following sed command: sed -i -e 's!/[^ ]*/staging_dir/[^/]*/!$STAGING_DIR/!g' \ staging_dir/toolchain-*/bin/g++-uc* ~ Jow __

Re: [OpenWrt-Devel] Chaos Calmer 15.05 package build failures in SDK

2015-07-17 Thread Jo-Philipp Wich
Hi Daniel, please test whether the following patch solves the shared library problem: ~ Jow -- diff --git a/include/toplevel.mk b/include/toplevel.mk index bbeb7eb..11b2dd9 100644 --- a/include/toplevel.mk +++ b/include/toplevel.mk @@ -24,8 +24,8 @@ OPENWRTVERSION:=$(RELEASE)$(if $(REVISION), ($

Re: [OpenWrt-Devel] [PATCH 2/2] tools/quilt: fix build error during kernel_menuconfig on a cleaned env

2015-07-22 Thread Jo-Philipp Wich
Hi, this was originally done to fix quilt in the SDK. Did you test it there after your change? ~ Jow signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin

Re: [OpenWrt-Devel] [PATCH] Workaround: saved administration site user and pass may appear on the Wireless configuration page, replacing the WPA key

2015-07-27 Thread Jo-Philipp Wich
Applied to master and for-15.05 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] Allow editing of AP channel when all client networks are disabled

2015-07-27 Thread Jo-Philipp Wich
Applied to master and for-15.05 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] Fix: Status for disabled wireless networks may display the SSID, BSSID and Mode of an active network on the same radio

2015-07-27 Thread Jo-Philipp Wich
Applied to master and for-15.05 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] Fix: A disabled wireless network may be shown as enabled, when multiple networks are defined on the same radio

2015-07-27 Thread Jo-Philipp Wich
Applied to master and for-15.05 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] ar71xx: RB435G PCI does not support minipci sata module (PER-C20S)

2015-08-17 Thread Jo-Philipp Wich
Hi. > Is the PCI subsystem on this board supported only for wireless cards? Yes. The hardware controller cannot handle PCI I/O resources, therefore only a subset of available miniPCI cards do work with it. Anything requiring I/O resources is a no-go. HTH, Jow ___

Re: [OpenWrt-Devel] Ubus request through AJAX issue

2015-09-01 Thread Jo-Philipp Wich
Hi, the number 2 corresponds to "UBUS_STATUS_INVALID_ARGUMENT" so your AJAX call is submitting invalid data. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v4] base-files: add /etc/profile.d support

2015-09-04 Thread Jo-Philipp Wich
Hi. > Why the -e? You only got existing files in the glob above right? Almost. If the directory does not exist or is empty then the glob pattern is returned literally, e.g. "echo /tmp/*" will expand to a list of files but "echo /does_not_exist/*" will return "/does_not_exist/*" literaly so the

Re: [OpenWrt-Devel] [PATCH][RFC] x86: Save and restore partition table during upgrade

2016-01-17 Thread Jo-Philipp Wich
Hi. > This patch will save the partition table before an upgrade. > If the installed image has not changed the partition structure > the saved table will be restored, ensuring any user created > partitions will be present after the upgrade. That sounds odd. If I'd start to rely on such a feature

Re: [OpenWrt-Devel] [PATCH 1/1] package/libs/libiconv: function names

2016-01-18 Thread Jo-Philipp Wich
Applied in r48301 - thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH][package] Allow UCI dhcp classifier to accept a list of MAC

2016-01-18 Thread Jo-Philipp Wich
Hi. The change is fine with me but shouldn't we keep checking whether there's at least one mac given? ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 1/4] base-files: add option to specify netdev led mode in configuration generation

2016-01-19 Thread Jo-Philipp Wich
Hi, see inline comments. ~ Jow On 01/07/2016 01:40 AM, Tal Keren wrote: > This is necessary for controlling leds of RJ45 port, when one indicate the > link > status and the other indicate data transfer. > > Signed-off-by: Tal Keren > --- > package/base-files/files/bin/config_generate

Re: [OpenWrt-Devel] [PATCH 1/4] base-files: add option to specify netdev led mode in configuration generation

2016-01-19 Thread Jo-Philipp Wich
Hi, thought some more about it and we want to have the proper defaults in board.json already, therefore disregard my previous comments and stick to the ones below. Sorry for the bikeshedding here. Thanks, Jow > On 01/07/2016 01:40 AM, Tal Keren wrote: >> This is necessary for controlling leds of

Re: [OpenWrt-Devel] Question about custom script at init on Trunk.-

2016-01-27 Thread Jo-Philipp Wich
Hi, > So, /etc/uci-defaults/z999-something works, but is there a > better way? Not yet - but we could start changing packages to use numerical prefixes. I do not suppose that sooo many uci-default scripts are used. ~ Jow ___ openwrt-devel mailing l

Re: [OpenWrt-Devel] Native IPv6 Broken in recent trunk

2016-02-09 Thread Jo-Philipp Wich
Hi. > config interface 'lan' > option force_link '1' > option type 'bridge' > option proto 'static' > option netmask '255.255.255.0' > option ip6assign '64' > option dns 'x' > option ipaddr '172.18.18.1' > option _orig_ifn

Re: [OpenWrt-Devel] Plans for CC 15.05.1 or DD 16.xx release?

2016-02-10 Thread Jo-Philipp Wich
The release will be delayed due to infrastructure problems. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 3/4] uci: add support for speed_mask to switch LED init scripts

2016-02-12 Thread Jo-Philipp Wich
Hi. > switch) > - local port_mask > - json_get_vars port_mask > + local port_mask speed_mask > + json_get_vars port_mask speed_mask > uci -q batch <<-EOF >

Re: [OpenWrt-Devel] uci_lookup_ptr() seg fault

2016-02-17 Thread Jo-Philipp Wich
Hi. > I am getting seg fault sometimes on the uci_lookup_ptr() call. here is > the way I call this function: > It happens I would say once every couple of hundred calls. My gut feeling is that one of the "file_name", "section_name", "section_value" or "option_name" pointers becomes stale. Your qu

Re: [OpenWrt-Devel] Setting uci defaults in trunk

2016-02-26 Thread Jo-Philipp Wich
Hi. > In r48800 this file seems to have been replaced by > /etc/board.d/02_network instead. Unfortunately "raw" uci commands does > not work since its generating /etc/board.json instead? Am I correct? > > If I do this then "dhcp" is ignored and the interface is set to static > anyway: > ucidef_se

Re: [OpenWrt-Devel] Read-only mirror https://github.com/openwrt/openwrt is stuck since 12 days ago

2016-03-08 Thread Jo-Philipp Wich
Hi. > Not to pile on, but is there any way to have the commit hashes on github > match those at openwrt.org (e.g., a true mirror)? No. We'll make the openwrt.git on github available as git.openwrt.org/source.git eventually but git.openwrt.org/openwrt.git will stay as-is. ~ Jow __

Re: [OpenWrt-Devel] [PATCH 1/5] [package] iptables: Disable IPv6 support

2016-03-08 Thread Jo-Philipp Wich
Hi, your change makes no sense, the logic is the very same. It is possible that yours is not even working and will now always disable IPv6, even if its actually enable. I believe the actual problem is that CONFIG_IPV6 refers to the kernel config symbol here, not to the one from our build .config

Re: [OpenWrt-Devel] downloads.openwrt.org

2016-03-08 Thread Jo-Philipp Wich
Failed builds, stay tuned. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Question regarding call python script

2016-03-10 Thread Jo-Philipp Wich
Hi Jason, no reason against it per se but it would introduce a new build prereq I suppose. If possible we'd like to stick to things we already require (perl, awk, shell). Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https:

Re: [OpenWrt-Devel] [PATCH v3] ipvs: Linux IP Virtual Server kernel modules (netfilter.mk patch)

2016-03-11 Thread Jo-Philipp Wich
Hi, seems that change fails all builds now due to undeclared symbols: * * IPVS application helper * FTP protocol helper (IP_VS_FTP) [N/m/?] (NEW) aborted! Please fix. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https:

Re: [OpenWrt-Devel] [PATCH netifd] alias : Fix interface aliased on top of a static interface not getting active

2016-03-31 Thread Jo-Philipp Wich
Hi Hans, pushed into netifd.git, thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 1/2] dnsmasq: Fix dhcp option parsing

2016-03-31 Thread Jo-Philipp Wich
Hi, various configurations out there use "option dhcp_option ..." still, did you check whether this works yet after your patch? ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openw

Re: [OpenWrt-Devel] [PATCH 2/3] [rpcd] file: handle return output of b64_decode

2016-04-11 Thread Jo-Philipp Wich
Hi Luka, Please use ssize_t instead. Regards, Jo > Am 11.04.2016 um 18:56 schrieb Luka Perkov : > > Solve this compile warning: > > file.c:300:16: error: comparison of unsigned expression < 0 is always false > [-Werror,-Wtautological-compare] >if (data_len < 0) > > Signed-off

Re: [OpenWrt-Devel] rsync mirror of download.openwrt.org ?

2016-04-12 Thread Jo-Philipp Wich
Hi Daniel, the entire downloads.openwrt.org is around 720GB while the 15.05.1 release is 36GB in total. Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] rsync mirror of download.openwrt.org ?

2016-04-12 Thread Jo-Philipp Wich
Hi Dape, you need to ask Kaloz to setup rsync access for you I guess. Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [UCI] uci import -m duplicates list options

2016-04-15 Thread Jo-Philipp Wich
Hi. Just truncate the destination file beforehand. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] upstream opkg

2016-04-21 Thread Jo-Philipp Wich
Hi, Yocto made opkg unusable for us. Current upstream is *far* too big for use in OpenWrt. The now required libarchive alone is larger than our current opkg version. I took a look at packaging current opkg a while back and got stuck at bringing libarchive down to a sane size, therfor I gave up on

Re: [OpenWrt-Devel] [PATCH 01/??] [tools] make-ext4fs glibc >= 2.23 compat

2016-04-25 Thread Jo-Philipp Wich
Hi! Thanks for the patch, I fixed the include issue directly in Git, so this patch can be dropped and make-ext4fs should be updated in tools/ to a newer version instead. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.o

Re: [OpenWrt-Devel] [PATCH 01/??] [tools] make-ext4fs glibc >= 2.23 compat

2016-04-25 Thread Jo-Philipp Wich
Hi, no, I only cared about make-ext4fs as I maintain this fork. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 02/05] [tools] findutils glibc >= 2.23 compat

2016-04-25 Thread Jo-Philipp Wich
Hi, this should be handled already, configure uses AC_HEADER_MAJOR and mountlist.c does: #ifdef MAJOR_IN_SYSMACROS #include #define HAVE_MAJOR ... did you patched findutils proactively or was there an actual build issue? ~ Jo ___ openwrt-devel mailin

Re: [OpenWrt-Devel] [PATCH] [firewall3] defaults.c: remove toplevel_rule struct

2016-04-26 Thread Jo-Philipp Wich
Hi Alexandru, pushed to master - thanks! ~ Jo On 27.04.2016 08:16, Alexandru Ardelean wrote: > From: Alexandru Ardelean > > Since commit 60f1444 , this struct is no longer used. > > Signed-off-by: Alexandru Ardelean > --- > defaults.c | 7 --- > 1 file changed, 7 deletions(-) > > diff

Re: [OpenWrt-Devel] [PATCH v2 1/6] netifd: Make sending DHCP release configurable via uci when client exits

2016-04-28 Thread Jo-Philipp Wich
Hi, I assume this one supersedes "netifd: Send DHCP release when client exits" ? Asking because I see no deletion of the "-R" option which would be introduced by the other patch. If this is the case can you slightly reword it to "Add configurable DHCP release behaviour" or something? Sorry for

Re: [OpenWrt-Devel] [PATCH] set mark for locally generated traffic in OUTPUT chain

2016-04-28 Thread Jo-Philipp Wich
Hi Daniel, my stomach feeling tells me that this is okay but can you elaborate on the change? ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] set mark for locally generated traffic in OUTPUT chain

2016-04-28 Thread Jo-Philipp Wich
Hi Daniel, thanks for the explaination, I was missing the function context. The change is indeed fine, pushed to firewall3.git - thanks! ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listi

Re: [OpenWrt-Devel] [PATCH] firewall3: Fix multicast ICMPv6 replies not being sent by default anymore.

2016-05-02 Thread Jo-Philipp Wich
Hi Vittorio, can you move the "mcdst" declaration to the top of the function? ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] load running state after lock is acquired

2016-05-02 Thread Jo-Philipp Wich
Hi Alin, thanks! Pushed to firewall3.git. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Introducing the LEDE project

2016-05-03 Thread Jo-Philipp Wich
d testing combined with a simplified release process If you're interested in participating or want to learn more about the project, check out https://www.lede-project.org/. Sincerely, Jo-Philipp Wich, John Crispin, Daniel Golle, Felix Fietkau, Hauke Mehrtens John Crispin Ma

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] conntrack: enable support for netfilter conntrack zones

2016-05-19 Thread Jo-Philipp Wich
Hi Alin, I merged your patch into my staging tree at https://git.lede-project.org/?p=lede/jow/staging.git;a=commitdiff;h=6c9231baa9c5341c6ee2e213618dcde72d42288b Since your change lacked a proper Signed-off-by I added it on your behalf. Please review the link above and give me your ACK, then I'l

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-19 Thread Jo-Philipp Wich
Hi Hans, staged into https://git.lede-project.org/?p=lede/jow/staging.git A few improvement ideas though; - maybe we can make the jsonfilter dependency conditionally depending on the ntpd applet - maybe pipe the ubus interface status dump directly to jsonfilter - is there any reason to not

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Jo-Philipp Wich
Hi Hans, > I wanted to preserve the ntp server behavior and only change the > behavior when configured in order to keep backwards compatibility. You > favour enabling DHCP ntp server config without explicit config ? Personally I do because thats likely what most users expect, but then trusting fo

  1   2   3   4   5   6   7   8   9   10   >