Re: [OpenWrt-Devel] [PROPOSAL] move OpenWrt codebase to Git and GitHub

2016-05-24 Thread Jo-Philipp Wich
Hi Luka, this is fantastic news! I'd be very interested in your future progress on the CI front. If drone.io is able to accommodate the resources required for building the entire OpenWrt then it sounds like a good solution for other projects too. Regards, Jo

Re: [OpenWrt-Devel] [OpenWrt-Users] [PROPOSAL] move OpenWrt codebase to Git and GitHub

2016-05-24 Thread Jo-Philipp Wich
Hi, here's a few numbers we gathered with our buildbot setup: We currently need roughly 35GB per target when building OpenWrt plus the entire package world and currently there are roughly ~70 target/subtarget combinations in the OpenWrt tree. If fast build tests are desired then the only way to

Re: [OpenWrt-Devel] [OT] Implemented: not an ML erase button but at least a rethink switch

2016-05-26 Thread Jo-Philipp Wich
Hi Daniel, hope you're doing well nowadays. I sincerely appreciate your participation in the discussions surrounding the whole OpenWrt/LEDE topic especially since it helps giving another, outside perspective to the entire issue. What I noticed is that you're sometimes generating like 80% of the

Re: [OpenWrt-Devel] OpenWrt / LEDE

2016-05-26 Thread Jo-Philipp Wich
Hi all, I think the status quo has now been described several times and can be summarized as: - Launching the new LEDE project/fork/reboot without discussing matters in advance with the developers not being involved was perceived in a hostile action damaging OpenWrt - It has been claimed

Re: [OpenWrt-Devel] OpenWrt / LEDE

2016-05-26 Thread Jo-Philipp Wich
Dear Kathy, > I appreciate your well-written summary and the notable improvements. > Moving to git and keeping history, improving the web site and > documentation to enable more collaboration, making workflows more > efficient and open, etc. had been discussed during face-to-face > gatherings of O

Re: [OpenWrt-Devel] [PATCH] [rpcd] iwinfo: zero out ccode buffer since library doesn't

2016-06-05 Thread Jo-Philipp Wich
Pushed to rpcd.git, thanks Denis. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

2016-06-21 Thread Jo-Philipp Wich
Hi, first of all, thanks for putting work into that - I like the changes in general. Have a few comments inline below. ~ Jo > Consistently handle allocation failures. Some functions are changed to > return bool instead of void to allow returning an error. > > Also fix a buffer size miscalculati

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH libubox 2/3] loop: make uloop_run() return the cancelling signal

2016-06-21 Thread Jo-Philipp Wich
ion against the other is > not possible. > > [1] https://www.cons.org/cracauer/sigint.html > > Signed-off-by: Matthias Schiffer Acked-by: Jo-Philipp Wich > --- > uloop.c | 14 -- > uloop.h | 6 +++--- > 2 files changed, 11 insertions(+), 9 deletions(-) >

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH libubox 3/3] blobmsg_json: add new functions blobmsg_format_json_value*

2016-06-21 Thread Jo-Philipp Wich
JSON object). > > To avoid breaking software relying on this behaviour, introduce new > functions which will never print the blob_attr name and thus always > produce valid JSON. > > Signed-off-by: Matthias Schiffer Acked-by: Jo-Ph

Re: [OpenWrt-Devel] Response to LEDE proposal/queries/mail?

2016-06-27 Thread Jo-Philipp Wich
Hi Zoltan, we started a discussion on OpenWrt re-merge conditions over at lede-dev and waited for a while to solicit more feedback. Since no other people expressed further wishes and since you repeatedly asked for a list of things the LEDE folks would like to see in OpenWrt I'm going to summarize

Re: [OpenWrt-Devel] Response to LEDE proposal/queries/mail?

2016-06-27 Thread Jo-Philipp Wich
Hi Mike, given sufficient and reasonable agreements I am certainly willing to help implementing our desired changes. Regards, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-de

Re: [OpenWrt-Devel] [RFD] Future

2016-06-29 Thread Jo-Philipp Wich
Hi Imre, can you provide a summary of the discussion? Thank you, Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] LuaJIT Vs Lua and other questions

2016-06-29 Thread Jo-Philipp Wich
Hi Anton, > First I've tried to name package as "luajit" and add CONFLICTS:=lua > (version should be provided to conflict with) and PROVIDES:=lua > variables like for RPM to make a replacement package, but I get a > dependency loop. Therefore, I name produceable packages "lua" and > "liblua". The

Re: [OpenWrt-Devel] Support for callable metatable for ubus-lua

2016-06-29 Thread Jo-Philipp Wich
Hi Anton, personally I do not like peeking into foreign objects meta tables just to find out whether they're callable. Maybe we should simply stop checking the type entirely and instead rely on lua_pcall() to deal with non-callables and other runtime errors. What do you think? ~ Jo _

Re: [OpenWrt-Devel] LuaJIT Vs Lua and other questions

2016-06-30 Thread Jo-Philipp Wich
Hi Anton, the problem is that there is no working PROVIDES mechanism in the buildroot. We could only modify the Lua package to either build Luajit (for supported arches) or PUC 5.1 one, depending on a menuconfig setting. Can't think of a better solution. ~ Jo ___

Re: [OpenWrt-Devel] [LEDE-DEV] RFC netifd: UCI parameter to sort name servers in resolv.conf.auto

2016-09-05 Thread Jo-Philipp Wich
Hi Hans, imho it would also make sense to take any existing metric setting into account as well. At least I'd expect that if I have a wan1 with metric 10 and a wan2 with metric 20 that the DNS server entries "inherit" the same weight/order. So priority wise I'd first order by dns metric, then by

Re: [OpenWrt-Devel] How to add ubus users?

2015-09-25 Thread Jo-Philipp Wich
Hi Christoph, to add further logins to ubus simply add further "config login" sections to /etc/config/rpcd. In the same config login section you reference the ACL groups the user should have access to, e.g. config login option username guest option password '$1$$I2o9Z7NcvQAKp7wyCTlia0' lis

Re: [OpenWrt-Devel] How to add ubus users?

2015-09-25 Thread Jo-Philipp Wich
Hi Ronaldo, if you refer to the JSON-RPC/UBUS bridge in uhttpd then you can specify "option no_ubusauth 1" in /etc/config/uhttpd, this will bypass any permission checks. Keep in mind that this gives full access to anything exposed by ubus to any HTTP client! ~ Jow signature.asc Description: O

Re: [OpenWrt-Devel] How to add ubus users?

2015-09-28 Thread Jo-Philipp Wich
Hi Christoph, there is no PAM support yet but the appropriate place to add it would be rpc_login_test_login() of rpcd's session.c [1] I wouldn't mind adding PAM support if it is possible to make it optional at runtime. Haven't yet investigated whether it is feasible to dlopen() libpam if installe

Re: [OpenWrt-Devel] [PATCH firewall] zones : Redirect incoming WAN traffic only when the destination IP address matches the IP masquerading address

2015-10-01 Thread Jo-Philipp Wich
Hi, wouldn't this break port forwards to hosts not being within the range of the on-link lan subnet? I also read the patch description three times and still am not sure what that change attempts to achive. Can you further explain the problem please and provide a before/after "fw3 print" diff so

Re: [OpenWrt-Devel] [PATCH v3] lantiq: get more status information from xDSL

2015-10-03 Thread Jo-Philipp Wich
Hi, the patch caused a regression in LuCI, please see https://dev.openwrt.org/ticket/20607#comment:6 Basically the problem is that the current "lucistatus" code emits invalid Lua code by providing no value for these parameters: dsl.errors_crc_p_near= dsl.errors_crc_p_far= dsl.errors_crcp_p_near=

Re: [OpenWrt-Devel] uhttpd: chunked output from cgi script

2015-10-07 Thread Jo-Philipp Wich
Hi Luigi, thank you for your patch proposal, it prompted me to take a deeper look into the problem. The issue should be fixed with the following commit: http://nbd.name/gitweb.cgi?p=uhttpd2.git;a=commitdiff;h=7ed2edc40dd6d0171266f3bfbc96466e1d25e3cd Regards, Jow signature.asc Description: O

Re: [OpenWrt-Devel] uhttpd: chunked output from cgi script

2015-10-08 Thread Jo-Philipp Wich
Hi Luigi, > I tested another patch of mine (really noobish i know :) ) > still against commit: 993cace15114a0f06f720f34a4748ab54b695f0d > [...] > and it seems to works for the reasons I tried to explain in my previous > mail. Right, it will work but emit invalid HTTP responses if a CGI handler d

Re: [OpenWrt-Devel] SVN to GIT transition

2015-10-09 Thread Jo-Philipp Wich
Hi. > Moving to Git seemed to have lots of traction at the summit, and I'll > add my voice that this sounds like a step in the right direction for > OpenWrt. I'm assuming that we would want to do a proper SVN to Git > conversion, and Eric's help on this would be great, I think. My > discussion w

Re: [OpenWrt-Devel] [PATCH] toolchain: fix PKG_SOURCE_URL for gdb

2015-10-26 Thread Jo-Philipp Wich
Hi Philipp, applied in r47277 with a minor edit (added "CC: " tag to subject line). Please consider this from now on whenever a patch is meant for a specific branch instead of trunk. Thanks! ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.ope

Re: [OpenWrt-Devel] AR9344 Openwrt - LAN and WAN interface link issue

2015-10-28 Thread Jo-Philipp Wich
Hi Afkar, > The same thing if we connect only WAN cable and check "cat > /sys/class/net/eth0.1/carrier" and "cat /sys/class/net/eth0.2/carrier" > both returns "1" . But it should not be like this. This is expected since both eth0.1 and eth0.2 are actually SoC connection to the external switch ICs

Re: [OpenWrt-Devel] AR9344 Openwrt - LAN and WAN interface link issue

2015-10-28 Thread Jo-Philipp Wich
Hi Afkar, WAN: swconfig dev switch0 port 1 get link LAN: swconfig dev switch0 port 1 get link swconfig dev switch0 port 2 get link swconfig dev switch0 port 3 get link swconfig dev switch0 port 4 get link ~ Jow ___ openwrt-devel mailing list openwrt

Re: [OpenWrt-Devel] How to get uhttpd logs

2015-10-29 Thread Jo-Philipp Wich
Hi, can you execute this .lp file on the shell? uhttpd is a cgi server, it executes scripts as commands so they need to be world-readable and executable. LuaPages appear to be specific to CGILua or the Kepler project, uhttpd does not support this syntax out of the box. ~ Jow

Re: [OpenWrt-Devel] How to get uhttpd logs

2015-10-29 Thread Jo-Philipp Wich
Hi, > ./index.lp: line1: can't open ?lua: no such file > ./index.lp: line2: syntax error: unexpected word (expecting ")") As expected, so its not actually a standalone CGI program but a script similar to a PHP file. > How to support LuaPages in uhttpd ? You need to associate an interpreter with

Re: [OpenWrt-Devel] polluted env-space after running OpenWrt-helper scripts

2015-11-03 Thread Jo-Philipp Wich
Hi, > some things are easy for getting rid of: > one can call 'network_flush_cache()' from > /lib/functions/network.sh > > but i'am unsure how to unset all these vars: Whenever a script calls uci_load(), the previous state vars are discarded, see the declaration of uci_load in /lib/config/uci.sh

Re: [OpenWrt-Devel] [PATCH 4/4] conntrack-tools: preserve /etc/conntrackd during upgrade

2015-11-11 Thread Jo-Philipp Wich
Hi, > + $(INSTALL_DATA) ./files/conntrackd.upgrade > $(1)/lib/upgrade/keep.d/conntrackd please don't ship keep.d files manually, use the define Package/.../conffile macro (yes it works for directories as well). ~ Jow signature.asc Description: OpenPGP digital signature _

Re: [OpenWrt-Devel] Syntax to call ubus registered function (having arguments) from lua

2015-11-20 Thread Jo-Philipp Wich
Hi. > I am trying to call a function registered on ubus from lua script. I > know how to call a argument less function but don't know the syntax of a > function with args (also how to add ubus timeout). Simply pass a table with your arguments as 3rd argument: conn:call(object, function, { arg_

Re: [OpenWrt-Devel] Syntax to call ubus registered function (having arguments) from lua

2015-11-20 Thread Jo-Philipp Wich
PM, Jo-Philipp Wich <mailto:j...@openwrt.org>> wrote: > > Hi. > > > I am trying to call a function registered on ubus from lua script. I > > know how to call a argument less function but don't know the syntax of a > > function with args (also h

Re: [OpenWrt-Devel] [PATCH] ar71xx: fix wndr3700_board_detect for some NETGEAR WNDR3700v2 (again)

2015-11-20 Thread Jo-Philipp Wich
Applied in r47538 - thank you! ~ Jow signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH firewall] zones : Redirect incoming WAN traffic only when the destination IP address matches the IP masquerading address

2015-11-26 Thread Jo-Philipp Wich
Hi, did you consider to simply add "src_dport" to the redirect rule? ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH firewall] zones : Redirect incoming WAN traffic only when the destination IP address matches the IP masquerading address

2015-11-26 Thread Jo-Philipp Wich
> did you consider to simply add "src_dport" to the redirect rule? Or rather, "src_dip" in this case as it is about redirecting the proper wan ip. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mail

Re: [OpenWrt-Devel] [CC 15.05] polarssl: Security update (CVE-2015-5291)

2015-11-29 Thread Jo-Philipp Wich
Hi, > Why does this not show up in the CC git tree? [...] >> * >> http://git.openwrt.org/?p=15.05/openwrt.git;a=commit;h=72f741c118ac89f4fb6f03211227ec86c2eb5f6d >> * >> http://git.openwrt.org/?p=15.05/openwrt.git;a=commit;h=c3eab1cd32f7576a9aa21f7554cb31daeaab5e3b >> * >> http://git.openwrt

Re: [OpenWrt-Devel] [PATCH] procd: hotplug.json: allow passing hotplug events from all subsystems

2015-11-30 Thread Jo-Philipp Wich
Hi all, as an intermediate solution we could simply allow qemu specific events. I'm with John here that passing on uevents unfiltered is probably no good idea. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.o

Re: [OpenWrt-Devel] ar71xx: add support for EnGenius ECB1750

2015-11-30 Thread Jo-Philipp Wich
Hi Andrew. > Okay. I just want to apologize for hammering this but I have been having > an issue trying to post the patch using my work email (office365). It > seemed to want to send it as an attachment with dos line endings tacked > on for some reason. I think ive got that taken care of now so he

Re: [OpenWrt-Devel] [PATCH] [make_ext4fs] Explicitly call setlocale() before sorting the source directory

2015-12-02 Thread Jo-Philipp Wich
Hi Wojtek, applied to Git in http://git.openwrt.org/?p=project/make_ext4fs.git;a=commit;h=bd53eaafbc2a89a57b8adda38f53098a431fa8f4 and updated in OpenWrt with r47689 ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.open

Re: [OpenWrt-Devel] [PATCH] lantiq: fix logic error in dsl board.d code

2015-12-06 Thread Jo-Philipp Wich
Hi Mathias, you're right - I accidentally inverted the logic. Patch committed with r47793. ~ Jow signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/ma

Re: [OpenWrt-Devel] [PATCH v2] axs10x: initilaze network for wireless access-point

2015-12-07 Thread Jo-Philipp Wich
Hi Alexey, > Any thoughts how I may setup a bridge on eth0 in init scripts in board.d? with board.d, the lan interface will always be of type bridge. There is no way to declare non-bridge lan ifaces anymore. ~ Jow ___ openwrt-devel mailing list openwrt-

Re: [OpenWrt-Devel] Board detection for Lamobo R1 fails

2015-12-10 Thread Jo-Philipp Wich
Hi Vasco, thats certainly possible, I merely did a logical translation of the code. Can you please check that after changing "Lamobo R1" in the case switch to "Lamobo Banana Pi R1" the defaults are working properly? You can test with the following command: rm -f /etc/board.json /etc/config/ne

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Jo-Philipp Wich
Hi Yousong. NAK - thats by design. If a network config is present then there is no point in regenerating it. I'd prefer if the Malta target would simply drop its default config and switch to board.d, this could be useful to e.g. dynamically handle different amounts of eth* devices: eth0 -> lan

Re: [OpenWrt-Devel] Need help with Makefile error *** missing separator

2016-01-04 Thread Jo-Philipp Wich
Hi. Lines in the isntall section must be indented with at least one tab since they're shell instructions. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] use NTP server received via DHCP

2016-01-05 Thread Jo-Philipp Wich
Hi, please do not use uci state for new features, we consider uci state variables to be deprecated. ~ Jow ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] Need help with Makefile error *** missing separator

2016-01-05 Thread Jo-Philipp Wich
ns.zh-cn.lmo" ]; thenbash: -c: line 1: > syntax e r ror: unexpected end of filemake[2]: *** [/home/Openwrt/witi-openwrt/bin/ramips/packages/base/luci-app-chinadns_1.3.8-1_all.ipk] Error 1make[2]: Leaving directory `/home/Openwrt/witi-openwrt/package/my_package/openwrt-dist-luci'mak

Re: [OpenWrt-Devel] Plans for CC 15.05.1 or DD 16.xx release?

2016-01-12 Thread Jo-Philipp Wich
On 01/12/2016 09:19 AM, Nishant Sharma wrote: > Hi, > > On Monday 11 January 2016 05:42 PM, John Crispin wrote: > >> days. with a bit of luck 15.05.1 is ready early next week. > How do I bump my local git cloned source to 15.05.1? > > A simple git pull in the source directory should be able to a

Re: [OpenWrt-Devel] Random PARTUUID on every rebuild

2019-03-06 Thread Jo-Philipp Wich
Hi, the random PARTUUID has been chosen to ensure that a given boot grub partition (containing grub config, kernel, sysupgrade restore tarball) boots the correct corresponding rootfs in case multiple openwrt partitions are present on the device (e.g. different versions on different block devices).

Re: [OpenWrt-Devel] [PATCH] build: have scripts/feeds honor feed.mk of the individual feed

2019-03-07 Thread Jo-Philipp Wich
Hi, I do not understand the exact purpose of this patch. As far as I know, there is no "feed.mk" anywhere in the LuCI repo. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https

Re: [OpenWrt-Devel] Random PARTUUID on every rebuild

2019-03-07 Thread Jo-Philipp Wich
Hi, > Could this be a CLI parameter to make, or something that's written to > the .config? Once it is set in .config it will remain the same with every subsequent rebuild, defeating its purpose entirely. ~ Jo signature.asc Description: OpenPGP digital signature __

Re: [OpenWrt-Devel] [PATCH] build: have scripts/feeds honor feed.mk of the individual feed

2019-03-07 Thread Jo-Philipp Wich
Hi, tbh I don't really like the approach of arbitrarily defining "feed.mk" to be a change source. Can we extend this to take all toplevel *.mk files into consideration? I think this falls more in line with what people would expect. ~ Jo signature.asc Description: OpenPGP digital signature

Re: [OpenWrt-Devel] Meson/Ninja build system

2019-03-18 Thread Jo-Philipp Wich
Hi, > A number of upstream projects are beginning to use the Meson/Ninja build > system. OpenWrt's sound/mpc and libs/libmpdclient kludge around this, > and I would like to update the glib2 package. The latest version of > glib2 uses Meson/Ninja. just what the world needed, yet another build syst

Re: [OpenWrt-Devel] Meson/Ninja build system

2019-03-18 Thread Jo-Philipp Wich
Hi Jan, > I'm trying to add ninja and meson to packages feed. The reason for that > is described here https://github.com/openwrt/openwrt/pull/1871 and > https://github.com/openwrt/packages/issues/8315 . great to hear that! I think eventually there should be a "tools/meson/Makefile" along with an

Re: [OpenWrt-Devel] Meson/Ninja build system

2019-03-18 Thread Jo-Philipp Wich
Hi, > I think the cmake.mk-link approach would be a good idea and given > previous discussions the plan is afaik to pull in Ninja first and > once that's confirmed working via CMake add support for Meson. fine with me. > Having a look at https://www.python.org/dev/peps/pep-0537/#lifespan > it

Re: [OpenWrt-Devel] RFC: procd patch to run as container/lxd

2019-03-20 Thread Jo-Philipp Wich
Hi, > procd causes trouble when running in a LXD container, however would be > nice to use OpenWrt as small VMs. > > There are patches [0] "fixing" the issue, but they're not really > upstream ready (for obvious reasons). > > Would it be possible to add a detection to procd if it's running in an

Re: [OpenWrt-Devel] OpenWrt 19.03 plans

2019-03-21 Thread Jo-Philipp Wich
Hi, > Is there any kind of "official" roadmap/checklist available what "needs" > to be done? not that I am aware of, but from the top of my head: - make sure all targets are ported properly to 4.14 - disable all devices which cannot cannot handle the increased kernel size anymore - drop all ta

Re: [OpenWrt-Devel] [PATCH] wireguard: do not add host-dependencies if fwmark is set

2019-03-26 Thread Jo-Philipp Wich
HI, I too think that making host route installation dependent on the fwmark option is not intuitive. > So maybe we can add an explicit option 'nohostroute' instead of making > it depend on 'fwmark'? A "nohostroute" (I'd prefer "peerroute" with default "1") would make sense imho. It should also b

Re: [OpenWrt-Devel] [PATCH] libfstools: Output error in case of loop blkdev failure

2019-03-27 Thread Jo-Philipp Wich
Hi Petr, I suggest to rephrase the subject to something like "print error in case". I kept reading "output error" and wondered what went wrong with the output. > It took me quite some time today(while fixing squashfs+overlay on > armvirt) to find out, that I was missing support for loop block dev

Re: [OpenWrt-Devel] [PATCH] base-files/hotplug: add "dialout" user group and use it for ttyXYZ devices

2019-03-30 Thread Jo-Philipp Wich
Hi, the "tty" group has been introduced exactly for this purpose some time ago (1)(2). Any reason why we need "dialout" as well? ~ Jo 1: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=5523ee3459a2d346ad068ce359cdb60dcda1239d 2: https://git.openwrt.org/?p=openwrt/openwrt.git;a=comm

Re: [OpenWrt-Devel] [PATCH] base-files/hotplug: add "dialout" user group and use it for ttyXYZ devices

2019-03-31 Thread Jo-Philipp Wich
Hi Michael, > well, it seems that the second commit did not survive (at least in master > branch)... indeed, it was broken by an improperly rebased commit: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=5209cfa534293cb6d27574b51d03bd69a5defb0c I'd be fine with a v2 which reintro

Re: [OpenWrt-Devel] [PATCH v3 4/7] uboot-tegra: add U-Boot for tegra boards

2019-03-31 Thread Jo-Philipp Wich
Hi Tomasz, > BTW Is there somewhere a list of packages installed on buildbots and is the > list consistent across all of them? we're slowly converging towards this: apt-get install -y \ pwgen \ locales \ buildbot-slave \ build-essential \ git-core \

Re: [OpenWrt-Devel] [PATCH 2/5] build: image: Add pad-to and pad-rootfs-squashfs helpers

2019-03-31 Thread Jo-Philipp Wich
Hi, >>> I would like to avoid adding generating padded images by default. >> >> To just save some space? We're gzipping the images by default, which makes >> image padded to 256M just 2.7M big. I find 256M overkill for testing, so >> that's why I've suggested 32M by default for QEMU padded images

Re: [OpenWrt-Devel] [PATCH 2/5] build: image: Add pad-to and pad-rootfs-squashfs helpers

2019-04-01 Thread Jo-Philipp Wich
Hi, > Felix had a good point about sysupgrade, where we would needlesly write few > dozen MBs of 0s. In order to avoid that, I would simply add following qemu > variants to x86: I wonder what kind of storage media on x86 is so brittle that writing a few dozen MB of 0s will cause any noticeable ef

Re: [OpenWrt-Devel] [PATCH 2/2 netifd] proto-shell: return error in case setup fails

2019-04-01 Thread Jo-Philipp Wich
Hi, minor nitpick below On 4/1/19 10:34 AM, Hans Dedecker wrote: > In case PROTO_CMD_SETUP cannot be handled due to an invalid state; return > -1 so the calling functions are aware the PROTO_CMD_SETUP has failed. > > Signed-off-by: Hans Dedecker > --- > proto-shell.c | 2 -- > 1 file chang

Re: [OpenWrt-Devel] SDK enhancement proposal - add external toolchains via feeds

2019-04-23 Thread Jo-Philipp Wich
Hello Mirko, > Problem statement > > To support new chipsets, it is sometimes necessary to work with > vendor-specific toolchains. Until now, the process to add these > toolchains to the build environment is a manual one. This leads > companies to create their own automation scripts, creating a p

Re: [OpenWrt-Devel] Backport request

2019-04-23 Thread Jo-Philipp Wich
Hi Rosen, > There are two patches in master that fix long range build failures: > > https://github.com/openwrt/openwrt/commit/042d68a19593ac796098845366a235f5465816da#diff-41aaa89c68b8575d420435d3e892f369 > https://github.com/openwrt/packages/commit/5c823596dd4f51969425b7a39f9b3c2730aa4e72 > > C

Re: [OpenWrt-Devel] [PATCH] procd: add procd_running() helper for checking running state

2019-05-01 Thread Jo-Philipp Wich
Hi, comment inline below. > From: Rafał Miłecki > > This should be helpful for implementing service_running() in procd init > scripts. > > Signed-off-by: Rafał Miłecki > --- > package/system/procd/files/procd.sh | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/packa

Re: [OpenWrt-Devel] [PATCH][RFC] opkg: add License to info command

2019-05-13 Thread Jo-Philipp Wich
Hi, please make sure that the license info is only parsed when it is required by the toplevel command being executed, look at the other usages of the PFM_* macros in the source. Without this, the in-memory representation of the package trees will consume way more RAM due to the redundant license

Re: [OpenWrt-Devel] [PATCH 1/2] image: make the folder that gets included intot he RootFS configurable

2019-06-04 Thread Jo-Philipp Wich
Hi, comments inline. ~ Jo On 6/4/19 7:55 AM, John Crispin wrote: > This allows managing several different folder for varying env profiles. > > Signed-off-by: John Crispin > --- > config/Config-images.in | 6 ++ > package/Makefile| 2 +- > 2 files changed, 7 insertions(+), 1 deleti

Re: [OpenWrt-Devel] [PATCH 2/2] script/feeds: add a new command that allows generating a new feeds.conf

2019-06-04 Thread Jo-Philipp Wich
Hi, comments inline. On 6/4/19 7:55 AM, John Crispin wrote: > This can be used inside build setups for easy feeds.conf generation. > > Signed-off-by: John Crispin > --- > scripts/feeds | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/scripts/feed

Re: [OpenWrt-Devel] lua bug introduction

2019-06-05 Thread Jo-Philipp Wich
Hi, > Something has started zeroing out /etc/rc.local contents, maybe: > > https://git.openwrt.org/?p=project/luci.git;a=commit;h=1c09ee5e42550d6339bffa58d4cba3461948e19c Does it zero out itself or when using LuCI? The commit above will touch rc.local when LuCI is not used. ~ Jo signature.as

Re: [OpenWrt-Devel] lua bug introduction

2019-06-05 Thread Jo-Philipp Wich
Hi, > Does it zero out itself or when using LuCI? The commit above will > touch rc.local when LuCI is not used. This should have been: "will *not* touch rc.local when LuCI is not used" ~ Jo signature.asc Description: OpenPGP digital signature ___ op

Re: [OpenWrt-Devel] [firewall3] utils: coverity resource leak warning

2019-06-12 Thread Jo-Philipp Wich
Hi Kevin, ACK. Feel free to push. ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH opkg] alternatives: special-case busybox as alternatives provider

2019-06-13 Thread Jo-Philipp Wich
Hi, ACK on the patch. I was thinking about whether it makes sense to move out the hardcoded package "busybox" -> "/bin/busybox" path facts into some kind of external pkgname => multicall-executable-path mapping configuration but there's probably not that many other relevant packages where this wou

Re: [OpenWrt-Devel] [PATCH v2 opkg] alternatives: special-case busybox as alternatives provider

2019-06-13 Thread Jo-Philipp Wich
> Signed-off-by: Yousong Zhou Acked-by: Jo-Philipp Wich signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] LEDE 17.01.7 and OpenWrt 18.06.3 deadline on Friday

2019-06-20 Thread Jo-Philipp Wich
Hi, please merge any outstanding changes that should be part of LEDE 17.07.7 and OpenWrt 18.06.3 into the respective lede-17.01 and openwrt-18.06 branches until Friday, the 21st of June at 09:00 UTC. I will tag these branches then and start building corresponding binary releases shortly after. T

Re: [OpenWrt-Devel] block bugged

2019-06-20 Thread Jo-Philipp Wich
Hi, make dirclean will fix it. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi all, unfortunately there appears to be an issue with the build cluster which causes it to produce slightly broken SDKs with a wrong embedded package feeds configuration. Due to yet unknown issues in the buildroot (or the build setup itself), the target/sdk Make target fails to identify the cur

Re: [OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi, some updates. I managed to track down the root cause to some bad interaction between buildbot and Git. When buildbot tries to switch an already cloned repo back from a previously checked out tag to a branch, it performs this series of commands: git clean -f -d -x git fetch -t https://git.op

Re: [OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi, another update. I applied local workarounds to the phase2 builders to simply append the proper branch specification where missing in order to avoid the need to rebuild all SDKs first which will save some time. Additionally I diverted all free resources to the builder so that all targets shou

Re: [OpenWrt-Devel] Problem with "base" release repositories

2019-06-25 Thread Jo-Philipp Wich
Hi, the base repositories have been fully restored and should be safe to use again. Once again, please excuse any inconvenience caused. Will follow up with some more post mortem details later today. ~ Jo signature.asc Description: OpenPGP digital signature ___

[OpenWrt-Devel] OpenWrt 18.06.4 service release

2019-07-03 Thread Jo-Philipp Wich
The OpenWrt Community is proud to announce the fourth service release of the stable OpenWrt 18.06 series. OpenWrt 18.06.4 incorporates a number of bug fixes in the network and system userland, as well as updates to the kernel and base packages. Note that the OpenWrt 18.06.3 release was skipped in

Re: [OpenWrt-Devel] [PATCH] ubox: Run init script through shellcheck

2019-07-24 Thread Jo-Philipp Wich
Hi, I suppose this has no been runtime tested since `$(${PIDCOUNT} + 1)` will attempt to execute `${PIDCOUNT}` as command in a subshell with '+' and '1' passed as arguments to it: root@OpenWrt:~# PIDCOUNT=1; PIDCOUNT="$(${PIDCOUNT} + 1)"; echo "$PIDCOUNT" -ash: 1: not found I think the prope

Re: [OpenWrt-Devel] [PATCH procd] system: support passing "options" to the "sysupgrade" ubus method

2019-08-17 Thread Jo-Philipp Wich
Hi, > [...] > + > + blobmsg_for_each_attr(option, options, rem) { > + const char *prefix = "UPGRADE_OPT_"; > + char *name = malloc(strlen(prefix) + > strlen(blobmsg_name(option))); > + char value[11]; > + char *c; > + int tmp; > + >

Re: [OpenWrt-Devel] [PATCH procd] system: reject sysupgrade of broken firmware images

2019-08-30 Thread Jo-Philipp Wich
Hi, > [snip] > + blobmsg_parse(validation_policy, __VALIDATION_MAX, validation, > blob_data(b.head), blob_len(b.head)); > + > + valid = validation[VALIDATION_VALID] && > blobmsg_get_bool(validation[VALIDATION_VALID]); > + forceable = validation[VALIDATION_FORCEABLE] && > blobmsg_get

[OpenWrt-Devel] Merged: libblkid-tiny: addsblkid_probe_set_utf8label support

2019-09-03 Thread Jo-Philipp Wich
Merged into project/fstools.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: libblkid-tiny: useblkid_probe_set_utf8label for label set

2019-09-03 Thread Jo-Philipp Wich
Merged into project/fstools.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] Merged: rpcd: Switch to nanosleep

2019-09-03 Thread Jo-Philipp Wich
Merged into project/rpcd.git, branch master. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] OpenWrt 18.06.0 final

2018-08-01 Thread Jo-Philipp Wich
Hi, The OpenWrt community is proud to announce the first release of the OpenWrt 18.06 stable version series. It incorporates over 4000 commits since branching the previous LEDE 17.01 release and has been under development for well over a year. With this release, the re-merged OpenWrt project atte

[OpenWrt-Devel] Merged: uclient-http: Close ustream file handle only if allocated

2018-08-03 Thread Jo-Philipp Wich
Merged into project/uclient.git, branch master at http://git.openwrt.org/?p=project/uclient.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] base-files: make wifi report unknown command

2018-08-07 Thread Jo-Philipp Wich
Hi, > respectfully, the behaviour of the "wifi" command is one of the most > obtuse parts of openwrt's tooling. It does "something" with no > command output, and responds ~instantly.This is expected > behaviour for very few people. even "wifi asdfasdfa" returns > ~instantly, with no warning

Re: [OpenWrt-Devel] Drop unused kernel versions

2018-08-07 Thread Jo-Philipp Wich
Ack! ~ Jo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH firewall3] defaults: use a generic check_kmod() function

2018-08-07 Thread Jo-Philipp Wich
Hi, applied in https://git.openwrt.org/06fa692c80fb2beb69d23d0a2c5cf667aa12f4ad ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwr

[OpenWrt-Devel] Merged: Change the sigb buffer to be the same size as thefread

2018-08-08 Thread Jo-Philipp Wich
Merged into project/ucert.git, branch master at http://git.openwrt.org/?p=project/ucert.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] openwrt/packages: [RFC] Regarding preferences re: switch to codeload

2018-08-13 Thread Jo-Philipp Wich
Hi, personally I'm opposed to the entire code load thing. First of all I was unable to reproduce the tarballs offered by Github. Github seems to use an extended tar (pax) format while we pack our SCM clones using the more traditional ustar format, however even using `tar -cp -H pax --numeric-own

[OpenWrt-Devel] OpenWrt 18.06.1 service release

2018-08-18 Thread Jo-Philipp Wich
The OpenWrt Community is proud to announce the first service release of stable OpenWrt 18.06 series, which marks the first major version after the remerger of the LEDE and OpenWrt projects. OpenWrt 18.06.1 incorporates a number of mostly security oriented fixes backported from the development bran

Re: [OpenWrt-Devel] [PATCH] uhttpd: add support for mutual authentication (mTLS)

2018-08-20 Thread Jo-Philipp Wich
Hi, comments inline. > From: Nuno Morais > > Optional mutual authentication (mTLS) > by providing a CA certificate through a new new flag "-M" > in order to verify client's identity. > > For B2B applications. > > This patch depends on patch > "[OpenWrt-Devel] [PATCH] ustream-ssl: add optional

Re: [OpenWrt-Devel] [PATCH v2] build: add mkrasimage

2018-08-20 Thread Jo-Philipp Wich
Hi, > RAS_VERSION := "V1.99(OWRT.$$(shell echo $(REVISION) | sed s/^r//))C0" make that RAS_VERSION := "V1.99(OWRT.$(patsubst r%,%,$(REVISION)))C0" to avoid spawning a shell + sed process. ~ Jo signature.asc Description: OpenPGP digital signature __

[OpenWrt-Devel] Merged: bzip2: Fix CVE-2016-3189

2018-08-22 Thread Jo-Philipp Wich
Merged into master at http://git.openwrt.org/?p=openwrt/openwrt.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

<    1   2   3   4   5   6   7   8   9   10   >