Re: [PATCH] urngd: Add support for read()ing entropy

2020-07-13 Thread Petr Štetiar
nwfila...@gmail.com [2020-07-12 21:57:39]: Hi, > From: Nathaniel Wesley Filardo > > This allows us to attach a hwrng exposed as a character device (e.g.). > > At most one sample will be taken every time we also add entropy via the > jitter mechanism. We won't try reading if the stream hasn't

Re: [PATCH] scripts: Add Buildbot dumpinfo.pl script

2020-07-13 Thread Paul Spooren
On 12.07.20 17:16, Paul Spooren wrote: The dumpinfo.pl script comes from buildbot.git[0] and is used to print available targets and architectures, which are then build. As the buildbot clones openwrt.git anyway, the script might as well live here as it can be used for other cases as well, e.g.

Re: [PATCH] urngd: Add support for read()ing entropy

2020-07-13 Thread Nathaniel Filardo
Someone should update https://openwrt.org/submitting-patches then, so that the very first thing of "Patch Checklist" isn't "Single commit ( multiple commits must first be squashed, as described here )". I of course wrote it as multiple commits but was trying to follow instructions. :( Un-squashed

[PATCH 2/4] urngd: Remove some unused #defines

2020-07-13 Thread nwfilardo
From: Nathaniel Wesley Filardo These look like there had been plans to stay asleep if there was "sufficient" entropy in the system, but the code does not do so. Signed-off-by: Nathaniel Wesley Filardo --- urngd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/urngd.c b/urngd.c index f782

[PATCH 3/4] urngd: Add support for read()ing entropy

2020-07-13 Thread nwfilardo
From: Nathaniel Wesley Filardo This allows us to attach a hwrng, for example. At most one sample will be taken every time we also add entropy via the jitter mechanism. We won't try reading if the stream hasn't indicated its readiness, and we'll go back to waiting if ever the stream produces 0 b

[PATCH 4/4] urngd: Add source information to log message

2020-07-13 Thread nwfilardo
From: Nathaniel Wesley Filardo Now that entropy can come from two places, indicate which Signed-off-by: Nathaniel Wesley Filardo --- urngd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/urngd.c b/urngd.c index d6c48f8..cc2b85d 100644 --- a/urngd.c +++ b/urngd.

[PATCH 1/4] urngd: Refactor out persistant rand_pool_info

2020-07-13 Thread nwfilardo
From: Nathaniel Wesley Filardo There's no need to hold one of these structures across invocations of low_entropy_cb. Just put one on the stack and use that. Signed-off-by: Nathaniel Wesley Filardo --- urngd.c | 62 + 1 file changed, 18 i

Re: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json

2020-07-13 Thread Paul Spooren
On 10.07.20 04:23, m...@adrianschmutzler.de wrote: -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Rafal Milecki Sent: Mittwoch, 8. Juli 2020 17:10 To: openwrt-devel@lists.openwrt.org Cc: Rafał Miłecki ; Adrian Schmutzler ; Petr Štetia

umdns: fails to compile with gcc10

2020-07-13 Thread Nick
If u try to compile umdns with gcc10 it will fail with: > service.c:240:10: error: 'strcpy' offset 6 from the object at 'b' is > out of the bounds of referenced subobject 'name' with type 'uint8_t[]' > {aka 'unsigned char[]'} at offset 6 [-Werror=array-bounds] More detailed error: https://github.c

Re: [PATCH] urngd: Add support for read()ing entropy

2020-07-13 Thread Petr Štetiar
Nathaniel Filardo [2020-07-13 10:00:46]: Hi, > Someone should update https://openwrt.org/submitting-patches then, so > that the very first thing of "Patch Checklist" isn't "Single commit ( > multiple commits must first be squashed, as described here )". I of > course wrote it as multiple commit

Re: [PATCH] urngd: Add support for read()ing entropy

2020-07-13 Thread Alberto Bursi
On 13/07/20 12:59, Petr Štetiar wrote: Nathaniel Filardo [2020-07-13 10:00:46]: Hi, Someone should update https://openwrt.org/submitting-patches then, so that the very first thing of "Patch Checklist" isn't "Single commit ( multiple commits must first be squashed, as described here )". I of

[PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Magnus Kroken
Support for character classes (e.g. [:upper:] and [:lower:]) and equivalence classes (e.g. [=a=]) in the tr utility are required by POSIX. This change increases package size by approx. 500 bytes. Size before: 208372 busybox_1.31.1-1_mips_24kc.ipk Size after: 208895 busybox_1.31.1-1_mips_24kc.ipk

Re: [PATCH 4/4] urngd: Add source information to log message

2020-07-13 Thread Petr Štetiar
> -static size_t write_entropy(struct urngd *u, struct rand_pool_info *rpi) > +static size_t write_entropy(struct urngd *u, struct rand_pool_info *rpi, > char *src) const char *src > + ret = write_entropy(u, rpi, "source"); source -> device (or file), see my comment in 3/4. -- ynez

Re: [PATCH 3/4] urngd: Add support for read()ing entropy

2020-07-13 Thread Petr Štetiar
nwfila...@gmail.com [2020-07-13 10:08:17]: > From: Nathaniel Wesley Filardo > > This allows us to attach a hwrng, for example. > > At most one sample will be taken every time we also add entropy via the > jitter mechanism. We won't try reading if the stream hasn't indicated > its readiness, a

Re: [PATCH] wireless-regdb: add country selection

2020-07-13 Thread Petr Štetiar
Florian Eckert [2020-07-13 11:09:20]: Hi, > 180 files changed, 2160 insertions(+), 1 deletion(-) so the package is currently like 2.6K compressed, regulatory.db is 3.7K uncompressed so I prefer staying closer to upstream rather then to maintain this massive set of changes. -- ynezz _

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Petr Štetiar
Magnus Kroken [2020-07-13 15:49:30]: Hi, > Support for character classes (e.g. [:upper:] and [:lower:]) and > equivalence classes (e.g. [=a=]) in the tr utility are required by POSIX. > This change increases package size by approx. 500 bytes. where does OpenWrt claims, that it's fully POSIX com

Re: [PATCH] wireless-regdb: add country selection

2020-07-13 Thread Felix Fietkau
On 2020-07-13 11:09, Florian Eckert wrote: > Until now it has not been possible to remove countries from the regdb. > The packages has been extended, so that it is now possible to add or > omit individual countries in the regdb during package compile time. > If this option is not activated, then al

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Jordan Geoghegan
On 2020-07-13 08:36, Petr Štetiar wrote: Magnus Kroken [2020-07-13 15:49:30]: Hi, Support for character classes (e.g. [:upper:] and [:lower:]) and equivalence classes (e.g. [=a=]) in the tr utility are required by POSIX. This change increases package size by approx. 500 bytes. where does O

Re: [PATCH 3/4] urngd: Add support for read()ing entropy

2020-07-13 Thread Nathaniel Filardo
[resending with correct recipients; sorry for duplication] On Mon, Jul 13, 2020 at 3:53 PM Petr Štetiar wrote: > > nwfila...@gmail.com [2020-07-13 10:08:17]: > > > From: Nathaniel Wesley Filardo > > > > This allows us to attach a hwrng, for example. > > > > At most one sample will be taken ever

[PATCH v2 1/2] procd: add service instance watchdog

2020-07-13 Thread Daniel Bailey
Added instance watchdog which will eventually either terminate or respawn an instance depending on the instance respawn setting. Added service ubus method 'watchdog' which services the watchdog timer and allows update of the instance watchdog mode instance. Two modes: disabled or passive. Disabl

[PATCH v2 2/2] procd: allow optional watchdog instance parameter

2020-07-13 Thread Daniel Bailey
Optional instance watchdog timeout and watchdog mode can be set by adding: procd_set_param $mode $timeout $mode is an integer [0-1] representing instance watchdog mode of operation: 0 = disabled 1 = passive mode, client must periodically poke watchdog via ubus $timeout is an integer representing

RE: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json

2020-07-13 Thread mail
Hi, > -Original Message- > From: Paul Spooren [mailto:m...@aparcar.org] > Sent: Montag, 13. Juli 2020 11:46 > To: m...@adrianschmutzler.de; 'Rafał Miłecki' ; > openwrt-devel@lists.openwrt.org > Cc: 'Rafał Miłecki' ; 'Petr Štetiar' ; > 'Moritz > Warning' > Subject: Re: [PATCH] build: put

[PATCH] lzo: fix pkgconfig paths

2020-07-13 Thread Rosen Penev
The last commit to this package that added the pkgconfig file did not fix the paths to point to the prefix. This allows packages to find lzo properly. Signed-off-by: Rosen Penev --- package/libs/lzo/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package/libs/lzo

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Rosen Penev
On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan wrote: > > > > On 2020-07-13 08:36, Petr Štetiar wrote: > > Magnus Kroken [2020-07-13 15:49:30]: > > > > Hi, > > > >> Support for character classes (e.g. [:upper:] and [:lower:]) and > >> equivalence classes (e.g. [=a=]) in the tr utility are requ

[PATCH] iftop: fix compilation with GCC 10

2020-07-13 Thread Rosen Penev
GCC 10 defaults to fno-common, which demains unique defenitions. Signed-off-by: Rosen Penev --- package/network/utils/iftop/Makefile | 2 +- .../utils/iftop/patches/010-gcc10.patch | 20 +++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 pack

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Jordan Geoghegan
On 2020-07-13 22:17, Rosen Penev wrote: On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan wrote: On 2020-07-13 08:36, Petr Štetiar wrote: Magnus Kroken [2020-07-13 15:49:30]: Hi, Support for character classes (e.g. [:upper:] and [:lower:]) and equivalence classes (e.g. [=a=]) in the tr

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Rosen Penev
On Mon, Jul 13, 2020 at 10:44 PM Jordan Geoghegan wrote: > > > > On 2020-07-13 22:17, Rosen Penev wrote: > > On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan > > wrote: > >> > >> > >> On 2020-07-13 08:36, Petr Štetiar wrote: > >>> Magnus Kroken [2020-07-13 15:49:30]: > >>> > >>> Hi, > >>> > >>

Re: [PATCH] busybox: tr: enable options required by POSIX

2020-07-13 Thread Jordan Geoghegan
On 2020-07-13 22:56, Rosen Penev wrote: On Mon, Jul 13, 2020 at 10:44 PM Jordan Geoghegan wrote: On 2020-07-13 22:17, Rosen Penev wrote: On Mon, Jul 13, 2020 at 12:14 PM Jordan Geoghegan wrote: On 2020-07-13 08:36, Petr Štetiar wrote: Magnus Kroken [2020-07-13 15:49:30]: Hi, Suppor