[OpenWrt-Devel] [PATCH] wireguard: fix reload config on peer change

2019-11-29 Thread Florian Eckert
If we change a peer section, then the interface of netifd gets not reloaded. Because the change were not made in an interface section. And so the netifd does not recognize the change. And the new config gets not applied until we do a network restart or we restart the interface with 'ifup '. With t

Re: [OpenWrt-Devel] [PATCH netifd] interface: warn if ip6hint is truncated

2019-11-29 Thread Hans Dedecker
On Wed, Nov 20, 2019 at 7:11 PM Uwe Kleine-König wrote: > > When for example a /60 is assigned to a network the last 4 bits of the > ip6hint are unused. Emit a warning if any of these unused bits is set as > it indicates that someone didn't understand how the hint is used. (As I > did earlier toda

Re: [OpenWrt-Devel] [PATCH netifd] interface: warn if ip6hint is truncated

2019-11-29 Thread Uwe Kleine-König
On 11/29/19 8:50 PM, Hans Dedecker wrote: > On Wed, Nov 20, 2019 at 7:11 PM Uwe Kleine-König > wrote: >> >> When for example a /60 is assigned to a network the last 4 bits of the >> ip6hint are unused. Emit a warning if any of these unused bits is set as >> it indicates that someone didn't unders

[OpenWrt-Devel] [PATCH] firewall: Fix Wformat-nonliteral warning

2019-11-29 Thread Rosen Penev
Allows GCC to check the formats by switching to a define, which is a constant expression. Fixes: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] 207 | snprintf(buf, sizeof(buf), tmpl, include->path); Signed-off-by: Rosen Penev --- includes.c | 10 +

[OpenWrt-Devel] [PATCH] uci: Fix Wformat-nonliteral warning

2019-11-29 Thread Rosen Penev
A const char * variable is being passed as a format string. Unfortunately, this is not correct. A constant expression needs to be passed so that GCC can determine the types of the format properly. Fixes: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]

[OpenWrt-Devel] [PATCH] ubus: Fix Wformat-nonliteral warning

2019-11-29 Thread Rosen Penev
A const char * variable cannot be used as a format string, leading to this warning. This change allows GCC to check the types properly. Fixes warning: error: format not a string literal, argument types not checked [-Werror=format-nonliteral] 99 | sprintf(hreq->data, format, obj->name, msgstr

[OpenWrt-Devel] [PATCH] opkg: Fix -Wformat-overflow warning

2019-11-29 Thread Rosen Penev
A null pointer is being passed to printf. This can lead to problems. Fixes warning: error: '%s' directive argument is null [-Werror=format-overflow=] 41 |opkg_message(l, "%s: "fmt, __FUNCTION__, ##args); \ |^~~~ note: in expansion of ma

Re: [OpenWrt-Devel] [PATCH 10/17] ar71xx: disable TP-Link TL-WA850RE by default

2019-11-29 Thread Hauke Mehrtens
On 11/17/19 12:29 AM, m...@adrianschmutzler.de wrote: > Hi, > > Here you say WA850, but you disable WA860 ... > > Adrian Thank you Adrian for the review. The linked forum post only mentions the WA850 so I changed it to WA850. Hauke > >> -Original Message- >> From: openwrt-devel [mail

Re: [OpenWrt-Devel] [PATCH 17/17] ramips: disable ZyXel Keenetic by default

2019-11-29 Thread Hauke Mehrtens
On 11/17/19 12:32 AM, m...@adrianschmutzler.de wrote: > Hi, > > this disables "Keenetic" and "Keenetic Start". > > As there are so many keenetic variants flying around, I'd consider it helpful > to mention both in the commit message/title. > > Best > > Adrian Thank you Adrian for the review.

Re: [OpenWrt-Devel] [PATCH 13/17] brcm47xx: disable Netgear WNR2000 v2 by default

2019-11-29 Thread Hauke Mehrtens
On 11/17/19 12:30 AM, m...@adrianschmutzler.de wrote: > Hi, > > this actually additionally disables netgear-wnr3500l-v1-na without a comment > about it. > > Best > > Adrian Thank you Adrian for the review. The linked forum post only mentions the wnr2000v2 and not the wnr3500l which has 8MB of

Re: [OpenWrt-Devel] [PATCH 05/17] ar71xx: disable Netgear WNR2000v4 by default

2019-11-29 Thread Hauke Mehrtens
On 11/16/19 9:23 PM, Jo-Philipp Wich wrote: > Disable the Netgear WNR2000v4 image by default as the device has > insufficient flash space for release build images. > > Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/11 > Signed-off-by: Jo-Philipp Wich > --- > target/linux/

Re: [OpenWrt-Devel] OpenWrt 19.07 status

2019-11-29 Thread Hauke Mehrtens
Hi, I plan to tag 19.07-rc2 on Saturday afternoon and then start the builders. The problem seen with ath10k-ct will probably not be fixed in time for 19.07-rc2. Hauke signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing lis