Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Felix Fietkau
On 2021-02-09 23:56, Jo-Philipp Wich wrote: > Hi, > >> The last stable update didn't change SONAME, but it included changes to >> the same data structure that triggered the bug that I ran into. It could >> very likely have introduced very similar subtle breakage. > > this is a clear upstream bu

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Jo-Philipp Wich
Hi, > The last stable update didn't change SONAME, but it included changes to > the same data structure that triggered the bug that I ran into. It could > very likely have introduced very similar subtle breakage. this is a clear upstream bug then. Might make sense to look into how other distribut

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Felix Fietkau
On 2021-02-09 13:00, Jo-Philipp Wich wrote: > Hi, > >> The goal of reducing unnecessary build churn makes perfect sense to me, >> but I think we need to reconsider the trade-off we're making here, and >> the failure modes of each option. > > the motivation wasn't about build-churn at all but to

Re: Revisiting ABI_VERSION handling policy

2021-02-09 Thread Jo-Philipp Wich
Hi, > The goal of reducing unnecessary build churn makes perfect sense to me, > but I think we need to reconsider the trade-off we're making here, and > the failure modes of each option. the motivation wasn't about build-churn at all but to ensure that library packages can be cleanly upgraded and

Revisiting ABI_VERSION handling policy

2021-02-08 Thread Felix Fietkau
Hi, I just wasted a few hours of debugging on an issue that turned out to be wolfssl ABI breakage related. At first I thought it was the version bump. While the commit that updates wolfssl claims that the ABI didn't change, a quick look at https://abi-laboratory.pro/index.php?view=timeline&l=wo