Re: [PATCH v1 1/2] libubox: fix test_base64.t for bash

2021-03-09 Thread Peter Seiderer
Hello Petr, On Sun, 7 Mar 2021 11:27:11 +0100, Petr Štetiar wrote: > Peter Seiderer [2021-03-06 11:54:49]: > > Hi, > > thanks a lot for your nice contribution! > > > My shell/bash seems to emit a more detailed failure message than > > expected. Fix this by complete avoiding the failure messa

Re: [PATCH v1 1/2] libubox: fix test_base64.t for bash

2021-03-07 Thread Henrique de Moraes Holschuh
On 07/03/2021 07:27, Petr Štetiar wrote: You've two options to test your changes from the CI perspective. [...] Can we have these very nice instructions added to a CONTRIBUTING.md file (or something to that effect) for libubox? -- Henrique de Moraes Holschuh Analista de Projetos Centro de E

Re: [PATCH v1 1/2] libubox: fix test_base64.t for bash

2021-03-07 Thread Petr Štetiar
Peter Seiderer [2021-03-06 11:54:49]: Hi, thanks a lot for your nice contribution! > My shell/bash seems to emit a more detailed failure message than > expected. Fix this by complete avoiding the failure message using > command substitution instead of direct command execution. This needs more