Re: [PATCH] mediatek: filogic: add support for GatoNetworks GDSP

2024-11-05 Thread Enrico Mioso
Thanks Daniel a lot for your help and the time you took to review my patch! :) I think some aspects are still unclear to me, so I am asking here to get a better understanding. On Mon, Nov 04, 2024 at 10:32:27PM +, Daniel Golle wrote: > Hi Enrico, > > the patch generally looks very good. >

Re: [PATCH] mediatek: filogic: add support for GatoNetworks GDSP

2024-11-04 Thread Daniel Golle
Hi Enrico, the patch generally looks very good. Few things: - It would be better to use NVMEM in device tree to assign MAC addresses. - You could use 'fitblk' in order to have the bootloader validate the whole image before booting and prevent bootloops in case of corrupted squashfs (eg.