> If they ask you to resubmit with changes, add that too please.
Somehow I doubt that the upstream will be quick to respond, but one may hope :)
I went ahead and fixed a couple more compiler warnings and an error
when building with DEBUG enabled. I have also applied your suggested
style changes. I
> On Feb 12, 2021, at 10:52 AM, Ilya Lipnitskiy
> wrote:
>
> Hi Philip,
>
> On Thu, Feb 11, 2021 at 11:23 PM Philip Prindeville
> wrote:
>>
>> Minor nit, but please combine these into a single line:
>>
>>
>> Please indent nested #if or #ifdef's.
>>
>>
> I can make the style changes, bu
Hi Philip,
On Thu, Feb 11, 2021 at 11:23 PM Philip Prindeville
wrote:
>
> Minor nit, but please combine these into a single line:
>
>
> Please indent nested #if or #ifdef's.
>
>
I can make the style changes, but a couple of points to consider:
1. These changes have already been submitted upstream
Comments...
> On Feb 11, 2021, at 10:42 PM, Ilya Lipnitskiy
> wrote:
>
> The following commit removed _STAT_VER definitions from glibc:
> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0ab03e142500324a34087ce179ae78e
>
> That subsequently broke fakeroot:
> https://bugs.archli
The following commit removed _STAT_VER definitions from glibc:
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0ab03e142500324a34087ce179ae78e
That subsequently broke fakeroot:
https://bugs.archlinux.org/task/69572
https://bugzilla.redhat.com/show_bug.cgi?id=1889862#c13
https://for
