Re: [PATCH] zones: fix max length of zone names

2020-09-05 Thread David Bauer
Hello Matthias, On 9/5/20 4:45 PM, Matthias Schiffer wrote: > On 9/5/20 4:32 PM, David Bauer wrote: >> Hi Matthias, >> >> On 9/5/20 4:08 PM, Matthias Schiffer wrote: >>> On 9/5/20 1:11 AM, David Bauer wrote: Hi Alexey, On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: > Hi, > p

Re: [PATCH] zones: fix max length of zone names

2020-09-05 Thread Matthias Schiffer
On 9/5/20 4:32 PM, David Bauer wrote: > Hi Matthias, > > On 9/5/20 4:08 PM, Matthias Schiffer wrote: >> On 9/5/20 1:11 AM, David Bauer wrote: >>> Hi Alexey, >>> >>> On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: Hi, please, see also https://patchwork.ozlabs.org/project/openwrt/patch

Re: [PATCH] zones: fix max length of zone names

2020-09-05 Thread David Bauer
Hi Matthias, On 9/5/20 4:08 PM, Matthias Schiffer wrote: > On 9/5/20 1:11 AM, David Bauer wrote: >> Hi Alexey, >> >> On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: >>> Hi, >>> please, see also >>> https://patchwork.ozlabs.org/project/openwrt/patch/20200830211009.3359-1-dobrovolskiy.ale...@gmail.co

Re: [PATCH] zones: fix max length of zone names

2020-09-05 Thread Matthias Schiffer
On 9/5/20 1:11 AM, David Bauer wrote: > Hi Alexey, > > On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: >> Hi, >> please, see also >> https://patchwork.ozlabs.org/project/openwrt/patch/20200830211009.3359-1-dobrovolskiy.ale...@gmail.com/ > > I was not aware of this patch. Will merge yours in the co

Re: [PATCH] zones: fix max length of zone names

2020-09-04 Thread David Bauer
Hi Alexey, On 9/4/20 10:32 PM, Alexey Dobrovolskiy wrote: > Hi, > please, see also > https://patchwork.ozlabs.org/project/openwrt/patch/20200830211009.3359-1-dobrovolskiy.ale...@gmail.com/ I was not aware of this patch. Will merge yours in the coming days. Best wishes David > > Best regards, >

Re: [PATCH] zones: fix max length of zone names

2020-09-04 Thread Alexey Dobrovolskiy
Hi, please, see also https://patchwork.ozlabs.org/project/openwrt/patch/20200830211009.3359-1-dobrovolskiy.ale...@gmail.com/ Best regards, Alexey пт, 4 сент. 2020 г. в 02:02, David Bauer : > > Previously the max length of a zone name was assuming the max > length for a extension in netfilter is 3

[PATCH] zones: fix max length of zone names

2020-09-03 Thread David Bauer
Previously the max length of a zone name was assuming the max length for a extension in netfilter is 32 bytes while in reality it is only 29. Fix this incorrect assumption to allow firewall3 to validate the zone name lengths correctly. Signed-off-by: David Bauer --- zones.h | 8 ++-- 1 file