Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-03-11 Thread Supriya Shekhar Mane
Petr Štetiar writes: Dear Maintainers, > Unless there is a good reason to have this enabled, it should stay > disabled in official builds and "but Debian has it enabled" is not > valid argument either. Now that it's being decided that macro CONFIG_DEVMEM shall not be enabled by default, why can

[PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-03-11 Thread supriya Mane
Petr Štetiar writes: Dear Maintainers, > Unless there is a good reason to have this enabled, it should stay > disabled in official builds and "but Debian has it enabled" is not > valid argument either. Now that it's being decided that macro CONFIG_DEVMEM shall not be enabled by default, why can

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-14 Thread Petr Štetiar
Bjørn Mork [2021-02-14 10:33:15]: Hi, > And it's already enabled for the ipq807x and rockchip targets, so you can't > really claim that it's not available in OpenWrt either. thanks to bringing this to my attention, but I tend to believe, that this is not intentional. > I do hope you don't thin

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-14 Thread Christian Lamparter
On 14/02/2021 10:33, Bjørn Mork wrote: Petr Štetiar writes: I assume it's for some legacy reasons which don't apply in 2021 to OpenWrt. Not sure I understand what you mean here. There was a a request for this feature, so it obviously applies to OpenWrt. And it's already enabled for the ipq

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-14 Thread Bjørn Mork
Petr Štetiar writes: > I assume it's for some legacy reasons which don't apply in 2021 to OpenWrt. Not sure I understand what you mean here. There was a a request for this feature, so it obviously applies to OpenWrt. And it's already enabled for the ipq807x and rockchip targets, so you can't r

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-14 Thread Petr Štetiar
Tomasz Maciej Nowak [2021-02-09 18:02:13]: Hi, > Why do You need it enabled by default for OpenWrt provided images at > https://openwrt.org/downloads? answer to this question should be addressed in v2 of this patch. FYI it's very unlikely, that we would enable this feature in default images. C

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-14 Thread Petr Štetiar
Bjørn Mork [2021-02-10 12:33:44]: Hi, > DEVMEM is a standard feature, defaulting to Y in the kernel config: but it does not mean, that it's something you would like to have enabled by default. > and it's enabled in other distro kernels, like Debian (stable and > unstable) and RHEL (7 and 8).

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-10 Thread Bjørn Mork
Alberto Bursi writes: > On 09/02/21 17:46, Supriya Mane wrote: >> Setting 'CONFIG_DEVMEM=y' provides access to /dev/mem. >> Fixes "cannot access '/dev/mem' : No such file or directory" >> Signed-off-by: Supriya Mane >> --- >> target/linux/x86/64/config-5.4 | 1 + >> 1 file changed, 1 insertio

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-09 Thread Alberto Bursi
On 09/02/21 17:46, Supriya Mane wrote: Setting 'CONFIG_DEVMEM=y' provides access to /dev/mem. Fixes "cannot access '/dev/mem' : No such file or directory" Signed-off-by: Supriya Mane --- target/linux/x86/64/config-5.4 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/x86/64

Re: [PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-09 Thread Tomasz Maciej Nowak
Hi. W dniu 09.02.2021 o 17:46, Supriya Mane pisze: > Setting 'CONFIG_DEVMEM=y' provides access to /dev/mem. > Fixes "cannot access '/dev/mem' : No such file or directory" > > Signed-off-by: Supriya Mane > --- > target/linux/x86/64/config-5.4 | 1 + > 1 file changed, 1 insertion(+) > > diff --g

[PATCH] x86/64: Add CONFIG_DEVMEM=y for targets/x86/64

2021-02-09 Thread Supriya Mane
Setting 'CONFIG_DEVMEM=y' provides access to /dev/mem. Fixes "cannot access '/dev/mem' : No such file or directory" Signed-off-by: Supriya Mane --- target/linux/x86/64/config-5.4 | 1 + 1 file changed, 1 insertion(+) diff --git a/target/linux/x86/64/config-5.4 b/target/linux/x86/64/config-5.4 i