Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rui Salvaterra
Hi again, Jason, On Fri, 24 Jul 2020 at 10:12, Jason A. Donenfeld wrote: > > This might be a typical use case for you, but some people are running > scripts that generate lots of keys. There may be a good argument that > if you're doing that kind of thing, a tiny MIPS router isn't the right > har

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Jason A. Donenfeld
On Fri, Jul 24, 2020 at 11:05 AM Rui Salvaterra wrote: > > On Fri, 24 Jul 2020 at 09:53, Jason A. Donenfeld wrote: > > > > Testing the process once like that isn't a good testing methodology > > representative of anything at all. > > I completely agree, this wasn't an objective test at all. I was

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rui Salvaterra
On Fri, 24 Jul 2020 at 09:53, Jason A. Donenfeld wrote: > > Testing the process once like that isn't a good testing methodology > representative of anything at all. I completely agree, this wasn't an objective test at all. I was merely illustrating what a normal user will do, generate a key pair

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Jason A. Donenfeld
On Fri, Jul 24, 2020 at 10:39 AM Rui Salvaterra wrote: > > Well… > > On Fri, 24 Jul 2020 at 09:32, Rosen Penev wrote: > > > > > On Jul 24, 2020, at 1:14 AM, Jason A. Donenfeld wrote: > > > > > > Seems probably fine to me, but would you let me know if the > > > performance of `wg pubkey` suffers

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rui Salvaterra
Well… On Fri, 24 Jul 2020 at 09:32, Rosen Penev wrote: > > > On Jul 24, 2020, at 1:14 AM, Jason A. Donenfeld wrote: > > > > Seems probably fine to me, but would you let me know if the > > performance of `wg pubkey` suffers as a result? > Of course. I imagine it’s very tiny. Logging in to the rou

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rosen Penev
> On Jul 24, 2020, at 1:14 AM, Jason A. Donenfeld wrote: > > On Fri, Jul 24, 2020 at 10:03 AM Rui Salvaterra > wrote: >> >> The wg utility compiles and runs without issues in MIPS16 mode, despite >> setting >> PKG_USE_MIPS16:=0 in the makefile. Let's remove this, allowing for a >> substan

Re: [PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Jason A. Donenfeld
On Fri, Jul 24, 2020 at 10:03 AM Rui Salvaterra wrote: > > The wg utility compiles and runs without issues in MIPS16 mode, despite > setting > PKG_USE_MIPS16:=0 in the makefile. Let's remove this, allowing for a > substantial > size reduction of the wg executable. Since wg is a just a configurat

[PATCH] wireguard-tools: allow compiling with MIPS16 instructions

2020-07-24 Thread Rui Salvaterra
The wg utility compiles and runs without issues in MIPS16 mode, despite setting PKG_USE_MIPS16:=0 in the makefile. Let's remove this, allowing for a substantial size reduction of the wg executable. Since wg is a just a configuration utility, it shouldn't be performance-critical, as the crypto heavy