Re: [PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Peter Naulls
On 11/29/22 12:37, Daniel Golle wrote: I thought you are on a device with actual block storage. For your case I also can't come up with anything better which works out-of-the-box for NOR flash. Supporting fscrypt in JFFS2 would be more elegant, but that's a bit more demanding than just using wh

Re: [PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Daniel Golle
On Tue, Nov 29, 2022 at 12:05:51PM -0500, Peter Naulls wrote: > On 11/29/22 11:50, Daniel Golle wrote: > > > > > There is nothing wrong with that use-case, and it can even be > > interesting for other downstream users. Encrypted rootfs_data is > > generally a good idea, especially when rootfs_dat

Re: [PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Peter Naulls
On 11/29/22 11:50, Daniel Golle wrote: There is nothing wrong with that use-case, and it can even be interesting for other downstream users. Encrypted rootfs_data is generally a good idea, especially when rootfs_data is used to store private key material (think: VPN keys) or other kind of crede

Re: [PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Daniel Golle
On Tue, Nov 29, 2022 at 11:28:29AM -0500, Peter Naulls wrote: > On 11/29/22 10:32, Daniel Golle wrote: > > On Tue, Nov 29, 2022 at 10:23:48AM -0500, Peter Naulls wrote: > > > > > > This backports the upstream label feature in block2mtd to the 5.10.x > > > kernel > > > in 22.03: > > > > > > https

Re: [PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Peter Naulls
On 11/29/22 10:32, Daniel Golle wrote: On Tue, Nov 29, 2022 at 10:23:48AM -0500, Peter Naulls wrote: This backports the upstream label feature in block2mtd to the 5.10.x kernel in 22.03: https://github.com/torvalds/linux/blob/master/drivers/mtd/devices/block2mtd.c Where are we using block2mt

Re: [PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Daniel Golle
On Tue, Nov 29, 2022 at 10:23:48AM -0500, Peter Naulls wrote: > > This backports the upstream label feature in block2mtd to the 5.10.x kernel > in 22.03: > > https://github.com/torvalds/linux/blob/master/drivers/mtd/devices/block2mtd.c Where are we using block2mtd and why? I'm not against backp

[PATCH] linux: add in labels for block2mtd

2022-11-29 Thread Peter Naulls
This backports the upstream label feature in block2mtd to the 5.10.x kernel in 22.03: https://github.com/torvalds/linux/blob/master/drivers/mtd/devices/block2mtd.c --- a/drivers/mtd/devices/block2mtd.c 2022-11-29 07:35:32.382695321 -0500 +++ b/drivers/mtd/devices/block2mtd.c 2022-11-29 08:0