Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-04 Thread Lanchon
On 5/4/22 12:09, Sungbo Eo wrote: On 2022-05-02 17:10, Bjørn Mork wrote: I can understand that. I have not been able to find any other examples, so I have to take full responsibility for this unexpected configuration. I guess I thought it would make sense to have a "Kernel" partition large enou

Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-04 Thread Bjørn Mork
Sungbo Eo writes: > On 2022-05-02 17:10, Bjørn Mork wrote: > >> Another alternative is of course to add another partition for the >> OpenWrt kernel (pointed to by $CI_KERNPART), keeping the "Kernel" as an >> unused container only. Maybe the safest solution? > > How about using partition nesting h

Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-04 Thread Sungbo Eo
On 2022-05-02 17:10, Bjørn Mork wrote: > Lanchon writes: > >> hi, >> >> sorry for the delay. I didn't expect that kind of sharing. > > I can understand that. I have not been able to find any other examples, > so I have to take full responsibility for this unexpected configuration. > I guess I th

Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-02 Thread Bjørn Mork
Lanchon writes: > hi, > > sorry for the delay. I didn't expect that kind of sharing. I can understand that. I have not been able to find any other examples, so I have to take full responsibility for this unexpected configuration. I guess I thought it would make sense to have a "Kernel" partition

Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-02 Thread Lanchon
hi, sorry for the delay. I didn't expect that kind of sharing. your fix is not enough: when later the partition is written, it is via 'mtd -n write' which expects an erased partition. i will do a PR ASAP to fix this by invalidating the start of the kernel partition instead of erasing it, thi

[PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-04-29 Thread Bjørn Mork
Commit ecbcc0b59551 bricks devices where a ubi rootfs and a raw kernel shares the same mtd partition. This is the case for the ZyXEL NR7101 for example. The OEM bootloader has no UBI support. OpenWrt splits the "Kernel" mtd partition in a raw kernel part used by the bootloader and a UBI part use