Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-10-10 Thread Chuanhong Guo
Hi! On Sun, Oct 4, 2020 at 12:33 PM Baptiste Jonglez wrote: > > Hi, > > Thanks a lot for fixing this! > > Can you backport it to openwrt-19.07? ath79 is also affected there. backport pushed. -- Regards, Chuanhong Guo ___ openwrt-devel mailing list

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-10-03 Thread Baptiste Jonglez
-reg-access-atomic.patch > @@ -0,0 +1,61 @@ > +From b3797d1a92afe97c173b00fdb7824cedba24eef0 Mon Sep 17 00:00:00 2001 > +From: Chuanhong Guo > +Date: Sun, 20 Sep 2020 01:00:45 +0800 > +Subject: [PATCH] ath79: ar8216: make switch register access atomic > + > +due to some unkno

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-23 Thread Chuanhong Guo
Hi! On Tue, Sep 22, 2020 at 12:37 AM Felix Fietkau wrote: > You could try making a global spinlock in ag71xx_mdio.c and do > spin_lock_bh(&mdio_lock) in ag71xx_mdio_mii_read and ag71xx_mdio_mii_write I've just tried that and it doesn't work. Should I move local_irq_save below mutex_lock and send

RE: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-23 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Chuanhong Guo > Sent: Montag, 21. September 2020 08:58 > To: openwrt-de...@openwrt.org > Cc: Chuanhong Guo > Subject: [PATCH] ath79: ar8216: make switch r

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-21 Thread Felix Fietkau
On 2020-09-21 18:26, Chuanhong Guo wrote: > Hi! > > On Mon, Sep 21, 2020 at 9:24 PM Felix Fietkau wrote: >> > + >> > + split_addr((u32) reg, &r1, &r2, &page); >> > + >> > ++local_irq_save(flags); >> > + mutex_lock(&bus->mdio_lock); >> Taking a mutex in an irq-disabled section is bas

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-21 Thread Chuanhong Guo
Hi! On Mon, Sep 21, 2020 at 9:24 PM Felix Fietkau wrote: > > + > > + split_addr((u32) reg, &r1, &r2, &page); > > + > > ++local_irq_save(flags); > > + mutex_lock(&bus->mdio_lock); > Taking a mutex in an irq-disabled section is basically asking for a > deadlock. What router is this issu

Re: [PATCH] ath79: ar8216: make switch register access atomic

2020-09-21 Thread Felix Fietkau
00 2001 > +From: Chuanhong Guo > +Date: Sun, 20 Sep 2020 01:00:45 +0800 > +Subject: [PATCH] ath79: ar8216: make switch register access atomic > + > +due to some unknown reason these register accesses sometimes fail > +on the integrated switch without this patch. > + > +THIS O

[PATCH] ath79: ar8216: make switch register access atomic

2020-09-21 Thread Chuanhong Guo
ccess-atomic.patch @@ -0,0 +1,61 @@ +From b3797d1a92afe97c173b00fdb7824cedba24eef0 Mon Sep 17 00:00:00 2001 +From: Chuanhong Guo +Date: Sun, 20 Sep 2020 01:00:45 +0800 +Subject: [PATCH] ath79: ar8216: make switch register access atomic + +due to some unknown reason these register accesses sometimes