Re: [OpenWrt-Devel] merge: add OpenWrt branding

2017-10-25 Thread Karl Palsson
Zoltan HERPAI wrote: > Given that we've decided to sail under the same flag for the > benefit of the whole community, and acknowledge the > achievements of the LEDE project, let's start the final steps > of the merge. > > The git and other sources are untouched until the infra merge. >

Re: [OpenWrt-Devel] merge: add OpenWrt branding

2017-10-24 Thread Hannu Nyman
Zoltan HERPAI kirjoitti 24.10.2017 klo 14:46: Given that we've decided to sail under the same flag for the benefit of the whole community, and acknowledge the achievements of the LEDE project, let's start the final steps of the merge. The git and other sources are untouched until the infra

Re: [OpenWrt-Devel] merge: add OpenWrt branding

2017-10-24 Thread Piotr Dymacz
Hello Zoltan, Hauke, Just one, small comment, inline below. On 24.10.2017 13:46, Zoltan HERPAI wrote: [...] diff --git a/include/image-commands.mk b/include/image-commands.mk index aaece70..3507578 100644 --- a/include/image-commands.mk +++ b/include/image-commands.mk @@ -7,7 +7,7 @@ define B

Re: [OpenWrt-Devel] merge: add OpenWrt branding

2017-10-24 Thread Jo-Philipp Wich
Hi, comments inline. > Signed-off-by: Imre Kaloz Given the fact that we explicitely wanted to avoid @openwrt.org mails and that this was one of the discussion points leading to the split I find it delicate to seal the merging commit with exactly such a S-o-b. Combined with ... $ git log --a

Re: [OpenWrt-Devel] merge: add OpenWrt branding

2017-10-24 Thread Yousong Zhou
On 24 October 2017 at 19:46, Zoltan HERPAI wrote: > Given that we've decided to sail under the same flag for > the benefit of the whole community, and acknowledge the > achievements of the LEDE project, let's start the final > steps of the merge. > > The git and other sources are untouched until t

[OpenWrt-Devel] merge: add OpenWrt branding

2017-10-24 Thread Zoltan HERPAI
Given that we've decided to sail under the same flag for the benefit of the whole community, and acknowledge the achievements of the LEDE project, let's start the final steps of the merge. The git and other sources are untouched until the infra merge. Signed-off-by: Zoltan HERPAI Signed-