Re: [OpenWrt-Devel] [PATCH2] Add Protobuf library (Second submit)

2011-06-09 Thread Obinou
Le Thu, 09 Jun 2011 19:12:46 +0200, Mirko Vogt a écrit : > Commit with some adjustments in 27152 ( > https://dev.openwrt.org/browser/packages/libs/protobuf/Makefile?rev=27152 > ). > > Changes mostly are related to the use of default rules which apply fine > in this case and simplify the Makef

Re: [OpenWrt-Devel] [PATCH2] Add Protobuf library (Second submit)

2011-06-09 Thread Mirko Vogt
Commit with some adjustments in 27152 ( https://dev.openwrt.org/browser/packages/libs/protobuf/Makefile?rev=27152 ). Changes mostly are related to the use of default rules which apply fine in this case and simplify the Makefile. mirko On Thu, 9 Jun 2011 12:22:12 +0200, Obinou wrote: Hello,

Re: [OpenWrt-Devel] [PATCH2] Add Protobuf library (Second submit)

2011-06-09 Thread Obinou
Le Thu, 9 Jun 2011 12:33:19 +0200, Jonas Gorski a écrit : > One very minor nitpick (which doesn't warrant a new patch; the > committer can fix this): Haha ! Yes, sorry ! :-) I guess my other patches have the same nitpick Thanks for the review _

Re: [OpenWrt-Devel] [PATCH2] Add Protobuf library (Second submit)

2011-06-09 Thread Jonas Gorski
One very minor nitpick (which doesn't warrant a new patch; the committer can fix this): > +# Copyright (C) 2007 OpenWrt.org Last time I checked, it was already 2011 ;) Apart from that it looks good to me. Reviewed-by: Jonas Gorski ___ openwrt-devel m

[OpenWrt-Devel] [PATCH2] Add Protobuf library (Second submit)

2011-06-09 Thread Obinou
Hello, This patch adds the Protobuf library into feeds/packages. Protobuf ( http://code.google.com/p/protobuf/ ) is a way of encoding structured data in an efficient yet extensible format. Google uses Protocol Buffers for almost all of its internal RPC protocols and file formats. It's vaguely